From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD256C04FFE for ; Wed, 8 May 2024 11:58:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6238F6B0172; Wed, 8 May 2024 07:58:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3C06B0173; Wed, 8 May 2024 07:58:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473E96B0174; Wed, 8 May 2024 07:58:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29FAF6B0172 for ; Wed, 8 May 2024 07:58:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D61F3140E5E for ; Wed, 8 May 2024 11:58:26 +0000 (UTC) X-FDA: 82095081012.13.5600B19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 7D38E140003 for ; Wed, 8 May 2024 11:58:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QAe8C61S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715169504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zlMp/gqiPBMf7crP3QEcWU4N+kU8MLKVgpmCU7e8GEQ=; b=js+YYDGl49icV66couZTiINp93n9Oqo7vkBPa74w8CeVHIshwKvpcy1IUtoQbx4/ir7evU Z0HCihxaQmfHlI1wyvh3KnS+bLO7ZV/HXZwPpIOYXJBAvDarQSzqpNovOf3YLpYt6ethlY SlTPCkWLcx0xsfmVaoywDAKmWY2dlL4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715169504; a=rsa-sha256; cv=none; b=7psxTSImPLryvRkzdANQBPDsgGetUys8Hycf7cnXizrHv8xH15HYXcngLRK0YApFsj07+W FKl3h2+x6krpiYPSfAQ54Wn2VySe1j4WmIeSxe6/irAhG7xUAMEzbWOImELqG8M5kvthga uQo4/c8xBB8kiZZSfTpyf9qfJ5Rhuik= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QAe8C61S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715169503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zlMp/gqiPBMf7crP3QEcWU4N+kU8MLKVgpmCU7e8GEQ=; b=QAe8C61SU466LMRh1MI6zp+l7gsfFAyer8F1AsC6ri/gkGbxbpgIeHIMWEEM6/1mtWxkve A6tPkvNQ3NUnjM7umOhxnYjYYKC1UUv69qDY02LiMzCMDs2VK4TUA0YLi/FYzS8fWpP+Kg F+jbXYanW+ZlwQ/WEz/ZZZ7lADAGTYE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-LSI3D0TfOOO0XBDwFufi-w-1; Wed, 08 May 2024 07:58:22 -0400 X-MC-Unique: LSI3D0TfOOO0XBDwFufi-w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-418a673c191so17813305e9.0 for ; Wed, 08 May 2024 04:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715169501; x=1715774301; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zlMp/gqiPBMf7crP3QEcWU4N+kU8MLKVgpmCU7e8GEQ=; b=u/M9vhPbdTAJ+CpDMowPEpH3TKZ5VkVpuc3Nko64NLiKWzvkOGr3aY1j09Mc2z5nxD 4dWeVUmn5oDCb6VHDdednvtWjeHToiB3T4h1M8PJsEqCSdBQU/yejNq0zUkn+I2gaFKF yatCeV5k7RKKZhucQcOjVRd/w+Y64MJ0VyHHW2dGreSF4/g1xqIG8Y/Z1QBM0q9/SZnG LAflTOT8ZvKdp81+pyKNR3rfNfxCPGs7OlzwTANl6IrfLJVYZCD15i+5plHa+7ubqrVU M2joQsOdZGFJ59rMaCHtYlQvHAsv5ffPUTiJNvm72kJp3xqILMCN8b/AEWJMDaAS5okS Yz3A== X-Forwarded-Encrypted: i=1; AJvYcCUOJ5QFjotB98/2+SKvB5MUIPIQnGTAq6OQ4a+wjjZOcvvKrYOkCizdiCIOaQc2D7mic569rRF+IKgaN6wnUl9UsI0= X-Gm-Message-State: AOJu0YyGKwyBU/XuF2uh00xgCtTswHqUs0VP0lrXzAeH44PdcdaCTNcV ypm1PiJcprMH8Unv310CfRMrkrTWqAm5Ct30GYeGaLqkTcN42Vf7+6QoW2nZ5VVNYjJXkwVFSSb 9gLEM7rdmv+qu1y18Wr30WY4Chcod8qGXzaQrw053Kkr6lS61 X-Received: by 2002:a05:600c:46ca:b0:41c:7bd:5a84 with SMTP id 5b1f17b1804b1-41f71bc9fa4mr21630605e9.17.1715169501090; Wed, 08 May 2024 04:58:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9FthXz7eoL6Knu9LIh2o/Xrfrx6AYZ9VDy5KNYF62fcq0d3iwbylQhZ4or/NYE7xbx/cUWQ== X-Received: by 2002:a05:600c:46ca:b0:41c:7bd:5a84 with SMTP id 5b1f17b1804b1-41f71bc9fa4mr21630365e9.17.1715169500611; Wed, 08 May 2024 04:58:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3100:35c3:fc4b:669f:9ff9? (p200300cbc707310035c3fc4b669f9ff9.dip0.t-ipconnect.de. [2003:cb:c707:3100:35c3:fc4b:669f:9ff9]) by smtp.gmail.com with ESMTPSA id d9-20020adff2c9000000b0034dd56189e8sm15180159wrp.22.2024.05.08.04.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 04:58:20 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 13:58:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] add mTHP support for anonymous shmem To: Daniel Gomez , Baolin Wang Cc: "akpm@linux-foundation.org" , "hughd@google.com" , "willy@infradead.org" , "ioworker0@gmail.com" , "wangkefeng.wang@huawei.com" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ryan.roberts@arm.com" , "shy828301@gmail.com" , "ziy@nvidia.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7D38E140003 X-Stat-Signature: hhx4j1geigcuimrmg5j4urc79jc941on X-Rspam-User: X-HE-Tag: 1715169504-484563 X-HE-Meta: U2FsdGVkX187vgA+1GeXbN24k1edKcfZ7/jkw99mLs+cXbPUmmEvxJAs5ff20L+PjOVXIMVwx3tLshVqjqeKL8cxEd0C5oy04zBYua5X415zXeFD3jslXXcA0Qs8BXdl5RS8yZSchTf0JPWe5fJ/nZcEcDch90Aro5RSlNwStyFvHv9ZW7ONFoHtjwX3cE72x3kvPXMx4Cuw1fpe15Wc4qhaQMLAMz09VGhOLf/jAdNcbl1Jg9fmlErh0T7badqotDdtm5opIoP/k+InVcehyZkU71DpaZqKY8QjT5xT8ILbA8mgxoZ6DRXWQJqq9wTs86o4Uz1aWW0N/zuK+rE7aJ5kH0DlC9Izj64vVLTZKZ9UtosHTvogmNU/QKsHu2Vdz2cURhnkKWG1R8SaQAeltFpp4k/2Qu9JOupY+n6cXuoPpql5V2z0gtVYhuwPsxFpYEa154i7D2CW66O6jlQR9gEC8vmNgQ8jToGc2S42Al2cqKcaN+meZOto2aWGQQIkFZbbCRx252mxTdTDcQFjnaBydtQqsqfY8wXHReceqBcBm73PksmwBvhM3b5A8WO0mrQAK0RlgP9TLiVEI2azz2wL9YRz76FJ+v1iBmA2EcRqsz6Y37NNjtsuQT4kL3zyX2PLdY/m1w8zLoSp2YZLL9c8drb3dnurqD5bm2qlXYkFq8+ka18rVI6lEXEWrGcVE/p0OspH8wS9gwYnTLx8BKNf4YCkKh3BMfziyFsm973kzIE5DgCwgB2QIOwjDJtzTzenu8sXQO/x7lvfaSRZAQVbUKXHNOL8sKjClftAlon0cziAIC/kyHAGFXN46DfQfV9OGhzUnVDFb+8BpnVGJrNobImi6w36zFgomm9ruMpMIVayFEd0AyhfeVdMDDwau00s9dy/dEhtWVEE0BYgku1/nySprgoLxKr/KLXqmR9NbsUdjojHEMzd5wq9W5CZstuQjf4E8vJJPlYSoR7 NTbxksTp 8PuXeeHjBCWGLh7DE1l2On8k1pXW/zpBBdSr5V4Z5Cf3gKguZYcN36TuilR0lMZOqBHQrjM7AUP0J1a6Rv48tpDnlu7e2pJj1Qo42QftY3fwr52k/fx/bVk6JLOKKt49cBqViKfiTKUy+MQOuVA7XdL/KKFfCqu6eEYBJR+r3CRbzLjWu2IlZMynzDq3p7N2NG9vvMjW0FkZOEPtKPr5Drm8dUoUG+PpBlHQavSc1vmhjmT86fTmAT/PDaamXPUSsGggvI82rPFbQodKQZ1rWzK9w8pwImsr3RmQUm6BHlljO6qmh1VRgJwy8BmzCAAPkQX/HAJR152YQDnQcamkB4RK4KODP4djgs9J8oOG2xyDr8fJ+N/fYYIjtQR9Lgd+YjcJVwsv5vF5FtChCMZc8U98dWxWCF+YgEziN2B/3PCbhKy/Pq/9RouR1kYG+nkZWLwgZzreiP1MkAXAvjJNFQqRksQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.24 13:39, Daniel Gomez wrote: > On Mon, May 06, 2024 at 04:46:24PM +0800, Baolin Wang wrote: >> Anonymous pages have already been supported for multi-size (mTHP) allocation >> through commit 19eaf44954df, that can allow THP to be configured through the >> sysfs interface located at '/sys/kernel/mm/transparent_hugepage/hugepage-XXkb/enabled'. >> >> However, the anonymous shared pages will ignore the anonymous mTHP rule >> configured through the sysfs interface, and can only use the PMD-mapped >> THP, that is not reasonable. Many implement anonymous page sharing through >> mmap(MAP_SHARED | MAP_ANONYMOUS), especially in database usage scenarios, >> therefore, users expect to apply an unified mTHP strategy for anonymous pages, >> also including the anonymous shared pages, in order to enjoy the benefits of >> mTHP. For example, lower latency than PMD-mapped THP, smaller memory bloat >> than PMD-mapped THP, contiguous PTEs on ARM architecture to reduce TLB miss etc. >> >> The primary strategy is similar to supporting anonymous mTHP. Introduce >> a new interface '/mm/transparent_hugepage/hugepage-XXkb/shmem_enabled', >> which can have all the same values as the top-level >> '/sys/kernel/mm/transparent_hugepage/shmem_enabled', with adding a new >> additional "inherit" option. By default all sizes will be set to "never" >> except PMD size, which is set to "inherit". This ensures backward compatibility >> with the shmem enabled of the top level, meanwhile also allows independent >> control of shmem enabled for each mTHP. > > I'm trying to understand the adoption of mTHP and how it fits into the adoption > of (large) folios that the kernel is moving towards. Can you, or anyone involved > here, explain this? How much do they overlap, and can we benefit from having > both? Is there any argument against the adoption of large folios here that I > might have missed? mTHP are implemented using large folios, just like traditional PMD-sized THP are. (you really should explore the history of mTHP and how it all works internally) The biggest challenge with memory that cannot be evicted on memory pressure to be reclaimed (in contrast to your ordinary files in the pagecache) is memory waste, well, and placement of large chunks of memory in general, during page faults. In the worst case (no swap), you allocate a large chunk of memory once and it will stick around until freed: no reclaim of that memory. That's the reason why THP for anonymous memory and SHMEM have toggles to manually enable and configure them, in contrast to the pagecache. The same was done for mTHP for anonymous memory, and now (anon) shmem follows. There are plans to have, at some point, have it all working automatically, but a lot for that for anonymous memory (and shmem similarly) is still missing and unclear. -- Cheers, David / dhildenb