From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA4DC77B7A for ; Thu, 25 May 2023 03:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC5A26B0074; Wed, 24 May 2023 23:51:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E75E5900002; Wed, 24 May 2023 23:51:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D641C6B0078; Wed, 24 May 2023 23:51:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C2D556B0074 for ; Wed, 24 May 2023 23:51:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 798EF4057A for ; Thu, 25 May 2023 03:51:00 +0000 (UTC) X-FDA: 80827401480.04.4CDD6E8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id AA23F2000D for ; Thu, 25 May 2023 03:50:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684986658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GruvZ1UKGhvtDpSKc28m/Bit4OnnOrv8A5doHRqPlzo=; b=A4AzKaqxB9l0v24fxY5pEVa56jRB7aBiwBvNIYHe2n7Hkb3GNjtEka0AyzD2fz6cfUF/uW iCgKwJAWzwfqfhoQf/KO9Z/uLAniujcizR6ATjG8MvXElxkfnT6mLGg5BUcC7oPHCZg8jW lwuwQ2pfZX2peb/ewvk0qMnGkIgzZgo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684986658; a=rsa-sha256; cv=none; b=e8bEbRjgqIO+RQp+oSSP/NNwoV7MypGt+Gdl8c9n0055kIud8HYN/s08wsAziqOxDpyaeF +2R6QGWZFt4O/zLHdphN1txdgg3f0Q8Wdpx0Ee5wfHu+IU06X/S/DcaNPcQLqiPkYtA0PJ THNVk8u8QEXg4xBflx8srOszY+w4gWM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EEED1042; Wed, 24 May 2023 20:51:42 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9CB93F6C4; Wed, 24 May 2023 20:50:50 -0700 (PDT) Message-ID: Date: Thu, 25 May 2023 09:20:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 29/36] mm: Remove page_mapping_file() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-30-willy@infradead.org> From: Anshuman Khandual In-Reply-To: <20230315051444.3229621-30-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AA23F2000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: se6hnb3xpcf9prdrpasahrpioe67xe9d X-HE-Tag: 1684986658-115959 X-HE-Meta: U2FsdGVkX188N/+4niuhGMhrjScG2ANOGFQdHz6YISNrGHWCyi2oGtaRHM+aFe7Ndyf9M1JHSOJrjC+bZprIshi/aJJgB0XdvHRMHsvtG5X26FEeSRT67WQgqD+5rFAlkeaDh64E2e/9rlci9nGdak77eIFUWA+Ugc12GfxVGa+EvTKqfzJ7spn+RlVR9ndZ/w0J5ST8XvXwnSHmrc1SkJT6Z8N7fUX5qEXnXrVgwxjVIHFmHoxFUaX6c7otYi1uEEvkPs4CePB0AorKU1/8Cq9iVhmXUge1QXPOZmxbrCGzgoEpt4CabrXSOhbJdR656bz17nYXCwQpfQuj8jYQEjtCIIHRr1fgV1Q3R0pBBqoluSFnhKd758wu2rKvaZ7CqvsMAJMnxjG7xwv5n+R6cyXvaEBbKidhAGyilbaKGoz5jX7u4TwXFLPGs3LlkzNK80nY+l9LaUplTa90uRVJ5i6nTVLcK1mJcM4lwKeueeJWFk1FDSwv1VGouLuqEMabmb8O9bPxoAn9P5F1PfiIPbjdmZTaAmFMqq9I0+2o+ANXdmgJUc8RhC9x+DwoV53upheRVeUyxOYcOAgx46EW24/ur9yw1ItNTBhoc2aeEn/w76lo8Orpd1Xqdr7Kujdj26Ps1szhGpTX2vxdV1qf4RaaNFhk1tr/RvS53xGsNZ3c3IbZIOB4niXBN7C203oJGevHX2fz0uJG6r1BpmsD6E4BYyfzbxvB5KhEvP0S8Kgb3A4Wrs54lqmILahs1CzKQ89S1sL+bm+RG/eQvKx+o6yg9VunOcPj5FroHWOdp8g+uvSyGiygq9XRsGwy3a4TWeZENDsXZaI9iAHVqu2l0LFnpJ1JFgllJJLoqBioxu+WGcgjfP/tYUEQn2ThHxz/mydYTAhoSwgxveZUrLFTsX2LyN/KY3vi6udQq+/SaLq+PxXlkpwE0iWzLsFhkpHN72ntFQibALI28b38Tf8 tsbZUEYD BrqtofVlSZqIygwWm0K+2JDn3r7XpUvMSlv+9Q6UD1j5y35oWesnlTXyBSwJPHlvu7Uia9Em1oxwOVzN5aQau3lKOt/NUZopAlaRhqyIysSKCCuimoK/FgmcyYsZ5aZ9PSYI7Qz83e6kNMXvIItxv1Iui9uDmJTSmOSvlB7K/xY3fHk9F+rOdxDyjzkXv0YBl3zpwSTw7WLvf50p0nOwtgUxxsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > This function has no more users. On v6.4-rc3, there are still some users. Am I looking into a wrong tree/branch/tag ? ~/workplace/linux$ git grep page_mapping_file arch/arc/mm/cache.c: mapping = page_mapping_file(page); arch/arm/mm/copypage-v4mc.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/copypage-v6.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/copypage-xscale.c: __flush_dcache_page(page_mapping_file(from), from); arch/arm/mm/fault-armv.c: mapping = page_mapping_file(page); arch/arm/mm/flush.c: mapping = page_mapping_file(page); arch/arm/mm/flush.c: mapping = page_mapping_file(page); arch/csky/abiv1/cacheflush.c: mapping = page_mapping_file(page); arch/csky/abiv1/cacheflush.c: if (page_mapping_file(page)) { arch/mips/mm/cache.c: struct address_space *mapping = page_mapping_file(page); arch/nios2/mm/cacheflush.c: mapping = page_mapping_file(page); arch/nios2/mm/cacheflush.c: mapping = page_mapping_file(page); arch/parisc/kernel/cache.c: if (page_mapping_file(page) && arch/parisc/kernel/cache.c: struct address_space *mapping = page_mapping_file(page); arch/sh/mm/cache-sh4.c: struct address_space *mapping = page_mapping_file(page); arch/sh/mm/cache-sh7705.c: struct address_space *mapping = page_mapping_file(page); arch/sparc/kernel/smp_64.c: page_mapping_file(page) != NULL)); arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL && arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL) arch/sparc/kernel/smp_64.c: if (page_mapping_file(page) != NULL) arch/sparc/mm/init_64.c: page_mapping_file(page) != NULL)); arch/sparc/mm/init_64.c: if (page_mapping_file(page) != NULL && arch/sparc/mm/init_64.c: mapping = page_mapping_file(page); arch/sparc/mm/tlb.c: mapping = page_mapping_file(page); arch/xtensa/mm/cache.c: struct address_space *mapping = page_mapping_file(page); > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index e56c2023aa0e..a87113055b9c 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -394,14 +394,6 @@ static inline struct address_space *page_file_mapping(struct page *page) > return folio_file_mapping(page_folio(page)); > } > > -/* > - * For file cache pages, return the address_space, otherwise return NULL > - */ > -static inline struct address_space *page_mapping_file(struct page *page) > -{ > - return folio_flush_mapping(page_folio(page)); > -} > - > /** > * folio_inode - Get the host inode for this folio. > * @folio: The folio.