From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8788E7719D for ; Fri, 10 Jan 2025 20:29:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ABD96B00D4; Fri, 10 Jan 2025 15:29:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 534836B00D8; Fri, 10 Jan 2025 15:29:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D6386B00DA; Fri, 10 Jan 2025 15:29:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19CAB6B00D4 for ; Fri, 10 Jan 2025 15:29:56 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CBC37A0E3F for ; Fri, 10 Jan 2025 20:29:55 +0000 (UTC) X-FDA: 82992683550.12.545FB63 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf26.hostedemail.com (Postfix) with ESMTP id 32B6014000A for ; Fri, 10 Jan 2025 20:29:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736540994; a=rsa-sha256; cv=none; b=TgctvMxX1YxMWXQeNrvxe5SHCPRXsAhZyzLy+gm/R4+fnuGgXkqphX6vBsvIEJubyfS7gW XNKqv3PcLVDSjZHp0PrY8f8pYUi/H+ZjGUgNCAkOm3udAarkjtFXm2XhGe8Agr9xSA2e0T rLqnm3fXkGXHocV1zvxSwxXZ4Fpf3ZM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736540994; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7VChmqQ4ROu1kDbf/QH/OB5wRclzEtbgBQZIa1qGs+E=; b=v27xDsE5obUXyBzq5SUqiPA4SRLIqN9zQlE6RTi2tpZkL8S6SexqwehGwOBRo+hPJItL7f nnlBJf1ca96J5PLGvCzYg3l8HPiI040Sj2o9IgCF6ZVLrNTe31Yvaw6oM/e6aDvsaGehnA qeED2hHOXafbD74fosTMmrTjpTnKqYM= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tWLd6-000000006fs-3H13; Fri, 10 Jan 2025 15:29:16 -0500 Message-ID: Subject: Re: [PATCH 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Tom Lendacky , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Fri, 10 Jan 2025 15:29:16 -0500 In-Reply-To: References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-7-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 32B6014000A X-Stat-Signature: jkuixqqi5fwktcg8cuc6r5wf8seu5km8 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736540994-911616 X-HE-Meta: U2FsdGVkX18xVrx+lz52lMk661VL/Pdlg0ORq/LjwFgaE9TFErtoFItb45SIx78z5NpsAwN8Z522osYDY7MPr2ltGO2arJwwuna7wiPg5S1Fh4dG2EPOSO2dm+EsmqJdAb5RcF4cftHk2uPS8b2doNZ/7kI8Bh5FgZG3lqCFTfOE2AeZH4w4Js0Y0yOt2My2JAy9zxxkc/OABLqp0blZGSys9lGe+K06DJrV8gXIV6dNGLam+R2BgBpWusaVPbtpvPzz+XwYQpBWw3mjmrRAw7+1nAAKICxjMY3HZACLzoZQTdhjKBNgiXD/AhQYtVrs2zxjZnQy6C8wAChy+qhPpca7mxtSsUxv5QK3IZsyBgGv90xK7NN9jCn+t1gk1Hwzk99uFuaYRzeiuYzsqDs4DvWpufoVvJ6xo4njE1nqGgD7JNonzBcgAr9sGsEZ7EcdSYN2Qqb0fMGP6zZx5VeQH9JW29Y8RQkHu9RuYponHldSF74eRHFkDG0NlhPnRxwvm/YrqcMUhhwxnQG20MG8FG4jvKvq+IOm9l4Cq+M031ZQJ4eXwgxtRzEM7Zaevr+02S5F1uqigUgX3TODmUqfkevu6Fnk9Gi8eg680XBu2bKdIgIAV/tWZL9QZnemtxQWmXSISo6MO1EauEJdIjGKilPIY2CYNW/Zf4TAV5U2WeFzhVVEczp+zArSXVgvgENtAhscmK2GQWpIIOLqambiHXXdUAROAaYAQPsZr+2a2EP2vbSFavNRfhjVLR6+3PR1PuzJhCh9uyB/bItXXk5cfUuOr8FB3setZdza31tUdA1EN/ZONwHXGk6wG0z1rM9ubfoJDlHv3eOwbXpGwLVkA6ZPU7mpTJ8Qn6cdCw+0NqAnUKRFWPj+c+4WWgUJLO5EB5R7MP+DiXT/E4FgPUU9f7RR98/+VatLNTSqLVt1gvIoLVtWWhKouukd1H0vKT5g/nybsJWEd87QN+FIYAx 7OSXyWLJ C+dekYewdnsZKAT6gZDe5mjf7mKWK/DFWIdIzVgg3BoFg35VUYhASAzu7EUxu/NsuP8Hy4J6EeBQxZXEVVxmh4l1F/XCq/4jvkJfuB/Kjru+IFmN8BjauXaiUVf3MAVjZv2qsI8kpeBg3xw8H5nJx/poVALAKwB6CKKxLYC7P/gl4lhCkhhU1BsvQjIMnRxdqLbqTx8U3oKjGNfuhEKFFHepCvvc8Xefktf5YS1Gz5g/3f3w8Zv8fGbpuTMlcbggQ3dnpzGB075CpEhK9CCwGZBhe4NAbshytHyraF7Q9h3trfouJSiHAryLHZDgWV6K2zCy2gDEei2/998no0pi8gkB90Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-01-10 at 12:53 -0600, Tom Lendacky wrote: > On 12/30/24 11:53, Rik van Riel wrote: > > Use broadcast TLB invalidation for kernel addresses when available. > >=20 > > +static void broadcast_kernel_range_flush(unsigned long start, > > unsigned long end) > > +{ > > + unsigned long addr; > > + unsigned long maxnr =3D invlpgb_count_max; > > + unsigned long threshold =3D tlb_single_page_flush_ceiling * > > maxnr; > > + > > + /* > > + * TLBSYNC only waits for flushes originating on the same > > CPU. > > + * Disabling migration allows us to wait on all flushes. > > + */ > > + guard(preempt)(); > > + > > + if (end =3D=3D TLB_FLUSH_ALL || > > + =C2=A0=C2=A0=C2=A0 (end - start) > threshold << PAGE_SHIFT) { > > + invlpgb_flush_all(); > > + } else { > > + unsigned long nr; > > + for (addr =3D start; addr < end; addr +=3D nr << > > PAGE_SHIFT) { > > + nr =3D min((end - addr) >> PAGE_SHIFT, > > maxnr); > > + invlpgb_flush_addr(addr, nr); > > + } >=20 > Would it be better to put this loop in the actual invlpgb_flush* > function(s)? Then callers don't have to worry about it, similar to > what is > done in clflush_cache_range() / clflush_cache_range_opt(). Maybe? We only have one caller, though. --=20 All Rights Reversed.