From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9B7E7717F for ; Tue, 17 Dec 2024 17:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E4B46B008C; Tue, 17 Dec 2024 12:43:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 594E36B0092; Tue, 17 Dec 2024 12:43:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45CCC6B0093; Tue, 17 Dec 2024 12:43:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2A8556B008C for ; Tue, 17 Dec 2024 12:43:38 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C9ECD120860 for ; Tue, 17 Dec 2024 17:43:37 +0000 (UTC) X-FDA: 82905171846.19.63A6586 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 6C47840018 for ; Tue, 17 Dec 2024 17:43:22 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=VkPXr4Q5; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf12.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734457402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qz8oz73s4rCDJSC1TgNUQNYJjOVU8exHA2BYkyw+ZD0=; b=tSiSJHSwjLGJykEdV3anR/Np9n2VJeTB//Vt8dcxCrT7fqJQYRwrFQ8FWL8MfT/nn8u1gd hRlgxgpStM6deaYk1xmiBTGSsJC1OwjldDQA2eSvWCU+5jYUU6AKe8dAjSlWF/HTmL7GvU SzlJjABgeiN2JFTUmwyRmjLl2uUB2mc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734457402; a=rsa-sha256; cv=none; b=dKShGciBTMUcivsIs/iWXrh4BPUKHbNGODXOOZHWxTqf/c0I0VXDIFFVJrkBW2NgExqcLg 9uRqHy5YFAvHbA/qGro+CIL9MKly543JppoZn+S5WyWRBOz1Z+AfPkZnnPcB4oWwt0m3xS Yo8Ed+hN+KnnDlmvg3N+c+0v4pjaIcA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=VkPXr4Q5; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf12.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 4C1542171F87; Tue, 17 Dec 2024 09:43:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4C1542171F87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1734457414; bh=qz8oz73s4rCDJSC1TgNUQNYJjOVU8exHA2BYkyw+ZD0=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=VkPXr4Q51kSzYXC6iV4Rnt0hdXMx9YWH59To4VTRyzVF/4SXLeJpUxO01knfWumzM CzAbcmQnzc2Qsz94yaL1AgsNLmsei1LV793lD8Qkn1YDLJvzyEf9X476Tc2IwzAabU HeEAso29uXPVkfVcznz9hizNBAvL5QWBolCDD9Qs= Message-ID: Date: Tue, 17 Dec 2024 09:43:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v3 02/19] coccinelle: misc: Add secs_to_jiffies script To: Julia Lawall , Alexander Gordeev References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-2-ddfefd7e9f2a@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ytbgd1um1rfmjsgt4mcqeztbzsei8kn6 X-Rspamd-Queue-Id: 6C47840018 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734457402-825800 X-HE-Meta: U2FsdGVkX1+0QoRIRQ8Jqt80i1AffMdv4MF0GxHL/nAZLR0FkuHOQhAOBI5iq/oIl06UDzTIUY6wn0MVm5vBMl3whidhvhvOpxWXhzVaAAF1FpacJjUHuy3K/txTtO/NQXbgn2lIT4r8a6apkS7ZRI8HQNCKLc8oT0KtWxwEvkMjF6Ij0e1ol5guJSn9kvcecLN9KAAYObBowrWQW+Ot1/EznL2stN7nIfSm/wEqg2IpIjDXx5Ocle2MSKwdsnGzypo+FDKzxXFPeqeDnv2Y0Urh7qz+gGtvivtcpnUPDlm00jkv/wsICIHBLfsmiXs1s1QlixHfekuOjyx3MeVQy/pQpF71HGQIzcs6LKL91OhGm771IsEzaW1WlwB1NvPE0bTPP5vt2bb3Vu0wOO67ftzOpImOxIrEhoEkHCCX96togb6LQxIT1ilId4A9lz+PaE1Xjm0jUuiVyspyA9xepNt2FJhtaRKjoEQ2imf8cK2HDskbgOrUVKSV+oeDfCPASqmUh3h5zu4UOxK697iJI/UZtw3FzhPmY5QRe0Gje05+LwOnwbypJQ34SsjHM2ibG1TdhFl4AA5ul7NrAVLPYSUP1fQGn06d0H8nUGJ0+kunfbeiM8gof1nVi+yUeezoaHTKAgaDVkCMHruifoeT4PuEg8zvugl9DqTHLuDQ1I2uSm+P6cfFxkUPAnhv9Z3Vm2wlXcN0o3dRf/Rl1nvNjkDDS1BRVz7srpm44n2K4FVFIEqUQDmVJ14vEhHNspPMUnoxRyWYPYQT0rAUlJDWwPOx0Mqzcfz8flNgmMtk7XTMXlZIElocdMGlkO6rTU5XDyY7NSvpQPzDOfBUPRp6feS47DI019RSgYTZ8vWdww1utkzflnSsPVnsNWyCawfSsH4/qwzpDhLeNIgrdf2xkFBlCWjGkSZ2GzeIKJ9k+GwpaQB6o7Kk98Tq5PXa/UoQn9nIKr+Yn9uLj4B4pJ9 Fx/kifJY GWraCORJoZ+fKZ1CzDKyl5CIT/M9ZKJJ8eg4fMRZliU8Gn7d1qQSIRQn0E+kWGMD0LHy4TkeAuX2BbU4toyKCIISCPAeF+WjzNz9Lni5aMzgSqBUOzE86BQSdvStiR3O7JaC/KfW+WcqUUd7rU6uOhM6dW8vErcRVsuyAIkn5TkAZp8s2FjJykrp2Jd9WGtofTueMY7X4VbLkbYzfyY5BPziIo+uND1P98mGMYhM4uMuNtC8ORTQISvdNC4P0tKMK4m/zq4ZBVL6aEjPQcnxdUPQOJk7Yb5MXjGiRGJwIu9b0ihrtwEU9Zz5qV+4CuQrzndDoS4sgwauOjG2qb70SCOg6gjR+RgtYDoUvFXXq+NK6UwzSkjYw9Vy0noiBmf/TtQOQWDZn3z9LkIBpmKhJ2lK4B6PhsyDkcqH8Gq4RetUpmLdalPilH7AZDaztWzuYgLwXwqaprtb5dMdVaJ6fV0iZTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/17/2024 9:33 AM, Julia Lawall wrote: > > > On Tue, 17 Dec 2024, Alexander Gordeev wrote: > >> On Tue, Dec 10, 2024 at 10:02:33PM +0000, Easwar Hariharan wrote: >> >> Hi Easwar, >> >>> This script finds and suggests conversions of timeout patterns that >>> result in seconds-denominated timeouts to use the new secs_to_jiffies() >>> API in include/linux/jiffies.h for better readability. >>> >>> Suggested-by: Anna-Maria Behnsen >>> Signed-off-by: Easwar Hariharan >>> --- >>> scripts/coccinelle/misc/secs_to_jiffies.cocci | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..8bbb2884ea5db939c63fd4513cf5ca8c977aa8cb >>> --- /dev/null >>> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> @@ -0,0 +1,22 @@ >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/// >>> +/// Find usages of: >>> +/// - msecs_to_jiffies(value*1000) >>> +/// - msecs_to_jiffies(value*MSEC_PER_SEC) >>> +/// >>> +// Confidence: High >>> +// Copyright: (C) 2024 Easwar Hariharan, Microsoft >>> +// Keywords: secs, seconds, jiffies >>> +// >>> + >>> +virtual patch >>> + >>> +@depends on patch@ constant C; @@ >>> + >>> +- msecs_to_jiffies(C * 1000) >>> ++ secs_to_jiffies(C) >>> + >>> +@depends on patch@ constant C; @@ >>> + >>> +- msecs_to_jiffies(C * MSEC_PER_SEC) >>> ++ secs_to_jiffies(C) >> >> If you used this script only, then it did not seem to recognize line arch/s390/mm/cmm.c:207 >> >> mod_timer(&cmm_timer, jiffies + msecs_to_jiffies(cmm_timeout_seconds * MSEC_PER_SEC)); > > There is the requirement that C is a constant, and cmm_timeout_seconds is > not considered to be a constant, ie it is not all capital letters. > Indeed, it doesn't seem to be a constant at all. I don't know if the > requirement of being a comstant is really necessary. > > julia > >> >> Thanks! >> As the cover letter says, this is part 1. I intend to do further parts that address the cases where the multiplicand is an expression, as well as the cases where the timeout provided to msecs_to_jiffies() is denominated in seconds (i.e. ends in 000) Thanks, Easwar