From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D53CF9C7E for ; Thu, 26 Sep 2024 12:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DEEA6B0098; Thu, 26 Sep 2024 08:58:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48E716B0099; Thu, 26 Sep 2024 08:58:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E0DB6B009A; Thu, 26 Sep 2024 08:58:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1008F6B0098 for ; Thu, 26 Sep 2024 08:58:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B02C01A185E for ; Thu, 26 Sep 2024 12:58:18 +0000 (UTC) X-FDA: 82606892676.03.77E644D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 7C422C0007 for ; Thu, 26 Sep 2024 12:58:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PAC0CyQ4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727355362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dBhH7BEffqYew0a0qy+WrB9ksqzmVcoADZs7pD+b9rc=; b=hEo2xw9bxPytF8BOJdxPNnFUJFHWMjRjsGtgzbUU+IY7bpfIXnP+4myTaDd5We81974akI 78scsXnFnaP3xPxj+Pd3nIekTlJNFJgTDoR7nkNOMhapgboqFbMrzQBPYh7HNVYSw/vjqz SlsP+bM9HCc7F0Q6MF2EKvGKVTzh0ro= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727355362; a=rsa-sha256; cv=none; b=5H1elfEvZ4ZYeqp9m3y7ZJ4EGudKQsPygAN73tMOiR0SzoqYu8ITkt8cTrsmYTq1PmJTc9 SpaVJTEwORxQymTMzQZlyFspajUJwcotpZtScUrhVDZrOZGyEIo+QwQSeTC7OYH8Em8zcH TUAwDTkrj9dvktTWX+ai+8AVtDwboV8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PAC0CyQ4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727355495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dBhH7BEffqYew0a0qy+WrB9ksqzmVcoADZs7pD+b9rc=; b=PAC0CyQ4SlIt1DQlfzmUWaw85g/5z9ULmTAt3GdbjW2v18+kW5tHtZaKYxHsjUrTqayC9P f9+R9XIftweOyrPlFrxVQCRrDqKa+onis3IBIg4BwiBLUqO7DASJo4wTG1EtCfolXR5U7D x4zqzqWX52sDps/MBXDS9rDFHp+5UNM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-Qb6eLP8FMkeVgjBpHVb7Eg-1; Thu, 26 Sep 2024 08:58:12 -0400 X-MC-Unique: Qb6eLP8FMkeVgjBpHVb7Eg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37ccc99920dso672385f8f.0 for ; Thu, 26 Sep 2024 05:58:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727355491; x=1727960291; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dBhH7BEffqYew0a0qy+WrB9ksqzmVcoADZs7pD+b9rc=; b=jigSaQUKJOkXWSCepeap98b+cGc68dhmaAmN22v65iYaAE/ctYSQX+KLVOt91UxB/6 YFRS+SD58xKWSCnEv+Rm8iBtEgWdG2ikH0vGU6x1wW6aMNSQ3k7Ibtqs+XLp1QatxLdX ++MrYGnkaoH8pBaD/aihAhNb/XC+s8jA6EdwPJQDsktCC8u1MlAm/9Cig5LB6xd3XsMu p0fmvjxQYhWF/nn0+rsqi5uYY3LDrSFqiC9cdarL0CCKSWws+S08yRWKetEpnpIFjAQg 0fW2G5KAsItfEPJL6RSe7Z7Vf2Ye15/CtBReVKJpLl7wX9CpCm377WaA+uiyxeHRH3r6 whRQ== X-Forwarded-Encrypted: i=1; AJvYcCXH1tqoB4mGmwIq1VFTiOSfNWZxF6fHRJ+bJjapNNzY0c2BUPce2vsdJWPT5JB172EJTE1mI+X2bw==@kvack.org X-Gm-Message-State: AOJu0YwqFK9rwrJcbTPs5WCF2upv47DxRmG2y4GQfYb+ZjCBlyG/ToxK IFChPdhKj/+bYhL7zXe71IZSVCU5LjtK0lGMh9ffAFJ8hccc5nWxcFugpVNvXOLmOXXKgno8N+3 1NwPM6Fs0wlgQkVFM0HHJGEurWKIgYPddQzs/4qB74WXqRUNQ X-Received: by 2002:a5d:5e04:0:b0:37c:c5da:eaf7 with SMTP id ffacd0b85a97d-37cc5daeb42mr3185990f8f.31.1727355491319; Thu, 26 Sep 2024 05:58:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbdUKM1K/LwWJ8k5Jj9ZXE4ZcT9C6+A5fFifjMRdgk2Ha9BYREXpX43Akhn0JVShvkZBDlgw== X-Received: by 2002:a5d:5e04:0:b0:37c:c5da:eaf7 with SMTP id ffacd0b85a97d-37cc5daeb42mr3185971f8f.31.1727355490871; Thu, 26 Sep 2024 05:58:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c744:ac00:ef5c:b66d:1075:254a? (p200300cbc744ac00ef5cb66d1075254a.dip0.t-ipconnect.de. [2003:cb:c744:ac00:ef5c:b66d:1075:254a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c1ea2sm6455232f8f.37.2024.09.26.05.58.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 05:58:10 -0700 (PDT) Message-ID: Date: Thu, 26 Sep 2024 14:58:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 1/9] mm/gup: repin_folio_unhugely From: David Hildenbrand To: Jason Gunthorpe Cc: Steven Sistare , linux-mm@kvack.org, Kevin Tian , Nicolin Chen , iommu@lists.linux.dev, Andrew Morton , Matthew Wilcox References: <1726319158-283074-1-git-send-email-steven.sistare@oracle.com> <1726319158-283074-2-git-send-email-steven.sistare@oracle.com> <6aea6530-9f9c-4a9c-9c9c-2c29e8ae9e9d@redhat.com> <98004c8e-f941-480e-b1be-8f6fd925871a@oracle.com> <27f8ff84-76cf-40ee-b391-e226218e5600@redhat.com> <20240926114000.GW9417@nvidia.com> <950cf384-03f4-466a-ac10-61c02dd2dc48@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <950cf384-03f4-466a-ac10-61c02dd2dc48@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7C422C0007 X-Stat-Signature: 394kjcx3y7byyd5abp7q9ipu664e8rsh X-Rspam-User: X-HE-Tag: 1727355496-142224 X-HE-Meta: U2FsdGVkX183Y8NhzWrMU/nK8PU2XOTkNZPy/YZ13VqrgfhQgqaGTD9tklkfDrxSUQsFfDz5CZ1+ZfFAxXiNqWvblGsETbenVBP5C/5yc5iMXcYOIAWmABrvRk2MvXQDjDiEwjeGmciFz9keaKsabgsvNfUP5xt4IKbOOYqkRsOHYNwF/E0Hb/POpDN7K/ZApnUTIVSEqEwnWtsat673GVW9D6lazt0Q9/r6tVgiDQ4dLJlhUlo10Iu4mdlMgXjYARlSqAl0WEkb1ZSgwLOY4MCeHpcoSVzO54uGVBY4nysfnwlkX+8CNgTJl1prBwfYrfxKy7NPcPRNxeybgeIEkViYyBBFgcjPPpOHqCZCz3B37mm+d37fA9tbYpe09BYU2WXbPajF0gr+8L1Qz4+WXQzacLOj0xz8xp1Nx4gz0W5BlM1Wwrp165baKZFt5EfKryiWl4YAzYhdL+wqO+g3IZMIjqnsZR1HOGlSPRxrrJ9NC5EXcOtZPOVKnE9X7A/teKPDOVkQ4NKP0OtN7H7jOb88GhDQatOZZDrJ/nRxJNcR6Cb5DXTxYMQmt8qb4tEswOWd0dlXzcEe0LEpaKta+sa/UrIY5zfXNwW/ApNwhJ49/YYRz+1pBO4dO7WbenqgszDS0z9PtMT+CLermQ1OqR/9AqHVAbL9ZGctsgJG+uZzMibWSOObudvbRASXUYgLXhUXWOzR9Vk5x9hLiw3L9t2i4azhi7oKoFLb0Efm8FqW3RF+hYgGxx4XftxVzkF4OUYb5hTuTMbwg8GK3X9R4pbWICsQas9p7zOId85ZBi6IJDXjEIcpM+/mbdp0TGWCER4UEmuDlnNa66L7qxDNHdHl6QFzP0u+/EOga5/BSP+XF8jFc/pt8Z3vu9lZMnjI95InAMIYwt4b72OrMB663GSJjciAnIvG5OhtmVkIVkGU3nhKM1chXhYawuYf28mev1SGzG0to5l+mDY3ObD f6HJd6G3 jxARCDyliWSSvTsVktrvq+yvqRVBVXUHu00jQJgpOEV6WsJD0mc3m2JPKtmpBjldOWp+5J+goNcp60MfIuOarkVnZ5Zm2SeB8A9LBMJBsXckjVl56cEnPzfdrQWq4c2umVYUVNenGHPLWz7NB2cp3UARFH8mNiAjRQSp5GPY+GXsSeUn+8V++xxolVR4KcpFyURyxnINT9zVGJj1UFuj7OxNb92pCxXlUKJM6QcjyfJ6Nfow9FjtSuU96ijhSapG7Wq+1VqDATQ8Sd7wK7CYig5sFVGhB9p2r5Vc1FTornwhBh8FRQOyzUbpBYY21eBmNBhnn4wCxYkKCV5FrRHy2Fiy65/E5FL0BoWsO0owFpkwTrwZfTXhX5KEHHUOOtd5IDBhJKvmhVMQNsJPN3dYLIhY3e92fiwbcKmkQvKHJsSrr8RDtBP7jt/oYwDOrTTSJfDTA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.09.24 14:57, David Hildenbrand wrote: > On 26.09.24 13:40, Jason Gunthorpe wrote: >> On Thu, Sep 26, 2024 at 01:32:09PM +0200, David Hildenbrand wrote: >>> On 20.09.24 15:28, Jason Gunthorpe wrote: >>>> On Thu, Sep 19, 2024 at 10:11:38AM +0200, David Hildenbrand wrote: >>>> >>>>>>> And repin is really misleading. We are simply adding more pins to an already pinned one ... >>>>>> >>>>>> Jason suggests a better name in the other thread. >>>>> >>>>> I would prefer something that simply adds more pins to an already pinned >>>>> folio. Much easier to get. >>>> >>>> Yes, but also nobody should ever want to do that operation, it should >>>> always be part of some kind of "splitting" sort of behavior.. >>> >>> I remember patches from Dave Howells that needed that for O_DIRECT handling. >>> Never say never ;) >> >> Wouldn't O_DIRECT be the same splitting thing? > > No, I recall the implementation had to duplicate pins, not split. > >> >>> Adding is much more intuitive than splitting ... just like we add references >>> when splitting a THP, using folio_ref_add(). >> >> Well, sure, it just seems harder to document so people can use it >> properly. > > As soon as we have large GUP s/GUP/PUD/ -- Cheers, David / dhildenb