From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4F8C4828E for ; Fri, 2 Feb 2024 20:18:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D7386B0093; Fri, 2 Feb 2024 15:18:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 460686B0095; Fri, 2 Feb 2024 15:18:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301156B0096; Fri, 2 Feb 2024 15:18:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1A24F6B0093 for ; Fri, 2 Feb 2024 15:18:38 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DE5B71A1042 for ; Fri, 2 Feb 2024 20:18:37 +0000 (UTC) X-FDA: 81747976674.03.EDD31EB Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf11.hostedemail.com (Postfix) with ESMTP id 3B6B44000C for ; Fri, 2 Feb 2024 20:18:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=j0YbsdI3; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf11.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706905116; a=rsa-sha256; cv=none; b=PA2td7NfHDe5jinbD80/QR3WhO1WtoY5XKcOOI3RSW0JumLQ58lQ7+lnzftFyf42hmWRaf jowkdx46ufQu5NosCJms3aF7CYId3GRT7HHmxH9gr8efkPqSpPw91dOfFc5xGgbASath/m UIdFp/H7+YSO29lR5aCZjs7jxeiQ/34= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=j0YbsdI3; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf11.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706905116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bTXDsW3IFUJVSvY1B3qhrjUsunVwK606KwTa6iN8qgg=; b=ASYWW6OrXp2JL7isDku30wCSrWeuRNNSmA3U1F1E+jG0qI9NUHY9Np/616f4YhvJ3szsRU cZ9adJVPXG8B3AmF3kAjUYCIpSy1zK8/b97H+jBng/+uxHX+TyR9QCLQwKIFD1V+3gLkpA cebcuChRJxw3jwZTD+azuJH/JmiGnhY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706905115; bh=mh+mo38fsEQgb9l3Kuwv1eN4wevPn1ndoe/G9f1R3Wg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=j0YbsdI3y6vCPgWvcLlBfSENnF1fM18wQKlrQ47Z6vS/Lu+5uXdTUXoJtf3p1E10p 20YTd4Yysds9Fc8+0b6V+OsfbT17mhbkv37sH0RogmtvLcyJvkNXvcbLGe74TWbrhS HUx5JRvOie7xZ1Qqhc3oXMoE8WJJLhi/VkVjuI8CQ7qNhPK+No8OaIzt+DQfEKdgYt woV0Cd/riDC8CadDDjBDCpwxlRatUyiNLEwFXzLL03k+hlFBnEBK1c1gytA7iBfe3e AMPZTBIMrqrQGCYQEWxcSx259uC6FjHPECXXrtL/pbBU/8IJthIyCDSvplBrQc2OEO hD2B6tCO0gM5A== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TRRtM1f6yzXBq; Fri, 2 Feb 2024 15:18:35 -0500 (EST) Message-ID: Date: Fri, 2 Feb 2024 15:18:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 2/4] dax: Check for data cache aliasing at runtime Content-Language: en-US To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@lists.linux.dev References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> <20240131162533.247710-3-mathieu.desnoyers@efficios.com> <65bab567665f3_37ad2943c@dwillia2-xfh.jf.intel.com.notmuch> <0a38176b-c453-4be0-be83-f3e1bb897973@efficios.com> <65bac71a9659b_37ad29428@dwillia2-xfh.jf.intel.com.notmuch> <65bd284165177_2d43c29443@dwillia2-mobl3.amr.corp.intel.com.notmuch> <6bdf6085-101d-47ef-86f4-87936622345a@efficios.com> <65bd457460fb1_719322942@dwillia2-mobl3.amr.corp.intel.com.notmuch> <5e838147-524c-40e5-b106-e388bf4e549b@efficios.com> <65bd4d18cab98_7193229421@dwillia2-mobl3.amr.corp.intel.com.notmuch> From: Mathieu Desnoyers In-Reply-To: <65bd4d18cab98_7193229421@dwillia2-mobl3.amr.corp.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3B6B44000C X-Stat-Signature: seec3k4k91mqdsz49oaq6q6c4yng3ftr X-HE-Tag: 1706905116-756533 X-HE-Meta: U2FsdGVkX18Ki9FT/Pft0A3epU87rnr9Bw7JwQ0Q875cRzLPdD/ArrEv7+0dPCURGRYX3RoIMjkCw/2T7QyIXSXA6/yOp9sjd1Bg0wGu9vEBQFxvnb4Pm+oBnnfLcUiRqJeEyXXu1KjGWvrw+37EMjMSgRVV5EI1q41k2bV5ciXxhwlLhPwtCekdnvv1sH2NhFJ3SGlLYLS24IYY271LSNk4SZLxvE+ogWTzQ6hN5f0iR0xV/10N4ANB+C5XB9sYLEULkv3/Bm7qEmzcu511hsA+GguyppiNy2c3QC0tgMIJlHcsxU1+ypvOWB9GteygakfI5rCi18d/nSJZPMZl6KXM/Zbv22MdCdvkvaub6loUnkKrDmOsTIsBeZn9KC5ny/b5vPJAFjt718JH1JURn6/JRQe0vDFt6PFuBhaMsC6QkelHuhUlZvwbn90VW3fwhPAAPDbvFSGTB4xpd67PvIRBqpPPCOCmc7xBdDpW/XleWM0/ZjASvuBMKahjyo77qAtjM0EfADmTmTl5z4Er8R0gkJlhi28D8+pytm+ziN8Q5rbnmEQPfkhncsOAbymA3niuON/Icunt3i+wJbELzkF/yOHM06KH9pjnhoKidfgSoYoQ6ctBXWew2nJaIbSYOKdVsMeD1vPFoBMtOSnKx2+APJzJnXf/WejHagGevN5t/7CkncXErD3dloFuQOU7n4xPLJJFXtRn/moRXxR4BHSU4Oi4pA+X+/6Xz4yrahHCsm59ouzahpj0tfoVM8IK1dx6Sx+7RwwJNIJhmE8dx5FcIk/ry2EekVkxuFORV+ozvJJLf2sAJrqq+6WukxE8ITjNSv5gbzjRcM2AqhiECCcI5T/G2Nxybd6d7OwORp9Vetr8GaZoAMb9R7WSHe9w/D6ZBoEbMo2WznVteVw3DQmdUu3I5rd99pppEiMF3VvGMC9VpehHj+uRz/FzPyjTlJUqfecV/AxCEokOZLc Rbj6yEHJ KlhPE7IIDi9nWAIGqSgjniGHzqqusBwUrvMjkT6y1jyPRUI5mtWZdlLUr5O+CFLCoK3Ttel1sH3caXut0VXvUxc+YK1tbRzzF7IeJg1mnqC2FcA6dXqbCtOrSmGL1hB93Ds0Yc8rAIyRleLZrOffhi+I5ChoaY/mtFxBtVINAvYbyioXX0wC8t9X19OZXeqrrM7Jz4cXXvKa6Wq+rOkiM+tFGJ3/kEqIo78P4/b81AT/r3E5RhHil1kEh1siVKoOcudFr1xOFor4ULO9xPb7tltjcaWbcij8yHDdd5laXS/yhzU5F8sbdI432ovSfjSVcTly7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-02 15:14, Dan Williams wrote: > Mathieu Desnoyers wrote: > [..] >>> Thanks for that. All of those need to be done before the fs goes live >>> later in virtio_device_ready(), but before that point nothing should be >>> calling into virtio_fs_dax_ops, so as far as I can see it is safe to >>> change the order. >> >> Sounds good, I'll do that. >> >> I will soon be ready to send out a RFC v4, which is still only >> compiled-tested. Do you happen to have some kind of test suite >> you can use to automate some of the runtime testing ? > > There is a test suite for the pmem, dm, and dax changes > (https://github.com/pmem/ndctl?tab=readme-ov-file#unit-tests), but not > automated unfortunately. The NVDIMM maintainer team will run that before > pushing patches out to the fixes branch if you just want to lean on > that. For the rest I think we will need to depend on tested-by's from > s390 + virtio_fs folks, and / or sufficient soak time in linux-next. I suspect this will be necessary. There are just so many combinations of architectures, drivers and filesystems involved here that I don't think it is realistic to try to do all this testing manually on my own. I prefer to voice this up front, so there are no misplaced expectations about testing. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com