From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1BBFC00140 for ; Wed, 10 Aug 2022 08:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8850A8E0002; Wed, 10 Aug 2022 04:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 836E68E0001; Wed, 10 Aug 2022 04:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D59A8E0002; Wed, 10 Aug 2022 04:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B7968E0001 for ; Wed, 10 Aug 2022 04:32:37 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0E46AABB15 for ; Wed, 10 Aug 2022 08:32:37 +0000 (UTC) X-FDA: 79783016754.29.7B204A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 874E6180043 for ; Wed, 10 Aug 2022 08:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660120355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGNRL7RXjtq0mKAACNMvTHAR+zCxpXxi84pe8w824HU=; b=d5G7a1l+NoVF64QSjCiYmq1V+Azc0q8P/URaWvgA6Dpgwm7w/0+K8RZVLBLh4UAMznC5hz vAhgsY/7n/ZndB3QZztYAcqZaN9kZmnUKHzOtqdlVJjgrvvkM4J3L1gj25z8+RfmWxoaNL dcd39MNJVlmqq30lHvniF1b8ZJ+Bbkw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-468-mlOpvJkBO6aAfNhtcLFO6g-1; Wed, 10 Aug 2022 04:32:29 -0400 X-MC-Unique: mlOpvJkBO6aAfNhtcLFO6g-1 Received: by mail-wm1-f72.google.com with SMTP id c17-20020a7bc011000000b003a2bfaf8d3dso7122855wmb.0 for ; Wed, 10 Aug 2022 01:32:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=XGNRL7RXjtq0mKAACNMvTHAR+zCxpXxi84pe8w824HU=; b=AHq9ZM4VC67FTczQJtTumK2naHzihUoVNHVhjT5FiRhc7xdch10UtGo3ogHuQgFvbE z1Bf8vRy1KljCqCIPof83zXh/vgMEVGGQc9t1HD7kf+WAUuHpmG/H9hB79eeaWOSCjlR vcFy6QTv6JQX+RqYm8tMz0Daja6eLINIAK2seYMR8eWCSkSA3ocLHXOOss3Nyat4k/Gb 9tKPwHFiuscFRyVhOy8wrhq5YP/bLeF6014GcttOdQevAtA8x8j5gnE0ZJ29MNPBHgb2 7/RyPlSZ+xEpKDzBQhVcQRRudWEV2U0jNZ7cihEy4mrn9fn3nbGPhQ5cgnN+rZONDtsl U/RA== X-Gm-Message-State: ACgBeo0fNKYXdXiiXSGvxR7ZSCbavKi9GQrBeuQwO8d307Nl/mQ16LJu LQsZqVa77rVCqu8ml/1mBlgYTOFpLHjdr3VH+Pg0qQUJyi/QKC/eoax7L38ge1U74Lcn6B+mwTL 6ZvFfXt53Fd4= X-Received: by 2002:a05:600c:4e03:b0:3a5:1755:8498 with SMTP id b3-20020a05600c4e0300b003a517558498mr1619499wmq.137.1660120348486; Wed, 10 Aug 2022 01:32:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR5qxjbgUdwuQgliLtypD01fweSDVzMfPiufIkKAYAH4GBeQyjU+/MsIMI+BYxf4zmWEP/Y+2w== X-Received: by 2002:a05:600c:4e03:b0:3a5:1755:8498 with SMTP id b3-20020a05600c4e0300b003a517558498mr1619476wmq.137.1660120348253; Wed, 10 Aug 2022 01:32:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:1600:a3ce:b459:ef57:7b93? (p200300cbc7071600a3ceb459ef577b93.dip0.t-ipconnect.de. [2003:cb:c707:1600:a3ce:b459:ef57:7b93]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c358d00b003a4c6e67f01sm1552735wmq.6.2022.08.10.01.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 01:32:27 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 10:32:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] mm: add warning if __vm_enough_memory fails To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Yongqiang Liu References: <20220726145428.8030-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220726145428.8030-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d5G7a1l+; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660120356; a=rsa-sha256; cv=none; b=qyxp3a69uV/jOu4xL/j/WAWonT0pdTfr8i1Z50xcq1WD3d46781X6ANZVO9izzTIVFVYzY Em3b3iTMECUDeMz9TlFOScOi4S1DtibjOfvBmcB12OFIIcPJqXX6L6I++/g/cFYTIR5LIz TWHdcq4+BLbbaojD6jkUgKv2jP/OUyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660120356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGNRL7RXjtq0mKAACNMvTHAR+zCxpXxi84pe8w824HU=; b=kIyAw0jAbyzboZ915bNSE6/xf7XDSGtLDBWPMR4NO8gCJk2KeDULge9i9P8dgqaaht+PMm ucsfJLeEVfUeXtNydy/zujR1sAxBD7/0EhEwKUeSb6AKkDKnUWO2iTBgrzElXwJlFAMMhx 9baydOIUgrIZKDH1z5eIq6KV44z8DLQ= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 874E6180043 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d5G7a1l+; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: h9hpe4pniu4adx5zdwg3149ncsuhcpxe X-HE-Tag: 1660120356-635995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.07.22 16:54, Kefeng Wang wrote: > If a process has no enough memory to allocate a new virtual mapping, we > may meet kinds of error, eg, fork cannot allocate memory, SIGBUS error > in shmem, but it is difficult to confirm them, let's add some debug > information to easy to check this scenario if __vm_enough_memory fails. > > Reported-by: Yongqiang Liu > Signed-off-by: Kefeng Wang > --- > v2: use pr_warn_ratelimited, suggested by David Hildenbrand > > mm/util.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/util.c b/mm/util.c > index 1266a33a49ea..c786e21c6051 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -1020,6 +1020,8 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > if (percpu_counter_read_positive(&vm_committed_as) < allowed) > return 0; > error: > + pr_warn_ratelimited("%s: pid: %d, comm: %s, no enough memory for the allocation\n", > + __func__, current->pid, current->comm); > vm_unacct_memory(pages); > > return -ENOMEM; Acked-by: David Hildenbrand -- Thanks, David / dhildenb