From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0D4C28B2E for ; Tue, 11 Mar 2025 04:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 812A2280003; Tue, 11 Mar 2025 00:53:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C216280001; Tue, 11 Mar 2025 00:53:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B21C280003; Tue, 11 Mar 2025 00:53:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D970280001 for ; Tue, 11 Mar 2025 00:53:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1CABC16191C for ; Tue, 11 Mar 2025 04:53:43 +0000 (UTC) X-FDA: 83208052326.05.93841D0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 5235A4000B for ; Tue, 11 Mar 2025 04:53:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741668821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jD40IFZoW0/8yNIos9NzKvJHYIHKhT6oaGh3aM02u58=; b=BqVU29TakgmDQ9DAzHaRunSwM1Wf1yuwahlKTRunkKA27oXD5K0DeA4etfI7RzLwi8JfwM pBJJr0nmr0FCe7yDkXP0LPTV57s+ag0nXgzwpAoJaLtl0Q++RSGj+01TpnsnmXsqs0/tZ+ w91BktQPwW9fFisbUpMedtOKMAp8cfc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741668821; a=rsa-sha256; cv=none; b=EeO1wolVJAPvDS4iNxxhG7Q/2mAHhZeemGpQcZ3YF5KHFwBlpTk7GreVLAobT/nFVqo9YO vXwd/JInx8UZsVugyrtz1CEjcHWyrcO2q9iL8AzTe7mUpAZAtRHs254lKTelpFKdKVXdCM FtMwMQFbC8dKJyJMn/fG0p7dZzs01pg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F5861516; Mon, 10 Mar 2025 21:53:51 -0700 (PDT) Received: from [10.174.36.193] (unknown [10.174.36.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C0813F694; Mon, 10 Mar 2025 21:53:37 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 10:23:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling To: Cyan Yang , akpm@linux-foundation.org, shuah@kernel.org, david@redhat.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311023730.56658-1-cyan.yang@sifive.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250311023730.56658-1-cyan.yang@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5235A4000B X-Rspamd-Server: rspam03 X-Stat-Signature: t73h4fj3zaptrqrqpi1xcju8yh4y91sy X-HE-Tag: 1741668821-210490 X-HE-Meta: U2FsdGVkX1/1k13zcsaopYNDIQaX+Ue5FqrImXQ2DhXl1ic4CPCKH+7Vwye9y0RmgFsGFfXWRSmkF6o1ZC+JFD8Jb+4hciiCpLp/1XFG7Kay3HqRckJIauOcng4fc5Yp9ZKc15RPq60jDRQ6ta1KLafbKFect6Z7QQYbnMvxS+gIMmpNZtVCob0GwACWkLjclrHlPteBpwep1qj0KlJkdqGg4E7p+fgnEoMeLbZnzBoJj5QVoPFFutbzn/D7wwZh750vJN+s51D7pNQXHP6XlLVqXjiW2D9hATT0xQf+36eOY7LZB2ioGI5hw0RvY+DrkKa0te6BUzUH+v/x/FI/iYCkdguQxa6hzjFeGfXuoyzkUpEXtp9J2u1YxQJq52i7FudXbYomwkSsg6GO5l0i1gCcnphsq7CP2VLb2ty3g6LdRjhCLnH9f9V1lcHRAV9p2gTIb1c/aaURVDvVELRbj3FjjpedXUKm0jeFQD7bS11c38WaeH4a3jIYSgRx69l6ajAilCeni0YBdB9gq5eRtUWbv5LGBdQmSiuz9eoOCbEdP+9x+UpfIwzZh+N/U+nif91+NxAMoDa77JwzkLUl2fCwoZUWpNdAGWfRdUDlf2KtmGcO+cNi4K0cEQfQb1WMZl3tr8jpqkN+8ci0WkuVeQxNMXgydMq6BQfv3DlNbzDFErQlL6WLx3sEDYahS2258KZMmZTf8aBJRyKNj8vNrD3jBHoUO3Uy1Q8UO47gT4Hai1IR5J4pfDRboT/+cMGJq5uQLJ2sqG0FvdpET/12dnTM9iIQHZGWqhQjAFDCKCcpGM3r5IRVJvDQ/diJ0VES6yw9wvVEy34+xuaAT+USFmVasLMMb9lcyr+WjtCjLnlKOBn5YC3WPHQAf6x7qQ7FKMxwSABuFHvncb5pSHgnEG/ygV/X5ArXVJSWQpTkgpNaqQAS90Hmf33TO8V9Ct9AOONQ6yeUU4qSCgbaLYM csWjVFpM SKR3XTZxFT1fZbI87YhxA6dYvbhi4IVsfmG20zsYDyzKuIKwG19BvemYK4SZE1kis8VareXFfBytoPSb2D0Cgge18yyU90fuD/T63HBUH5Xcsn+LTdU8j9AyweJT9JYEYnO9jWi3knC/EiWEVfuRvaYJ4xXdrPMGPCI2fqZ09Fdj139awjHwsNA/jWA6WepLIOKebbrHvtHq+CaA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/03/25 8:07 am, Cyan Yang wrote: > There are two error handlings did not check the correct return value. > This patch will fix them. > > Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") > Signed-off-by: Cyan Yang > --- > tools/testing/selftests/mm/cow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index 9446673645eb..16fcadc090a4 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) > mremap_size = thpsize / 2; > mremap_mem = mmap(NULL, mremap_size, PROT_NONE, > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > - if (mem == MAP_FAILED) { > + if (mremap_mem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } > tmp = mremap(mem + mremap_size, mremap_size, mremap_size, > MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); > - if (tmp != mremap_mem) { This is fine. We are checking whether we were able to mremap tmp to mremap_mem. > + if (tmp == MAP_FAILED) { > ksft_test_result_fail("mremap() failed\n"); > goto munmap; > }