From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24E5C04FFE for ; Fri, 17 May 2024 03:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237246B0085; Thu, 16 May 2024 23:47:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E9776B0088; Thu, 16 May 2024 23:47:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0884B6B0089; Thu, 16 May 2024 23:47:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E23B96B0085 for ; Thu, 16 May 2024 23:47:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 665E41C3E8B for ; Fri, 17 May 2024 03:47:10 +0000 (UTC) X-FDA: 82126502220.15.4317E7B Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf30.hostedemail.com (Postfix) with ESMTP id 6F4F48000E for ; Fri, 17 May 2024 03:47:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=CNYHCYZz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf30.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715917628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yDlOiioY4qBdeDaBJ3EMBjG9W4k3e+q2KQuwlwFm/Wg=; b=p8khGrUYoYvenX6mkTRvFkxzDzcqXduO5wmif9VvxYMe/ooOSjF3/987duaLw2fY+OmGAm e0mnEBztR6xXGgkAZ/zA0MGkfFz+IPyCdwIXs3Wlro7Ms5xk4KTeDZQKkY4sMwtfQSXYLe a2JRKJY4Yux6Qr7UWmOvSYNJIFc+3T4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=CNYHCYZz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf30.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715917628; a=rsa-sha256; cv=none; b=JEVY2P/4pyOjXRnru6UE4LwuEqxGoPpPrEjsxgVfOPIrt4rrJhfCnbD1thFMqUtuKuR7dk aPL5bcRi4gY1XIvSShTW+7ePbOQzUe6BAZwbGf/S2nixRw4thp2NymO2gqCnQlnjMVWEcq o/qR+tnrxgstHu7PsdidYXrmmiW1TPc= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7d9ef422859so802039f.0 for ; Thu, 16 May 2024 20:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715917627; x=1716522427; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yDlOiioY4qBdeDaBJ3EMBjG9W4k3e+q2KQuwlwFm/Wg=; b=CNYHCYZzgetF3Mo3NEMShAkN/1Qbrl3XDvFHjEo821h5xJlULbZIfZzkwmdsAnSNOG JqfzUF526SaSrdgO/NdOTzV2CpadcOqfsU2hlxJWxhH+q+rlX/3eWQve0r0gxAIUhRt9 nX75MQSEm52e+65MVCms+Qu2XxM+MjtcTvWdU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715917627; x=1716522427; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yDlOiioY4qBdeDaBJ3EMBjG9W4k3e+q2KQuwlwFm/Wg=; b=KsfHXBo8TZbNGytZeSYKVuPw+yAnDu8SpCsAHieFu+3uFSQkHr5rHMsD0iLHDEWNbm P36ocF6yBW5ctYwwuH3UmrQmfIJQy2LFeuj7VbxJfkS5wrGq/r32OM1BIBwYlFZYPV12 zm4gel3qrB3jAtYRWF4ao6nPJEQzwYZtI8jFhKLglqHnLPYfLICNdwu4D2E299CEpvm7 uPhDKRxzqmn14oXVnLVpEzJE11SQKvKzsPO7JJLDNdLE2BKYfwptIbL2of2TDbC1afgr ihKTMfwxllhtPew+Te4JAnxgEiv+mB96du4Cdwg+tYpCJUjD/NxjMnXQjJn6Eb4Z907f QCxw== X-Forwarded-Encrypted: i=1; AJvYcCXbQDAo5c5oDP7Wu58ny3roH8s9HvOhdHO9aAHiTBpVFZfBUhXZJTY34PBFBOVllPxbaMmwSRJg4UUObtHo0xAka+A= X-Gm-Message-State: AOJu0Ywdv5bmzZuToGy0JX1HfdAR03ykGiDq7VlfHBudn+VBMvofjADx 2Tr0hZwLtyehmqqH7KtUhEBQD+TVK2jOu8ysOogmXq7SXgqXFCPhV9zk08+ml1E= X-Google-Smtp-Source: AGHT+IGdK6rFNtMzv/o7w6HNu0tCiqSEnlqZgL7f/KrvB7GNWi1KNGokcDBCge/J7xruX5muwQNDjQ== X-Received: by 2002:a5e:c748:0:b0:7e1:d865:e700 with SMTP id ca18e2360f4ac-7e1d865e82emr1709781039f.2.1715917627289; Thu, 16 May 2024 20:47:07 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-489376de473sm4436301173.154.2024.05.16.20.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 20:47:06 -0700 (PDT) Message-ID: Date: Thu, 16 May 2024 21:47:05 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6F4F48000E X-Stat-Signature: pha9g4nyigoy1fo6dywpaa1umffwa5j9 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715917628-839445 X-HE-Meta: U2FsdGVkX1+WSE8gVlYOzRbXPiDNIQjCbh6yl86hb0xvwoqVgGG6WcXkuYP8SDVDYRTFS0TG+DfRb79DlRGscwEoUjFhMrya9lwCJuD0OkzlbAhxM8MjIMyvibDyAdGXW9AB44EmHQn4+hGFkR8BroNofARbb6wVAmkWpkWpv3LKzP1UjwrAf2HMefcVBVjdFMlrtenkcl2+eWFdA9o1OC0IhDdquigp3r71ISk/DLx42b9aGnANub1HjCtgOmcCWdze2FUEWEAXHo62fMRWp9kNSfUHPYkLR/TP/iomiaZySJa9z1pTgPOjtChVPOBxgmZ3HjK+evnvGxfecm6Hx/Dx94o6NFOlQEarmgj4LYB3J5Arub8r6oyScWJQOiGvBvgC7XhFhDAEpsBPl4qkSxD7mzLRFLJ6qCn1C/jR4ispv4e3mLRStyQGWNXEE/M/4ujcGdQlwO0zrnfiMh2ntU7XtnyRDJfSgHqmTC8ORlVGTr3jIJWwrlf+W8rSCKa2mOrD17mT+283v2ufqPX4VHv5EOaxFXphZD88QAXr4yZnIqeMxiW//5XC8iA2x/8HPefyTKaoCvMWOLcwuX/9LK4IEGGOG+pbnVT306Qf3wZHPOMV9DbdrjeIPRH+DpN9/9MA7BttcFdOYY9Ul8AH3zf6eF4VIO4ebCMsFESwL2bMypt+CrNwio1ucKMcUktX9ZItSGMzdS8+TQJzfVioOhlVJM5qAgRxt3eTEjASq1Tq+JB0C3dBx4vghQMkJDJou9AMN4fN4YtVOAP0Vo5ThvgSeyZun/7wEYKzUl76xN3qelsdUT+yOj5LRVRe+wSVyfKPgoD0x9g0AzQiY8JDPhC9dK5ZKDiNlNc0OpmPHJEpv3DhLkFcDW77sjgRpPcKlVixVLfFYes3l0zCANuFGMoie1x0/YTchkextj1S1vqB1IpajZnoAIkB1oOmC2B+qHaNVD5ykReqHSwLi8Q jyRx9MTJ PULZCJmpAAXQ2H2+6+vVbNsHghB3RYKMz+KLZZnQyvR4xZw2srUoyAB8SK5BREwLbSwHlRmKU+L5dOFqYrl3VHo2AjJTl7gupzmZD9Durj3LRLNwCDJduwrg0SJkw31KG7TZeE9Y57EHFbfTAoB53lcAyhuOZ8LYXBGXuwjp3BC45DEroK6+Dw805ODEw6j8eNV6k7H6Cy1gtzl46mSG+FLbKQFARVsZQs89A+/Jl6HtHXF0V6eRnWud3kw/KCMkcGRqCFN4KrsWrPq+lMQdZpqevQ08cdEFDYWGDa94YunB2QgNuxR9JWfrhaqm2jDNlSjsRNGyPxPVBkSRqwZxGn94TmY3fnnMsQRRXhS0xLTMr2oepI7KyGNU7b0PXRQvsCjwSYh77qzdaQpd5JkLGfsOjHexrYvh1pquNB7xcoZ5yjZzpOvjQ56YZqbH/Im7smVc1hUtDWAVlGDCraVUHNnhiGbi5YgTm16nDNklUQsK8LIckw5Y6C7eZpAjnmWoIqlmJSSEMBQ7fW2upAwxgpsNu/BIYEUtH/Kc4a8lduJRxHT5vy8ZMOBkUUu1K59HIocZKCa+OnbrFXhw1BGVGDC4y89YC3t6SIpigLibR2Xx7RPNl7hsYxwKcJ3z8NI3WzLlhgSRYkImdbaY68IfJeX0kvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/24 12:05, Shuah Khan wrote: > On 5/16/24 11:45, Tejun Heo wrote: >> Hello, >> >> On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: >>> I am exploring options and leaning towards reverting the patch >>> >>> daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") >>> >>> Your amending the PR helps me if I have to send revert. I am sorry >>> for the trouble. >>> >>> I can all of them together in a second update or after the merge window >>> closes. >> >> The cgroup commit is already pulled in unfortunately. Can you please handle >> the revert and whatever's necessary to fix up the situation? I'll ask you >> what to do with selftest patches from now on. >> > > Thanks for the update. Yes I am working on fixing the situation and > will send revert for cgroup test patch as well if necessary. > > No worries. It is not a problem for you to handle cgroup test patches > in general. I will need your review anyway and letting you handle them > reduces the overhead. > > This kind of framework change causes needs to be coordinated. > I should have held back on the framework change on my part. > As mentioned in the other thread https://lore.kernel.org/linux-kselftest/24975952-b1fa-44a5-bac5-aef538ad0c09@linuxfoundation.org/T/#t I reverted the following patch and the framework change patch. https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next Will send PR to Linus this weekend. "selftests/cgroup: Drop define _GNU_SOURCE" commit c1457d9aad5ee2feafcf85aa9a58ab50500159d2 thanks, -- Shuah