From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51389C3DA49 for ; Thu, 25 Jul 2024 16:40:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7DE86B0089; Thu, 25 Jul 2024 12:40:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2BF66B008C; Thu, 25 Jul 2024 12:40:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1B5D6B0092; Thu, 25 Jul 2024 12:40:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A41FD6B0089 for ; Thu, 25 Jul 2024 12:40:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6108741262 for ; Thu, 25 Jul 2024 16:40:31 +0000 (UTC) X-FDA: 82378838262.17.AB5B9C6 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf07.hostedemail.com (Postfix) with ESMTP id 8390F4001C for ; Thu, 25 Jul 2024 16:40:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721925604; a=rsa-sha256; cv=none; b=Ih76jWOcN23Rs9kufIFdaLVpeL+3s6ylVXwMxpCpFls67OiAm5r2SUG3V91sybqbBqM2DX SBIGvMeAE3k9y+PL0Dfuzpb2Do41dBneh+kACZDm4qVRJJvDd7M9+QHPsmXitlPR0y7yIB 1qrjOuHlkat6TGZHTkqvoPA45cuEDX4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721925604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eEPYbEDWTqFFWXTfdpFFT5ue+bz5AmcgOSVcRU43fiY=; b=tO4bd1SODo0pwnlleU4ImJfW/+z+uMu2ySquvgJqElMiaXaA/hvgQjOkj3idyFTyP7FvAG 3N4gym+0HbCPgp60R2CRErBthgTzArFd4TSBHXhDCRDOaA84uqCtHPz5exE0mwxO0NzWKB UUmS2H04DZFUbIK6eyYhQD9A/skZMSM= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-203-6SZKwZkdNQGPE2agbHEO1Q-1; Thu, 25 Jul 2024 17:40:24 +0100 X-MC-Unique: 6SZKwZkdNQGPE2agbHEO1Q-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 25 Jul 2024 17:39:44 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 25 Jul 2024 17:39:44 +0100 From: David Laight To: 'kernel test robot' , "'linux-kernel@vger.kernel.org'" , 'Linus Torvalds' CC: "llvm@lists.linux.dev" , "oe-kbuild-all@lists.linux.dev" , "'Matthew Wilcox (Oracle)'" , 'Christoph Hellwig' , 'Andrew Morton' , "Linux Memory Management List" , 'Andy Shevchenko' , 'Dan Carpenter' , 'Arnd Bergmann' , "'Jason@zx2c4.com'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' Subject: RE: [PATCH 4/7] minmax: Simplify signedness check Thread-Topic: [PATCH 4/7] minmax: Simplify signedness check Thread-Index: Adrd1i0k/JcX2h1sSAO9D37F5HIFAAAt19eAAAiWjHA= Date: Thu, 25 Jul 2024 16:39:44 +0000 Message-ID: References: <03601661326c4efba4e618ead15fa0e2@AcuMS.aculab.com> <202407252100.fDFchC5O-lkp@intel.com> In-Reply-To: <202407252100.fDFchC5O-lkp@intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: u9xi6n5nbsm3yth3b38uptbyf5pi651e X-Rspamd-Queue-Id: 8390F4001C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721925627-504664 X-HE-Meta: U2FsdGVkX190J2BMzhS6HOvFMJQC8eJkXKdL8NYKupyE4hzKYI/TxqRwBDhUmIuZmcCr8LkKiGoywYs5sDIjUSmPCb3I8Q+u40mT62E0UozggQFqDHtXpby7n5iIQlPO7Mne9RQA13scEmsV//3ACv5djUpdCHXf2qwKmbRFa8Ml6DI5sIpeKLXmjD+2jOo+WxX7UIGyT98Og8mLNRnP1l1GfHpB/QKcOBKLLsdb1sgecElblrDGSr+FYpB6df/jwoo+zuh/uBI/AMJSUS032tWWZvmqVMjEn4Z0Q5K2+1XJV5oOJdXz785q2Qo5rORociI5sC0HYQ05mP1assRBzSHQb1ojDTT+gtMTNNap3l9YXY2Clxx9iDS/LPsWgZ8vqG36hipf7yatjVyws58p9geXIaZMndU4QVOLAvvFSB07p8qRn0x3VC7M1Mu8MbHbUKncG+iOk3z4JGrlHQRThfurPh34SRzMpQgXqQMECrQ6tT7DxYH7Rqwf+aRwiK54WWGgi4/Ww7wHzy5AncuoXz3tLDSeQN0r6wjViM+adss8bi5hOJBh3l/ba/DCWXqsdgSovX8y3Mu93uUf23jtLRLj78wNmrR0RI7qzCWTDkUigM0s8jxpvCXGiSnW1Dl/UYGMJ7fij7BaG4WidwDXGEj7uZbNe37JsGnnUraDBsf4t7gVRORNoTFqhBryGnK1cxk1/trSIF/Qz4Ct8tg3UafR1rSMz+ZrFKWdA0VEUNMHcgwu1c/05I8jAIRyjRukfwhLM4dbaz0S7h4uRQ/FV7lJlS8kt0pWKXi37v7cs4EcDQQpvGc+RjwMzTCWXcu0HktvKSmYqVx45CTPccd4pYQoxuf6C1ZIFp5WHJj2agi2aY8LGETS3uKox778B/Nd1zFjKa7Xr3VbMfyBMrAOUoF1/U56wDPUKEDmUuxhsF/KNvhXyLQ1pIbZ9XRtqj9cWixE/EE6YXEFjDNWWjX Q7cJL9l1 D6GUA0G5D+D2qOksBOQ+PBwI16ADgez+Gv2L093SgUwpnGXXsEfkwl3CBLQ4Oy+7fPQXeGUOEM1plg3yIeEKBAZIQfEHR/OZPAvdKSE+8p4MXAd36b/Scyl0S9WPmzwwAKsLSerOASEdIOdGvuXYlrfA504YC4JKTlvVCDgxm/5/N65PQ8PFK65SKHXZ/SIGZzkH5G7aKfIqc2p8RNN5hNsJ3cSje6D9A8e++gIRDOnKi4okWCGuuQ+GOzMS5zpDZ8XaEcZwlI9ZQwRb5jLixiNr2vpf58QqgsBEAZMlWgv1ph+dj52fx4hIdMvr28a0cEArDelDvznFDe6o+1wRFZpGjQXZnOx3Z+t86C09itQbzhOmjBXrT+88S6QEOnfvnvDyffGiqGdXoq3SSslcgAg+Cj6W73ZtXctkL10yurOawqFpEqI1QHmsZt/rmm/mYwRWeVbJ5FQkGJfdQMpQk4VG/+QgxUxzrNI5NCP80nhTjGPiEpb5PHk/jJ8wobzOeVxnVEaCTt9i12aCypzmE4547jmzo/YThnugPzEYY3UP508i04LfKgWE/8e+EVBL3RwfqRxuybhkH17BiZMwxRSRCYwSGUkgZ7BwoOqIIbB0CogrHVMHWPzFgnVFC3LYh0fFhr8rqKG5YoQ1plsNer71SkyMASEoLnz93 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: kernel test robot > Sent: 25 July 2024 14:24 >=20 > Hi David, >=20 > kernel test robot noticed the following build errors: >=20 > [auto build test ERROR on linux/master] > [also build test ERROR on linus/master v6.10 next-20240725] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] >=20 > url: https://github.com/intel-lab-lkp/linux/commits/David-Laight/minma= x-Put-all-the-clamp- > definitions-together/20240724-224832 > base: linux/master > patch link: https://lore.kernel.org/r/03601661326c4efba4e618ead15fa0e2= %40AcuMS.aculab.com > patch subject: [PATCH 4/7] minmax: Simplify signedness check > config: mips-loongson1b_defconfig (https://download.01.org/0day- > ci/archive/20240725/202407252100.fDFchC5O-lkp@intel.com/config) > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project > 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) > reproduce (this is a W=3D1 build): (https://download.01.org/0day- > ci/archive/20240725/202407252100.fDFchC5O-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202407252100.fDFchC5O-lkp= @intel.com/ >=20 > All errors (new ones prefixed by >>): ... > b286d8b1a690667 Herbert Xu 2016-11-22 75 > b286d8b1a690667 Herbert Xu 2016-11-22 76 /* Get a spot of the specified= length that does not straddle a page. > b286d8b1a690667 Herbert Xu 2016-11-22 77 * The caller needs to ensure = that there is enough space for this operation. > b286d8b1a690667 Herbert Xu 2016-11-22 78 */ > b286d8b1a690667 Herbert Xu 2016-11-22 79 static inline u8 *skcipher_get= _spot(u8 *start, unsigned int len) > b286d8b1a690667 Herbert Xu 2016-11-22 80 { > b286d8b1a690667 Herbert Xu 2016-11-22 81 =09u8 *end_page =3D (u8 *)(((u= nsigned long)(start + len - 1)) & PAGE_MASK); > b286d8b1a690667 Herbert Xu 2016-11-22 82 > b286d8b1a690667 Herbert Xu 2016-11-22 @83 =09return max(start, end_page)= ; > b286d8b1a690667 Herbert Xu 2016-11-22 84 } > b286d8b1a690667 Herbert Xu 2016-11-22 85 I thought this version supported that :-( Certainly I've hit and fixed this before. Using min/max() on pointers just makes it all more horrid. The problem is that is_signed_type() isn't 'constant enough' for pointers. Supporting pointers may require yet another (bloating) _is_constexpr() call= . Or add a simpler min_ptr() that includes a 'pointer' check. But this might only be reported by clang with W=3D1. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)