From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8781DC4345F for ; Thu, 11 Apr 2024 13:47:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2694C6B0096; Thu, 11 Apr 2024 09:47:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 219496B0098; Thu, 11 Apr 2024 09:47:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9F86B0099; Thu, 11 Apr 2024 09:47:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E10A36B0096 for ; Thu, 11 Apr 2024 09:47:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9A6DEC0B7C for ; Thu, 11 Apr 2024 13:47:26 +0000 (UTC) X-FDA: 81997378092.24.4ED53C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 58EC3A0003 for ; Thu, 11 Apr 2024 13:47:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fB8jojsC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712843244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9FUpUc2CBhEdAjjelkAsFFJf9cxoKp2w6Fokfr9S7kU=; b=RMfA/ptaVlI9QIC5xj5nSV5oWMvLLiUDZ9nn2InZ2w+uBXE9AloRS0sKlM/qvtofclYV9J NoJQhgxxIjWsgPkPiM2nIB1y7geIMQGkP1fGKAsM/Xf+NhvzUffcvY9nIA43z4HK3y7nzf wa+AjeVmzWWdu/UYfr646snfbWDdgoI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fB8jojsC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712843244; a=rsa-sha256; cv=none; b=wy6DoNgyje2kkBOugU5lAkpvj/NBHs0gAr8zSd8ufC8t3WFCCNbylO7AnulbLxfOdJ142X bHk4hgiyyTQABRbk4ScXvrgAkCQnmq0RDOePbZ+FKN+hTt4+KYoZJaF62zdRHVN1Nd8lNp n+ZyhZv/vCxrgafbdVcGV3/6OR/qsS8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712843243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9FUpUc2CBhEdAjjelkAsFFJf9cxoKp2w6Fokfr9S7kU=; b=fB8jojsCdQAnAfn61tFjRBm9EKJVTTmWOumGmOu+ILHFMfBSGQnSawKfKckYA8wVd8phwB kMoKLlvzrG/mv8b4USxL/UtNNf2LkRr7EvtvT4X5R6Qt6m3fEEl15yXlC5JYwGHKfHL8Yy dY3+avABFflZ7mlCCwwYw8c84nd0tE0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-iFevF9J8PDCkUEHh0C1Xng-1; Thu, 11 Apr 2024 09:47:20 -0400 X-MC-Unique: iFevF9J8PDCkUEHh0C1Xng-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-416ac21981dso5157105e9.1 for ; Thu, 11 Apr 2024 06:47:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712843239; x=1713448039; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9FUpUc2CBhEdAjjelkAsFFJf9cxoKp2w6Fokfr9S7kU=; b=n+iAm2FAsFPSKIjAzJ8tvq2Ha1n4uPRKjWgHLT7LwJMHu04ZT/GiVfGa/jQ2k/1XjY 4ZzK8DI3Schn48ZCTTLthNt94ChSQrdY9tKkvFaKZTc6QAJ0zNew49nrFbEtoCJELgK3 ZvaBJCsH+YgDCtoaqrG43NqY3f39qwF7OHn6p8qJOiiM/nq/6ZSAf7dr/nHfmkWgJ2F7 gjqdoyXsInbb0yq14/DcG7DFEgHzZv4Q+mzGIWxQBeR8brBaLU12HMuIDjCdOcEeT7Zs YPx80bnNimxtUZtej7Xmp74uqyQYV5owASbhqC+x0ZdwgzHWD60g/qTZv3pa1Um1aEYY zkBw== X-Forwarded-Encrypted: i=1; AJvYcCXaeLdBSCh9rjYhSNjCp83MO+Uv1UaT0Kar81MouDR3E8bUpVP3jHn7SbhzPp974z4Kv2/2SLbd9xbL6hubhpM4KVo= X-Gm-Message-State: AOJu0Yz1p6f7XJZeSsfCrJUHy6sCaOIsm/SXVzyGWl/tevWNcwZd2MbZ YKCDjfGlgQb9Ks5z1q2qqg+NXQcrqPpaz0yMb7lDR1FC32Doktuag4fM0hW52MGGOpGSRUYobVs 0aQ49JoiFd2AgxJV3gtzCPJn8tYpk/VSB/8TV4wXfM/zRHiL+ X-Received: by 2002:a05:600c:1551:b0:416:71ac:1bef with SMTP id f17-20020a05600c155100b0041671ac1befmr2329390wmg.13.1712843239134; Thu, 11 Apr 2024 06:47:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsUg5D0wDfuE+2Th+yVLoNTpM+9hW6exsncRgch5xzlNK868N2M64XkuZ7+meRE1F7o4ccqQ== X-Received: by 2002:a05:600c:1551:b0:416:71ac:1bef with SMTP id f17-20020a05600c155100b0041671ac1befmr2329358wmg.13.1712843238774; Thu, 11 Apr 2024 06:47:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:4300:430f:1c83:1abc:1d66? (p200300cbc7244300430f1c831abc1d66.dip0.t-ipconnect.de. [2003:cb:c724:4300:430f:1c83:1abc:1d66]) by smtp.gmail.com with ESMTPSA id h15-20020adff4cf000000b003432ffc3aeasm1818104wrp.56.2024.04.11.06.47.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 06:47:18 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 15:47:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 01/10] mm/gup.c: Remove redundant check for PCI P2PDMA page To: Alistair Popple , linux-mm@kvack.org Cc: david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: y861tsd4m9x1jo3zj3trf6san9asxs9d X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 58EC3A0003 X-HE-Tag: 1712843244-747848 X-HE-Meta: U2FsdGVkX19Z6nx/Zll//DCoUH+ekqz5kwD+S5bItQTuzIEIK1WlVefM3egcw9irCdraTB63W/4PAwkO1DdcsYDVPR5jwUG3c1mLQXBx1m2ujjr1AkuztbPztNcdmC0C/8oqAzMe8Q9/OonNnHB5plQJ4Z2r4/r2I9/J0ClWJohSbSl/8bY6YXh9U1GBq4F8/4bTszMZ/NwdR+Imu9ikAAtl01+ZRRtqXraEW0ySJB740zS4pfEnm8Z8kyKRjki9TNUZKnb4Exe5ioCEe2h9KKSDTNVv3B/WWeGg9tuRd1tUmHicqILELQ8xU3Ozk13Eizu92nF8GI8aI8Cj3SBaqTOZIiLpIO3DG6uLUGw2m4DzZlN96dFNZI+d7hnFM7s9oDFdVKKYkPyAB3VxMMkAnEDpKIylSEho7N7W4jmYklsqo4o0886vaKMpXBFWFq1otqJ45Vuo2y3/Lx1sBK/SqNdarp59Va3Z8DPLW3Jz2SJb6qaIFOdM5sQ0nATv/R2ynJDms2eE6H412N/adr4g2wyhuqPueOVZD/dQUkID+ujr9x3FEtyQbQ+O1hxXvm4eu2IKMappaYcz78X6XTKDxX1YFRlvJlvV2N8KFX2ueq5UJFrdX+utoFgS7x6OddYvrA+UGePOiigqF3qBKrzpt2Rq4QHvdT2eqor4QAumaO5199g+LwgJxb/9KoQ/RHygOFHd+Gp7RV7n7QndkWnZW4q78vgc7uieqP0b3GcSioDYuyuUsjbRTsdsW8TBnGw8qmuhAfrAyCCiCJcgLvPd/1VI7EHAS74P26VH8M3YOD3r5MHiTYxW1NcgrUl8WDMmlbRESVBBNeaak80WEsr3zmMxkJd3tF2r+I3lzKSYcaU/DB8sapzgwORWY6ZFX1JaJnS0ZCOFPOplvqWzFfNd6SlXQJw14Rq4zQ7Ps6yqVi41iT7hx87poJeoDuVF1KjU/yGDE2//CWHYlk9O0tO Ekj8lUqu jre+DUS18ZXLSEfWb54uZ8CVglt6ViRKXFZN/mjcWZZpk1tXt0xIJe276dFcWx2pKq6iXZnhHBHH+yLquRH1Rn7jMb+DvU2fBlTSNOWAVnSKaWWTDthuG3dSy98ITPWxqEhmk52jVBcqkI4i2HZ4VrtZVtyDk+DjjpmBLtYs94+3ZJiZ/XlJ+IEXaxQy1oaTp9qmeRI5dbDCLTOMyaz0HGROSIHcahK3aM86mGl1Tx1i4qmcMV5KJt8qwjTcpQ3y80yDQQbJg5rMJsLBRo0cq14UliTLaqRFUL4CBF6lZtELOx8k2S1UY1pP3hLuhKcfwtrG0q+jIeAIkAUZf8lcqpDFpcNZdXIBgJh2WUyRXZi9QWHVUKdeM82YL7bfCNhQmC61u+lRXs87e/lVPHmXPxZXsqH53/8mA782OJduXmLYXyGMge8s8iDk9LPvqUqTUz+DiHJwr/gsy/PKTkfd+jr8LCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.24 02:57, Alistair Popple wrote: > PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the > check in __gup_device_huge() is redundant. Remove it > > Signed-off-by: Alistair Popple > --- > mm/gup.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 2f8a2d8..a9c8a09 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2683,11 +2683,6 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr, > break; > } > > - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { > - undo_dev_pagemap(nr, nr_start, flags, pages); > - break; > - } > - > SetPageReferenced(page); > pages[*nr] = page; > if (unlikely(try_grab_page(page, flags))) { Rebasing on mm-unstable, you'll notice some minor conflicts, but nothing earth shattering :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb