From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9DFC64EC4 for ; Thu, 9 Mar 2023 10:13:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF2E86B0072; Thu, 9 Mar 2023 05:13:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA32E6B0075; Thu, 9 Mar 2023 05:13:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43DF280002; Thu, 9 Mar 2023 05:13:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C15186B0072 for ; Thu, 9 Mar 2023 05:13:09 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 815661C6447 for ; Thu, 9 Mar 2023 10:13:09 +0000 (UTC) X-FDA: 80548946898.11.97E4D4B Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 2BD19A000B for ; Thu, 9 Mar 2023 10:13:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ZxyKPddd; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678356787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lvVQF1Z+uVtTvM4KpAiC4+sb41Sbj2azQpu+xaEd4HY=; b=IxLJg9YtKhOIu3fSY+nnC5BITEcF/BIRi8kyKAbtcBbq2ZrM0KpsWvN2a4N2o5iqaWYJm+ 51XwpUjNDOOJ4u+ya7NE3R9LglAZP0f7YHhYogRagAYbXZMDdXWW4OZHcOk7pl9TgxPWet uGguloUQV+BtXI04a7ysbb90ib2FCBA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ZxyKPddd; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678356787; a=rsa-sha256; cv=none; b=ZpBubrO3ZEjztqWMeWly0QEm+2qpuNPYWv24Jieq7+NhvPRm+qvMhE6s/U39y/jYwPMWbT 6i5kj3JUvrElSvLTrsNd0r/OFiDFjg1Xg2v9Prp/SdabVj7h30xoXI9s3pUsUn6OxZiYG5 ndgkDG2I8/2nHGnBQfh0Xvckpv4Ob9Q= Received: by mail-pg1-f178.google.com with SMTP id s17so717167pgv.4 for ; Thu, 09 Mar 2023 02:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1678356785; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lvVQF1Z+uVtTvM4KpAiC4+sb41Sbj2azQpu+xaEd4HY=; b=ZxyKPdddxHeQ+erNNU4xvHftE9Ube3pH3+CenHP0xnsuI39OjpOuSzcC8iRkTS89Jg hvefqQhQp0tk/GzBJH3pBlDYrGxCCdZsUZKKcpjRlItJsbGZvSiI276J+nvgN2XL+4J3 N2LFtYo6Wy33dEJpyV0CNuUGpDSvoWoTQ9mrSgt/OeMCMH9+QKTghAeKN8tUYXndny+/ 5tdaqFRU/HsPIRoYX0MQiIqo7cZDkb2cRxqFj55eD7bcg9wqNXV1TEVFZb6/STpmqISm eGY/J3o8y+waSkkkVcBz2n4KxW7bXAaQXkTJ/+2jJx68IyIkQXNWImilGP6SD3madEek e17Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678356785; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lvVQF1Z+uVtTvM4KpAiC4+sb41Sbj2azQpu+xaEd4HY=; b=P5zQe4LL8Ypw7CkiAvdkwVc0tulcfXi5el0JWquHUNr1ohXeSoBL9dFvEQp6MLN3+P juOh+BA5MsE3M6TKQZI286qDDYOz7GWoO0LFv+M513CMhDAUhGiFfjHvCpkGAK4mAXuP oZPrQk9sCZMHjbX4eTAptNN++eZIOMKliSZHXBPkKm6W2eBy2kY9b2tyadctlUpNz/dk yGi60pG7bA0Ibf9U6Z5K9wBQCwN0mcCjzIStDmRi+uqNlc5/Y4+1UFiiBMhr9wsb+aBn j6TeqzUvcNMot3olJUcjhcvTI9MeBor/+BEqmU8uL/gYL/8KIGHF6eN64f4R3AzT8/+v S6Sg== X-Gm-Message-State: AO0yUKUZ/BkaCKupoVfEN2KCRemiTZYtmHnyv7Yl09BJe/1ObbtZEZig jwMGtRIwgjtklbl76Zn777mmKw== X-Google-Smtp-Source: AK7set9amO8fPlUgqGXCXAHuQ92SoXnTMxG3kffk6t+8GYoTyKmIzARwg//5k+9psmIIFI3C9fRfPQ== X-Received: by 2002:a05:6a00:992:b0:5de:a362:ecf1 with SMTP id u18-20020a056a00099200b005dea362ecf1mr2362997pfg.0.1678356784831; Thu, 09 Mar 2023 02:13:04 -0800 (PST) Received: from [10.70.252.135] ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id 11-20020aa7910b000000b005ad9e050512sm10797487pfh.121.2023.03.09.02.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 02:13:04 -0800 (PST) Message-ID: Date: Thu, 9 Mar 2023 18:12:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 4/8] mm: vmscan: add shrinker_srcu_generation Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, tkhai@ya.ru, hannes@cmpxchg.org, shakeelb@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, david@redhat.com, shy828301@gmail.com, rppt@kernel.org Cc: sultan@kerneltoast.com, dave@stgolabs.net, penguin-kernel@I-love.SAKURA.ne.jp, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230307065605.58209-1-zhengqi.arch@bytedance.com> <20230307065605.58209-5-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2BD19A000B X-Stat-Signature: iq8k5rxdye7g55or6c5dito9qrfieuqc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678356785-287700 X-HE-Meta: U2FsdGVkX1/pjW5/6emoScR/34uVBdT8XhI0SIKAQZqGS6ltMjD+Yo401G0L1gwQ6nsWbpgbIMUTV63NI+tjQPtGL4WuBGxb5S/7KoxcQ8GaoypqTEr4h6qt7UyVJLVNSEmbtt64olxLDyHj98efV1dGQuYLmkJfQVCbaJCaULuzeD3aQnRprXQ//2l1v1oOt9rcgc2rmGlRarZv792d08AAC1DepyxL/cTvo9KJ9JP+ZN6gLl4eYEouvESig4Vecx7yzk6GbnFSnGyQLFMhZzh7mR7WiM3SWZ6vkVYNNdNFtCTt35ciErc0OZ91l9Cx3uzpO50df7TODH9/zlP1LANJ7gZD/Chd9xN9BnuUOjw8K9m3shbBHetFIyxgIAnDHoiq4wuDFdgGbnj0sdZihgmgIFX+WqVdB2JrZVvgxcLUoHmNGfUtgJYq1gVhX82z5dB6gAd3CGu/XV6TKWvV1Ju2LQdn3Qc4fLlMFCTMwBoI8rnGBVZQmFxXdIKDNG/zBGvAKFduyx/i8iXkQwtyPgtdmF3iKF9VYDt+Qryo4NGRnEZm/x3Pi0qc4ORpf5lSENFRbhxXnGa9s0ByMmL8jhGP0luKdc6Ue1AB/FCclgcPLON1ghExmiVa3uj7HohQUPcQ4DNfpcH7MB1U3jhCmcRytCzNMenZmLysbTR/LFtP8GVXZ84cLKA7gXpDnTGsdA43iVnMm7dsBNVM5ZgNYo4n8uvFwK2iysZWPyfVgoFK3YiBf6RjLOsvUZCLH/cfF9l1NENoYolk7xH7dneee2/Ed9+j+hrDcP69Oi81ni3ThidFRE0mJj/5CL9KW4gU4NnzN10aSzcZv4cvgiQ+U4J4vbCBiP6KwwD+LVrN0Ar0YJl7MSnf5WVTNzbOdUjX18vtQXoubcWseu88aFkJyiQ2ynGB+e8hYbJa0cpe72mnP1vauARyvoaqx42UatNdBt1yPYwLFse1i1lwEXY dY5cAH8w +nYzLQKRAqQuIpW/voWH37D1zdwzWy0heSaRHr73Rw6LIRVp626G9qV0rWZSM4t+vgd2mhEB5VNlG3rVLpv7+PCIqFbs3fiRl5CLBbub5wO2JCsBqK+2J54ousHJp4Pi5qn2aD8/lCVPEprXbIMcF5xeu9L/MT3x/cuL0vPL5jqOezDOHRlAPSWTGOpwrGhCmvQbrtrZesWX/mxwFem5wcLMcZeW+/7tRIB8QKgvaYPtp2NzvJYDNBdNISXo7RYAVjmNRgxOf03GrAeX4XZWZ3G+lWxBVbex76EEzYCuWrgT+wOuVy/kH3vP/ig32vuoZaVbMJCgL+yKPYrofEMvMVYVD5wCb5M4pX2Wip29V9a20Cr/GMoeRjzpt2vSFkOToDJO1KzjTZI8Q2lWVocOaIZU3v+JIRp3ggKt08XoqnR411ewoiVqnsKsQbjBEylhsiUsHGNNWT098M7kV2c5BPTJ8ykkhrQ56l/QSS2+ozUCEMkIru3SOteDYOQ6/P8SSnRkYKt0aCT7UcKmh3QyPeFtEBg9TZ0+SvIEB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000420, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/9 17:23, Vlastimil Babka wrote: > On 3/7/23 07:56, Qi Zheng wrote: >> From: Kirill Tkhai >> >> After we make slab shrink lockless with SRCU, the longest >> sleep unregister_shrinker() will be a sleep waiting for >> all do_shrink_slab() calls. >> >> To aviod long unbreakable action in the unregister_shrinker(), > > ^ avoid will change. > >> add shrinker_srcu_generation to restore a check similar to the >> rwsem_is_contendent() check that we had before. >> >> And for memcg slab shrink, we unlock SRCU and continue >> iterations from the next shrinker id. >> >> Signed-off-by: Kirill Tkhai >> Signed-off-by: Qi Zheng > > Acked-by: Vlastimil Babka Thanks. > > -- Thanks, Qi