linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, vbabka@suse.cz,
	baolin.wang@linux.alibaba.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] mm: compaction: skip fast freepages isolation if enough freepages are isolated
Date: Thu, 25 May 2023 20:54:01 +0800	[thread overview]
Message-ID: <f39c2c07f2dba2732fd9c0843572e5bef96f7f67.1685018752.git.baolin.wang@linux.alibaba.com> (raw)
In-Reply-To: <cover.1685018752.git.baolin.wang@linux.alibaba.com>

I've observed that fast isolation often isolates more pages than
cc->migratepages, and the excess freepages will be released back to the
buddy system. So skip fast freepages isolation if enough freepages are
isolated to save some CPU cycles.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 mm/compaction.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index eccec84dae82..3ade4c095ed2 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1550,6 +1550,10 @@ static void fast_isolate_freepages(struct compact_control *cc)
 
 		spin_unlock_irqrestore(&cc->zone->lock, flags);
 
+		/* Skip fast search if enough freepages isolated */
+		if (cc->nr_freepages >= cc->nr_migratepages)
+			break;
+
 		/*
 		 * Smaller scan on next order so the total scan is related
 		 * to freelist_scan_limit.
-- 
2.27.0



  parent reply	other threads:[~2023-05-25 12:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 12:53 [PATCH 0/6] Misc cleanups and improvements for compaction Baolin Wang
2023-05-25 12:53 ` [PATCH 1/6] mm: compaction: drop the redundant page validation in update_pageblock_skip() Baolin Wang
2023-05-30  7:27   ` Vlastimil Babka
2023-05-31  1:44     ` Baolin Wang
2023-05-25 12:53 ` [PATCH 2/6] mm: compaction: change fast_isolate_freepages() to void type Baolin Wang
2023-05-30  7:29   ` Vlastimil Babka
2023-05-25 12:53 ` [PATCH 3/6] mm: compaction: skip more fully scanned pageblock Baolin Wang
2023-05-30  7:59   ` Vlastimil Babka
2023-05-25 12:53 ` [PATCH 4/6] mm: compaction: only set skip flag if cc->no_set_skip_hint is false Baolin Wang
2023-05-30  8:03   ` Vlastimil Babka
2023-05-25 12:54 ` [PATCH 5/6] mm: compaction: add trace event for fast freepages isolation Baolin Wang
2023-05-30  8:24   ` Vlastimil Babka
2023-05-25 12:54 ` Baolin Wang [this message]
2023-05-30  8:32   ` [PATCH 6/6] mm: compaction: skip fast freepages isolation if enough freepages are isolated Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f39c2c07f2dba2732fd9c0843572e5bef96f7f67.1685018752.git.baolin.wang@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox