From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CE1C83F17 for ; Thu, 10 Jul 2025 17:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4E3F8D0002; Thu, 10 Jul 2025 13:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B265D8D0001; Thu, 10 Jul 2025 13:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A155A8D0002; Thu, 10 Jul 2025 13:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 92E7E8D0001 for ; Thu, 10 Jul 2025 13:42:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EEF8160622 for ; Thu, 10 Jul 2025 17:42:21 +0000 (UTC) X-FDA: 83649074082.04.9C45D01 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 4BBA1C000F for ; Thu, 10 Jul 2025 17:42:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvfUl0kP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7WkRgRAS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvfUl0kP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7WkRgRAS; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752169339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NSg4IAdzO+7yQDPq/ZwPTmEBT6+QZulVILXuFpOtL9M=; b=vMclBe9qPqW5FPRgOrnABNxeW68X4xeivjetE5mJkc3kAFgLzWPZbShjabbpjpw82Dj2+c iz74MHETbjT3CSOsc1+9Yh96UfE8j7VO1e+cNHeRryA94JgJ7trzJ9Knf/vmWC7LUI5YYV nPjFqdXmz5MmyulfWBnBufc63nDwreQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752169339; a=rsa-sha256; cv=none; b=gh4jsmfPlcCyxG01wXcdu6uo4CgMImHXe/2hL43X+OUeyJ6YYFumO+agt5Ujp/lOhMs7vY hRExaLIH6JkzkuupQenFbLKkx3iKPHz0pV7BjXAebzMbGvlp2UFbAMF2OSHJF5NUaiBBJ+ 4z7avAy0RufDf0iVg3Mr9/WxQE6FJbI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvfUl0kP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7WkRgRAS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvfUl0kP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7WkRgRAS; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 799E721185; Thu, 10 Jul 2025 17:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752169337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NSg4IAdzO+7yQDPq/ZwPTmEBT6+QZulVILXuFpOtL9M=; b=HvfUl0kPhhy80YYdg3x4iCzS5YheUBd1kl7AxtEN0kbyj+ybOQBVlV+UvtuaLF0kRfPOW0 4IR1WheqPkZBHnFJyvrqJGoSvCJoQsjBFQdeFlSNs+CfLAAr5JugpMTRxBqLkxx+r/Ho7a MI0gTIsyRIz1cg62OsjpyObO8fnU7y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752169337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NSg4IAdzO+7yQDPq/ZwPTmEBT6+QZulVILXuFpOtL9M=; b=7WkRgRASrgLNBypt3zoSkgj3JdMdmt2f5T4GBmMJKGtm3bun3uiqV+iBXJ4PQclp69MNTn nBM2Yo9Ie9fzALCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752169337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NSg4IAdzO+7yQDPq/ZwPTmEBT6+QZulVILXuFpOtL9M=; b=HvfUl0kPhhy80YYdg3x4iCzS5YheUBd1kl7AxtEN0kbyj+ybOQBVlV+UvtuaLF0kRfPOW0 4IR1WheqPkZBHnFJyvrqJGoSvCJoQsjBFQdeFlSNs+CfLAAr5JugpMTRxBqLkxx+r/Ho7a MI0gTIsyRIz1cg62OsjpyObO8fnU7y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752169337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NSg4IAdzO+7yQDPq/ZwPTmEBT6+QZulVILXuFpOtL9M=; b=7WkRgRASrgLNBypt3zoSkgj3JdMdmt2f5T4GBmMJKGtm3bun3uiqV+iBXJ4PQclp69MNTn nBM2Yo9Ie9fzALCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 42D21136CB; Thu, 10 Jul 2025 17:42:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LRP4D3n7b2g8cgAAD6G6ig (envelope-from ); Thu, 10 Jul 2025 17:42:17 +0000 Message-ID: Date: Thu, 10 Jul 2025 19:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] fs/proc/task_mmu: read proc/pid/maps under per-vma lock Content-Language: en-US To: Suren Baghdasaryan , "Liam R. Howlett" , Lorenzo Stoakes , akpm@linux-foundation.org, david@redhat.com, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250704060727.724817-1-surenb@google.com> <20250704060727.724817-8-surenb@google.com> <3b3521f6-30c8-419e-9615-9228f539251e@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 4BBA1C000F X-Rspamd-Server: rspam03 X-Stat-Signature: m66ukmgyz8mnqeorbbd7csqgkzipq9i9 X-HE-Tag: 1752169339-78273 X-HE-Meta: U2FsdGVkX19CKyNuGXddZHvr2ORXy5ljc/vRJRjKdxG83I8HGwzju0EV5q0lERf+6mB4I7kjBnOVcgmGyn/ShoEJIPp6iHrXGxP3gd6lMHaROW2vjx+l4FZ6kzbItiUeNBrN5kl9t0urixrO5P3QjV9iRCUlz33jy2Qpd/6Dy9MdG8tdC045ANnNiaKtqtU9Kkcke5VPwAWf15rGpeUBNUXeQMaxPSHNpmXeZU7h2veeD/7w06C0ZKzWPa3GHmdHrHswOf4TkmQ5VMGipAzscaSporfsrm0mpsju8o5/R+YRZ6sPe2ef1GxYhkNC5tGMLN+cj67tAiD/FBJC47+NEWl5EtjY+KiieITbwXIU+sOjyyQq7CT+eTvhuPYrsHvbwhs6u/4+hgMG2y4bH9lYoQ3/BkGZUy9GOGc1Kv9MVLiZ7u2J4+LzUvkkCbFtPGL0KT+1aOc0PC7/85uwTG6/a79wsqo20abGeaL4u0C6wwsqGPzxI3gsukxAM6njj2j8X888n35gnLTNkGoVRq/atBPXKUHwRZoIIRLp/kPlNIS4J0A1gGnd1JGC+9EM3ajo4XOQrTpUZVQIjC1Lc9zpA/Jlv2qQ82DjqNuj3WMqXeQKIVpItizEEwMiVzJjAO+PCyB2HvRzs9rVZc1K99B4w9KbsxrGjQ/Y1iLtX3qr1Tb6fAqRO9SE4xJE2YsA7yKHvmkvuQitcuz0r0PqkxamKTWjlzlcGeXsLR9L62sfMSIMWp0WuXvREGshjlUZKVDCAgzjQnOTdc7rqVGGdmtOMr+6oMMkodZKJch2GyBX6tDuZau8uUCN8/lnVpXUTEzL3d9MnxGRkZjE8zh1KVC2Uv4zDiEzpCC6XBXY1oouHZM6UuVghv9XRRNDV36eWgNvL5smb/jYi+tGoiD4MMff2Eac6+s3mq4Gz+qfIJe8LwOBTR/udLB4UQ75gv+DZaWEe3aXtjW41i+u8dhuudK G+wKqSvH D+TtI6VJ/p0rONKA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/25 19:02, Suren Baghdasaryan wrote: > On Thu, Jul 10, 2025 at 12:03 AM Suren Baghdasaryan wrote: >> >> >> I have the patchset ready but would like to test it some more. Will >> post it tomorrow. > > Ok, I found a couple of issues using the syzbot reproducer [1] (which > is awesome BTW!): > 1. rwsem_acquire_read() inside vma_start_read() at [2] should be moved > after the last check, otherwise the lock is considered taken on > vma->vm_refcnt overflow; > 2. query_matching_vma() is missing unlock_vma() call when it does > "goto next_vma;" and re-issues query_vma_find_by_addr(). The previous > vma is left locked; How does that happen? query_vma_find_by_addr() does get_next_vma() which does unlock_vma()?