From: Vlastimil Babka <vbabka@suse.cz>
To: Suren Baghdasaryan <surenb@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
akpm@linux-foundation.org, david@redhat.com, peterx@redhat.com,
jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org,
paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com,
brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com,
linux@weissschuh.net, willy@infradead.org, osalvador@suse.de,
andrii@kernel.org, ryan.roberts@arm.com,
christophe.leroy@csgroup.eu, tjmercier@google.com,
kaleshsingh@google.com, aha310510@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v6 7/8] fs/proc/task_mmu: read proc/pid/maps under per-vma lock
Date: Thu, 10 Jul 2025 19:42:16 +0200 [thread overview]
Message-ID: <f38cef22-d3e8-4f73-a8ba-1a2cb0f4808e@suse.cz> (raw)
In-Reply-To: <CAJuCfpH0HzM97exh92mpkuimxaen2Qh+tj_tZ=QBHQfi-3ejLQ@mail.gmail.com>
On 7/10/25 19:02, Suren Baghdasaryan wrote:
> On Thu, Jul 10, 2025 at 12:03 AM Suren Baghdasaryan <surenb@google.com> wrote:
>>
>>
>> I have the patchset ready but would like to test it some more. Will
>> post it tomorrow.
>
> Ok, I found a couple of issues using the syzbot reproducer [1] (which
> is awesome BTW!):
> 1. rwsem_acquire_read() inside vma_start_read() at [2] should be moved
> after the last check, otherwise the lock is considered taken on
> vma->vm_refcnt overflow;
> 2. query_matching_vma() is missing unlock_vma() call when it does
> "goto next_vma;" and re-issues query_vma_find_by_addr(). The previous
> vma is left locked;
How does that happen? query_vma_find_by_addr() does get_next_vma() which
does unlock_vma()?
next prev parent reply other threads:[~2025-07-10 17:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 6:07 [PATCH v6 0/8] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 1/8] selftests/proc: add /proc/pid/maps tearing from vma split test Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 2/8] selftests/proc: extend /proc/pid/maps tearing test to include vma resizing Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 3/8] selftests/proc: extend /proc/pid/maps tearing test to include vma remapping Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 4/8] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 5/8] selftests/proc: add verbose more for tests to facilitate debugging Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 6/8] fs/proc/task_mmu: remove conversion of seq_file position to unsigned Suren Baghdasaryan
2025-07-07 15:01 ` Lorenzo Stoakes
2025-07-08 17:37 ` Vlastimil Babka
2025-07-10 5:49 ` Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 7/8] fs/proc/task_mmu: read proc/pid/maps under per-vma lock Suren Baghdasaryan
2025-07-07 16:51 ` Lorenzo Stoakes
2025-07-07 23:10 ` Suren Baghdasaryan
2025-07-09 8:57 ` Vlastimil Babka
2025-07-09 14:43 ` Suren Baghdasaryan
2025-07-09 15:03 ` Vlastimil Babka
2025-07-09 15:06 ` Suren Baghdasaryan
2025-07-09 16:11 ` Liam R. Howlett
2025-07-09 17:47 ` Suren Baghdasaryan
2025-07-10 7:03 ` Suren Baghdasaryan
2025-07-10 17:02 ` Suren Baghdasaryan
2025-07-10 17:42 ` Vlastimil Babka [this message]
2025-07-15 8:16 ` Vlastimil Babka
2025-07-15 9:40 ` Lorenzo Stoakes
2025-07-15 9:52 ` David Hildenbrand
2025-07-15 10:16 ` Lorenzo Stoakes
2025-07-15 10:23 ` Vlastimil Babka
2025-07-15 10:31 ` Lorenzo Stoakes
2025-07-15 10:51 ` Lorenzo Stoakes
2025-07-15 17:05 ` Andrii Nakryiko
2025-07-15 17:10 ` Lorenzo Stoakes
2025-07-15 17:20 ` Lorenzo Stoakes
2025-07-15 17:29 ` Andrii Nakryiko
2025-07-15 20:18 ` Suren Baghdasaryan
2025-07-16 1:50 ` Suren Baghdasaryan
2025-07-15 20:13 ` Suren Baghdasaryan
2025-07-16 14:00 ` Lorenzo Stoakes
2025-07-16 14:07 ` Vlastimil Babka
2025-07-16 14:27 ` Suren Baghdasaryan
2025-07-07 18:20 ` Liam R. Howlett
2025-07-07 23:12 ` Suren Baghdasaryan
2025-07-09 10:03 ` Vlastimil Babka
2025-07-09 14:43 ` Suren Baghdasaryan
2025-07-04 6:07 ` [PATCH v6 8/8] fs/proc/task_mmu: execute PROCMAP_QUERY ioctl under per-vma locks Suren Baghdasaryan
2025-07-07 16:54 ` Lorenzo Stoakes
2025-07-07 18:26 ` Liam R. Howlett
2025-07-15 8:10 ` [PATCH v6 0/8] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f38cef22-d3e8-4f73-a8ba-1a2cb0f4808e@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=aha310510@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=brauner@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=josef@toxicpanda.com \
--cc=kaleshsingh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=paulmck@kernel.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tjmercier@google.com \
--cc=willy@infradead.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox