From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9678C4332F for ; Thu, 2 Nov 2023 02:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47DFA8D0072; Wed, 1 Nov 2023 22:19:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 407318D0026; Wed, 1 Nov 2023 22:19:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A9548D0072; Wed, 1 Nov 2023 22:19:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 14EF88D0026 for ; Wed, 1 Nov 2023 22:19:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF002140DC1 for ; Thu, 2 Nov 2023 02:19:31 +0000 (UTC) X-FDA: 81411407742.06.1098B4A Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf10.hostedemail.com (Postfix) with ESMTP id 1C123C0004 for ; Thu, 2 Nov 2023 02:19:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U36CUZib; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698891570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0zc20fVFKy4W9h0KGCjjTFtHtA4V+tYwK8sbCEwSZYE=; b=2hMPcsd7TSNhTY+F0CVeq7uxmm1OnTg7R7ao4uYs5VsIU+mHoyWV1JUSNgdcMtzmD97ajs XeSrU6eY1bAV/WwQwhRjyTRXAXD17lx6gpdKms20TJZ3nC/0uN6v+aDZxjIJviDaeNg2rv z6g6y/ZvgP4KBgBjgDFrYapIYuvJPoM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698891570; a=rsa-sha256; cv=none; b=tWuuzoG7BkbWS7rYq4H36VJEHejULQEMnPHBoHbiOzRRA6+fpFhAlvZzzLQg/Ir4w0+ffa caU70x6jHRV5wXSLjqZ8NK1uiY6TJaCroEVcmVEM4TRhn61+t5viGyumhzq6io8bVjxOnu EH9Ccg55h71T3avZHAq7tHTxW8RcGAo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U36CUZib; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698891568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0zc20fVFKy4W9h0KGCjjTFtHtA4V+tYwK8sbCEwSZYE=; b=U36CUZibqC0+MoWHyMYJOLWR8uef9oka8hi7CkwX9g6Jt9nGWFsqLqKzQIfIzcGtCue04m T8fRH+UBIlJNzkGdenTucm/KMQLemuAym9FKElL1afbOqueynWi2sYN/KEdWjJdBovPjHk LJQmbbSGu4LaDJs1Gc/jUOlvi0EspCo= Date: Thu, 2 Nov 2023 10:19:18 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH v4 0/9] slub: Delay freezing of CPU partial slabs Content-Language: en-US To: Vlastimil Babka , cl@linux.com, penberg@kernel.org, willy@infradead.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231031140741.79387-1-chengming.zhou@linux.dev> <029f5042-e41d-5079-fdba-fbe3d4e60dcf@suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <029f5042-e41d-5079-fdba-fbe3d4e60dcf@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1C123C0004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ew9973z1mnq4bsqttjr1w3m34uf479w9 X-HE-Tag: 1698891569-203072 X-HE-Meta: U2FsdGVkX1+xCFJGhhk0O0YE+V5If4Nl8CQ5AW0hyyMMreJiUQj6SM2OPjCspOgVEPnd3Gwbx+otNO6bZwHEDmX155QXJLBMj0p8MCRBznqw6tRCwWCpGPyAsF/DKH6m8+GcMESwFwytoaomh9PGuFbACEL+UOeilysnSZ3Wr4tChomFGtSptqRrcjlPmwxDokbeRocWjCuu9d8JHyhN1wPSeVEGKP1rPx8Xwrb1ALk3uA/KyalnLTsC4qNGUAxIENVBPkIbVI+GJm1A+Cs4AWYkpGCPuFBaVpMIRwd302rkcAUbsDwsXcB9LosDlGrvFAZuio4RGkbJP9JdJlcRYcK/mecAz6JsRz2pi6lr3xEqYPFk/OaB9LAmHF68t1iD9O3kiMFC19i9oBjKtPGAN65pUaxBW8wRy57YHuSz1i+Zk+ocGasTWnNB2QEbr0h9TOGYZkxBA83JNUGHRMI52UPQCPZPvJGuBviSXNcNeR16s8W/+IPYszy2bwUoyfpX0tVl7Qlac+LsNNeyVMpCqlxlV6JR16E2dBCyYJlgeolwqZKL0vVJTLrkEpC/PMJJWIXRAfsIROTvWN4iWrohOwoI5l/XEe2FHJHQG66KLXo/vsU14IY3aYMCDDckGzuwI91cHUHRgomIoqeAJ8+PeJ2lFYpykOkxuZdajoaDPk3R5xEMp2kGuvgPchW2TkTrERafpi5uTxK8/V5r73ETjMjONtHiR6YneaVZROqkp+wEc8CcwSorpRClwtifuoHf/vnIATu1CVyNCuCZXsCY2iSxYA5052zBBJoR3U/vOpPmsFfBkfEo4h4XEYWxM2skyD4UdzEmmkKFFxmEjoAMJgHHfb8u9RzYdEHbACUXjKXVfPlJIHlZ+harYYwlxGRhWQBn5meccZpmXF99d/pXLU7LalHTo52uBCRVwmRwFY3b85SRYuY+rEnEJumiIcYK6RARo1qo4ZKsv/yN41q mGi/UkF1 /DzARXgrdeRLMGWd9o/komvKWukOeGuk3o2zsvpCSl7wscP0wi93mIkO6pZNIjBouTpqxbSQ5LJUn6M+WCnnt0IcE9rH9vKen9yPms6SpuRBtPUKcuGFfMtJ/tqxsjfx9f6OdksrtTN+NX93B2g0JYFHOy5E84Gptf7/k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/1 21:59, Vlastimil Babka wrote: >> 3. Testing >> ========== >> We just did some simple testing on a server with 128 CPUs (2 nodes) to >> compare performance for now. >> >> - perf bench sched messaging -g 5 -t -l 100000 >> baseline RFC >> 7.042s 6.966s >> 7.022s 7.045s >> 7.054s 6.985s >> >> - stress-ng --rawpkt 128 --rawpkt-ops 100000000 >> baseline RFC >> 2.42s 2.15s >> 2.45s 2.16s >> 2.44s 2.17s > > Looks like these numbers are carried over from the first RFC. Could you > please retest with v4 as there were some bigger changes (i.e. getting > rid of acquire_slab()). > > Otherwise I think v5 can drop "RFC" and will add it to slab tree after > the merge window and 6.7-rc1. Thanks! Ah, yes, I will retest v5 and update the numbers today. Thanks! > >> It shows above there is about 10% improvement on stress-ng rawpkt >> testcase, although no much improvement on perf sched bench testcase. >> >> Thanks for any comment and code review! >> >> Chengming Zhou (9): >> slub: Reflow ___slab_alloc() >> slub: Change get_partial() interfaces to return slab >> slub: Keep track of whether slub is on the per-node partial list >> slub: Prepare __slab_free() for unfrozen partial slab out of node >> partial list >> slub: Introduce freeze_slab() >> slub: Delay freezing of partial slabs >> slub: Optimize deactivate_slab() >> slub: Rename all *unfreeze_partials* functions to *put_partials* >> slub: Update frozen slabs documentations in the source >> >> mm/slub.c | 381 ++++++++++++++++++++++++++---------------------------- >> 1 file changed, 180 insertions(+), 201 deletions(-) >>