From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC86BC433FE for ; Wed, 9 Nov 2022 19:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C12046B0072; Wed, 9 Nov 2022 14:31:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC1E76B0073; Wed, 9 Nov 2022 14:31:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8A416B0074; Wed, 9 Nov 2022 14:31:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9936F6B0072 for ; Wed, 9 Nov 2022 14:31:11 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 40758ABB57 for ; Wed, 9 Nov 2022 19:31:11 +0000 (UTC) X-FDA: 80114897142.18.556C896 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf22.hostedemail.com (Postfix) with ESMTP id C3AB5C0002 for ; Wed, 9 Nov 2022 19:31:10 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id z1so11575932qkl.9 for ; Wed, 09 Nov 2022 11:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=eeGIPpDgArzFfYgFEOrNZo7weULW88kk3fiLdCyU0sU=; b=SREN01gokrPFFrgd8zT1O5gnWpXiNF0MDh2jOSS1ihhfL9Hr8Hy0x3Y+liF+HNmzjh aA1Y2TRFLYd9dien0puJNUAHK6+oB5axp+/obLVsDh+IUAWwrZxlUpGePLz5+00rmTbN u82a6RHngd1BxT5rW7Yc6J+7M0dGRTMTTsPQPFhknuNjhdl+nAkkG+w8pP3kIOn2/u84 mYP/dec6mirOqpQ66gVy/I7EnUXsZswkmIf/XrGv/qYDPvQUKQpGBQv9cbc9O84LePbb TSM2JLCXF3uv0ovmA7DW5M8P6F4FKSnB19U7a/9s492g0xDWON3EwmLJwjtF/NhM07Ao +QeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eeGIPpDgArzFfYgFEOrNZo7weULW88kk3fiLdCyU0sU=; b=jTtYI7ndeZlAwEaw1ngxz+CXxj5W9cMIkWu/MyBH0yE/HcKw8G2xoTSx8v7xZQToUc pjrL8fK4s5NdnEaVt4LdiRWgMFoDkZSornTG+Arxzzqm8rV2Sx37zfkyDWYt54lgbPv7 p9sRfmW8EIc+p/fmNaJzJiLI7BQe5wFsVbo/9Kdmjw+yIkq9of+u+mYSZ69lOk1uxPcM Jr5+4PraC+Jfo9sNakfMqY9cV4yK5ml09FTXi9qL9vLcRNRs9kXuXqWCfh+eyAgOA96G sXZ8jeXqIRt5682QajNLhGUey45qsGEOsDe3X1n2TeOEc9c4TH+PpN6zZkPGaZmgMnWA dn8A== X-Gm-Message-State: ANoB5pn2zLzJJUw29/joPK4eEWrpla4bnKBE69jfFzDvEU3S3coeF5t5 NynU1vBbPekp9zDVf0+Rt5WQ7A== X-Google-Smtp-Source: AA0mqf48+lwvGfrLFbuIkHD0vbPPIrPCjuhjDP8SAKBlKkK3DgMoo2GORW9J5ipQssTKITKu7RpGgA== X-Received: by 2002:a05:620a:ce7:b0:6fa:baf6:ce9 with SMTP id c7-20020a05620a0ce700b006fabaf60ce9mr15282421qkj.421.1668022269796; Wed, 09 Nov 2022 11:31:09 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id bj17-20020a05620a191100b006ef1a8f1b81sm11635339qkb.5.2022.11.09.11.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 11:31:09 -0800 (PST) Date: Wed, 9 Nov 2022 11:31:00 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Linus Torvalds , Johannes Weiner cc: Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Zijlstra , Gerald Schaefer Subject: Re: [PATCH 4/4] mm: delay page_remove_rmap() until after the TLB has been flushed In-Reply-To: Message-ID: References: <20221108194139.57604-4-torvalds@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668022270; a=rsa-sha256; cv=none; b=sfOAGa41sYxgDNPI7MGFKpNEH1rdU//9ZqxFIIGQEj5liuzTNxc3QGPJac3IY5o8RHraCn lNSH8QBT0zylk97HNa5k1Ae+tVHEAiqnIqfEbfmdGpqwOGc5FNplodhdGPzcfnwtT+GSBk CvBFEkRi/zG9bcPBb1FHOp6k4LVtfbQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SREN01go; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668022270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eeGIPpDgArzFfYgFEOrNZo7weULW88kk3fiLdCyU0sU=; b=0LEqzeyhHv/90lOFwHjaO9QqfqJeOrs6zVPGk5zb90OnI4g1m4rGuguFh2gz5Cw1Qi8hXM cEKqRIIoWz0NuzrIl94WtSorrdEOAvMvgJd+HHOgTTzFaKUrwh3q6YNUJYToSvNfjV0rKu 4318wOOSd08b2o77u3a5XXs6g27ymTg= X-Rspam-User: X-Stat-Signature: b999wm4c55cmkucts1g9qxpqcitmgtbr X-Rspamd-Queue-Id: C3AB5C0002 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SREN01go; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam03 X-HE-Tag: 1668022270-876084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Nov 2022, Johannes Weiner wrote: > All 4 patches look good to me from an MM and cgroup point of view. Yes, same here from me. I was running my load on them (applied to 6.1-rc4) overnight, intending to go for 20 hours. It stopped just a few minutes short, for some fork ENOMEM reason I've never (or not in a long time) seen before; but I don't often run for that long, and I think if there were some new error in the page freeing in the patches, it would have shown up very much quicker. So I'd guess the failure was 99.9% likely unrelated, and please go ahead with getting the patches into mm-unstable. > > And with the pte still locked over rmap, we can continue with the > removal of the cgroup-specific locking and rely on native MM > synchronization, which is great as well. Yes, please go ahead with that Johannes: and many thanks for coming to the rescue with your input on the other thread. But you'll find that the mm/rmap.c source in mm-unstable is a bit different from 6.1-rc, so your outlined patch will need some changes - or pass it over to me for that if you prefer. (And I do have one more patch to that, hope to post later today: just rearranging the order of tests as Linus preferred.) Hugh