From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7AEC46467 for ; Tue, 10 Jan 2023 03:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03CF48E0003; Mon, 9 Jan 2023 22:18:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2F0F8E0001; Mon, 9 Jan 2023 22:18:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF7088E0003; Mon, 9 Jan 2023 22:18:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF6D78E0001 for ; Mon, 9 Jan 2023 22:18:44 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A11A4162C60 for ; Tue, 10 Jan 2023 03:18:44 +0000 (UTC) X-FDA: 80337432168.17.463197D Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf10.hostedemail.com (Postfix) with ESMTP id B14FDC000A for ; Tue, 10 Jan 2023 03:18:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=X2TklK6j; spf=pass (imf10.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673320722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v2vMuRifEflR0rqW4sVbUmQc1/LuBQa1QT5vJMZvjAc=; b=VZF8hLLII6CjvqIam9R8wg2uIwBeCFFpqMxsJiCmNidVCDqzu88FXpjSZ7KRWTXa4xWhjm 7T4aJb4V75PNQQiTHWhGvfyVIIC7Vin1824RX73x7LkM5QaONlfLlRQ/UXdmNaCaQ8sKKI xSqzg2hQ+DsPa71UyUNnYSN1z0SRVNg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=X2TklK6j; spf=pass (imf10.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673320722; a=rsa-sha256; cv=none; b=RXooT36qcrnO0xCz0NARyhz8M/5Tl9hvfslX6zy4EbABLARlNdOgH7xLhTbs4VesuE0kIF 9eZhj/wlOi/Elpnty2226LKAoDnif9LnMEcy8gyHpLlVUPuJ9tXw8HxHSgvAMvECvCWS6q M5T12ZLkoI9L2cZeE/kaLZUGsHE2yCM= Received: by mail-pg1-f171.google.com with SMTP id 141so7333507pgc.0 for ; Mon, 09 Jan 2023 19:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v2vMuRifEflR0rqW4sVbUmQc1/LuBQa1QT5vJMZvjAc=; b=X2TklK6j3bpjXI8F9pl0dTcLZeEW9rmtOm9P6qKtQjrt7FgcPXyioe0lNefGzeViIB +pLK38NB74PfUxiGi2RvEBwD89DoJW+RQzzFMVsfcq5Y8Q6GYw/KyUmJVJ2L4TBqWj/E UwMzHyubCpYuuV3dZPMsMJNpzrYn+kcIoaeSE+0pkejMvaBH5+VSjAFhjU5RchZwPh9I yY6NthoZvdF4wrGoCc70PbufBEVRq+AwbYzI5L8EaiZAzfFUkAK+xhEuRUHYebPxGvIE DxBweGNr4e1HnPUV1SPYBQ1QGD6FSbqYhH/tMf2f7nMpxZOWbIb0mwF0MQkBqcnKBhkE 0O8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v2vMuRifEflR0rqW4sVbUmQc1/LuBQa1QT5vJMZvjAc=; b=aW8NHAdbax/Aricz7mOTcFjI28wQqXuQzizFMyEgMlad/oKQMM5uCm7RSbJE53MI4E IC/vMR/DeN8qC1hOD+9v3elKDmkk755rhns1HF/kSbyEaEo+oFTKrorfkC/AMiBaQNBW 9KwrhF5f2vYZzUollfpXsOpsSUfg5I4S1jvUSuQ2n4zN6tEHLZASzyJgcXx2yU9AQ1rA 71u7kgJ3Iw6xzTOc+C92MqFVY16vLgaznF4/ZaCFzwhZInCvF9X72zGIw6nWWimjgbJO aWEoFHjA4pargOvScBja8Md6flhCm2K8GueSpv9OBDLwUGNjnKXRETGTZeZkaZCwfKvM fqgA== X-Gm-Message-State: AFqh2kowYgOj+N92E5ltboERZuyJxzBkoLTxHU89L5GN/DnKTgqpjboq hhKwPA/GQvBYzm8W72SkkSpLkg== X-Google-Smtp-Source: AMrXdXvBg0uBp69ddXdGZcOkOEPW1BK7ZjQr2Kd9Z1AjIxSSnX02TnQVanCB2HrHkQ+GP/UBL3z07Q== X-Received: by 2002:a05:6a00:2a0b:b0:585:4ca7:5c4b with SMTP id ce11-20020a056a002a0b00b005854ca75c4bmr2754545pfb.2.1673320721376; Mon, 09 Jan 2023 19:18:41 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id u64-20020a627943000000b00581816425f3sm6480835pfc.112.2023.01.09.19.18.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 19:18:41 -0800 (PST) Message-ID: Date: Mon, 9 Jan 2023 20:18:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly Content-Language: en-US To: Yishai Hadas , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, jgg@nvidia.com, logang@deltatee.com, Andrew Morton Cc: hch@lst.de, alex.williamson@redhat.com, leonro@nvidia.com, maorg@nvidia.com References: <20230109144701.83021-1-yishaih@nvidia.com> From: Jens Axboe In-Reply-To: <20230109144701.83021-1-yishaih@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B14FDC000A X-Stat-Signature: yhjrbmyqxs7pfyc7ra4j9fedbhfnwubd X-Rspam-User: X-HE-Tag: 1673320722-239009 X-HE-Meta: U2FsdGVkX1/3O9blGW+BXBXtNVAd8rq+DDObP6xZlM3yTMrjHjSpd/j0K28Mp1cR8BGUsgRcu3Q4sAxT6IQIRuZRPfuNZsI7Fx4cHTsi7+snpT9ZTgZYLcYj2YthPjYnb3i3uvEAAoQBftRlGxITzkcrIEEV9L8A19k+G5HEAgjQtKseqhmcvJf054E/oh2DgnQBurhibnXFs0tdQ1AjbyCowezRbJOIzctzV5ay7yvTrSzk8ItWrJIHia/qbj4+K2PN6auFBswzPHf9mYWK2+cYlx6CNIYi2UiobLyAAFZpuB0Rm/+gHonat8U3Yey3sAABVeUcCOhLVkUEo/aaXsZn2o2FYnfE4DTfmGoCF/4+X2JOrtw5mET3/lrmLyKHHOueZsR2FOu5RY1oQ8eTSq1xSTeMdo2sAnnaNWSJ3O0McTRTvk8sB5V7MA8QMtvUcLE/vCGDl71peqH8LxYJiOsRRhqOgoyQbrfWorOyeYJIOkkLFtdQkJ+HsGdps6xXrxrnuCtDINS94zGaYjmwNTTxee7TzxLx86Gb/lwNqrmD3vk7P9fihAsYEiLKCxfrFE+JoiZqDFADnc0fVmu0VvEWCEsVgJOFU0yYVq+tnoEpooHlJCE66087ZJIj7v4IDRdW0v3ntAJX2N2FALs6cnCo9AMqK69Ke/VAmfmCZrWwre1dmve3xtrV8yS7AlHP7+zd65QzP3Hq38BVKrGXH/lBRRDWOHExWf/jIhVVkBg3056N1hw0lXwIe3KLJt5CIhwCnKSRQMOh0Nq/ZFpe1Ztfo5lm56dFK5fUaqtHeHKwwW8CmXW7Mv2qKSUP7MJxLZsi5pocETYhZwDH2wl2Sc2wYogLbxbyinRKs6R52nFUWvWIowGZRf6KEuJsKMLAtTt/GMS9OwX+TyiftKe15DgokmRs1jR7qGMMQ3vA3ibSgiwuVBNP9h+AFuJPVDcHkBZYZL/fGNXoDVqYdMy grdxfm/q KqMBgDDRMKUJEN+FqM0Pbfwq9Qcx9vV74eIytucJoJ92UdCgHr8HaP7gkXu0lfFUarcoTzVVUSVTSq/Ge6bjpIu1uaCsjj65viMhd21wNZ/nJqoxAfivCq8ilDwm0zkLfEIeYBhAD8f6026NmmmOB1ZDSE2368mIawXyxjwqQ5XydBSMnImOrsygDIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.041380, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 7:47 AM, Yishai Hadas wrote: > The last_pg is wrong, it is actually the first page of the last > scatterlist element. To get the last page of the last scatterlist > element we have to add prv->length. So it is checking mergability > against the wrong page, Further, a SG element is not guaranteed to end > on a page boundary, so we have to check the sub page location also for > merge eligibility. > > Fix the above by checking physical contiguity, compute the actual last > page and then call pages_are_mergable(). Reviewed-by: Jens Axboe Andrew, can you pick this one up? -- Jens Axboe