From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA60C83F34 for ; Thu, 17 Jul 2025 16:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF8CC8D000E; Thu, 17 Jul 2025 12:06:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA8E58D0001; Thu, 17 Jul 2025 12:06:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98B78D000E; Thu, 17 Jul 2025 12:06:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 981808D0001 for ; Thu, 17 Jul 2025 12:06:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A9B31A0174 for ; Thu, 17 Jul 2025 16:06:20 +0000 (UTC) X-FDA: 83674233720.01.6B8B0B2 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 4180540014 for ; Thu, 17 Jul 2025 16:06:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DrIjwYZ4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752768378; a=rsa-sha256; cv=none; b=c4E0UY4AExsYPwQAZYpi0AJX9PTkMdDn/MHk/Vcxf6tYslPk8hS3CrL5ybhxg0Eo+iqeCD jJG/TUzvaN8tL3T3DAGpsUXz7VH8EHbSIGK+H38RsfBBhMrj4B2fqCfyb3zrFBsGvr+zww bWfqDw/wr/Iqk4Uc23C2OnezFdYY0Vs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DrIjwYZ4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752768378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oNaOhocBhBO7oI/BRKzs2RUfkmKsF3Hfw+nSdB03cjI=; b=ABdEYxBsGSdbXVGaUtvbb783vvcqWLFwGTK93szPq5Z4SgjGcq7lCS1mTE1Nl2oiJFK+tE HbkPV6gpZG0BSgIvLdn0wp+52RXKFdKwRJIFQrid6gtKtejrCpdQjN2TpWyxPRwp1g7i8Z pzx9JEh4EX1/ETLGUuF9f0CTPWj4xSY= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ae6fa02d8feso179551966b.0 for ; Thu, 17 Jul 2025 09:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752768376; x=1753373176; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oNaOhocBhBO7oI/BRKzs2RUfkmKsF3Hfw+nSdB03cjI=; b=DrIjwYZ4cMDrW0x0ueWBtAn/ORljY1E9iGAh3qJRInK3zvEHU2vCCiyqxHtoIr6ZQw gRHTwyqKm7lDu6EdMQDtySQDR0pscu24y0+YUW2XjNPdtPM7f1wH/V3dRf0vnomy6ZVL CUlPcw4Sw34fIkuWkukGec2pKNqi08j1swh1agS9iSAGP0nelQ5diT41+nrkgXnc2vk1 UEUw+DwhGlyWm+DPbSechvWmbs9hriCrYLGSGZ2zv1MEAcqNCVAUMenuWfmd+w4Zb637 i2lTzWkx0783oV3uM0Ii+SOVSRurs7Yue/kUa/5VVlMroywUM6B4OZfYUSNRz8+/N+RA t3dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752768376; x=1753373176; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oNaOhocBhBO7oI/BRKzs2RUfkmKsF3Hfw+nSdB03cjI=; b=YPtO35kNgF/jzam46ByFFDI3a0rFu9XEDGTpU/vbsmT55DmYrvle4/0iimlcVR4Jsm s7BeciHm39eOxpgxjmvMvUA1+7nwYiJilZky7y1z33DJyQPNXx++jz8cRG0QGwUhZtyY uOQdp/2nufoYnG8a93nLiQ4uoDQWmnmHUkWiWFxuLMajVmpp69W/30Bwz+jhvoQawzSH DtMIoWMRZtUuWXZPABJxPSZqs82tpoQEniBm0aNH2qaeAs6+fXdu8kECisBz35xD2NjT XPDzU9FnbkQUFYV+v7MaHp9gLULoQT+EwhQV0MyYBHRmtJF/idpF6cHfACgwhk44G7dS UMyQ== X-Forwarded-Encrypted: i=1; AJvYcCUzRLRGJsW0DYHId4oUICK4M++4DClXk4ELSBdK0utxrNHcdYWHg97V6pjjF9su+FQJM5zhItKJAg==@kvack.org X-Gm-Message-State: AOJu0YzDM2BNwN5pCtYdlArwRUeAaTK/xJ3odmNYdNja8SITa0RMo8H1 qtcNlfz3HouqrSTYSdSf0fhVAFIU1v88T5WqXCpPoEwlr+aCl/ur8xio X-Gm-Gg: ASbGncuLavmeLu/vt9uLmEXP1UFB0KrRmTLeRa+BmjuVhL9LEw36UcwiKkp+U59ElzL +6t2bXUu2N6f/rlQL3ZcPmO24pwHrD8vYjkggnm8OOhtC59MWfnn7DL8+43Q0LPYfULPjwh0wdb 20nG/5+7Rc2mov13E4hbaXlxCqXbJB1E2+obOeL5rAiokKzXSBycEKDA8hWzhZBYseYZLPXBYpV BGGROHWiVXD8sF6ZvcZAeX2xdJtfUSEtPaeunD+WZbYk+vkiiqN8MR8zhqKUZh/0PRXRoHOdx5d ufPQNZhbHg65LCT+L+rApl0DrBceLoV9T8XHKoIn71Oy0HOA/4blReaDb/9xBlx/65tTLhLuNMi D+1kR4C2BotapC0VTAF5MUKub8FN+77OeIvJRWZaCpFhbewrpGqZoeW4guDS+eC1tV7zs1JY= X-Google-Smtp-Source: AGHT+IH9CzyZmBVApG7N+ZEw636FiE9i07oBG0nCBOE6sQ50A3+ug0R3b3rY6Mdv5LgNbnlVIDVIGg== X-Received: by 2002:a17:907:d504:b0:ae0:b717:746b with SMTP id a640c23a62f3a-ae9ce2003demr758011366b.61.1752768376198; Thu, 17 Jul 2025 09:06:16 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:14f1:c189:9748:5e5a? ([2620:10d:c092:500::7:8a92]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e9118dsm1371641166b.21.2025.07.17.09.06.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 09:06:15 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 17:06:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 3/5] mm, thp: add bpf thp hook to determine thp reclaimer To: Yafang Shao , akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hannes@cmpxchg.org, gutierrez.asier@huawei-partners.com, willy@infradead.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org Cc: bpf@vger.kernel.org, linux-mm@kvack.org References: <20250608073516.22415-1-laoar.shao@gmail.com> <20250608073516.22415-4-laoar.shao@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250608073516.22415-4-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: y91siu5pkmsaf8364mrnp8fthufa1brw X-Rspam-User: X-Rspamd-Queue-Id: 4180540014 X-Rspamd-Server: rspam02 X-HE-Tag: 1752768378-628090 X-HE-Meta: U2FsdGVkX1+b4XH6xfgNyBikLVxHXW7qix1VDvGR4df1kLGHw8D5CaODFS3X57k5wlctas244sMtM/hO60dX3DAS6PRfYvkjad1yQGbV0XUtJzrw4DnTkj0y1m/KXFGiaIf0dPDP8gwIMoL3swkvCKIia3PN/D490NcoI78oYRghesgL1oXbnHU/QRv34LTB1x28UA0RZKURFBQLmQdw/4R5dEMYTONgHS6yNg7KZeVopSKartxr6YTW7zzGQ1LURRDu2N9ceJhQPIy4VJu1YeWs+onlB9Ki8j52ZkPma43vzt2C8AYkKsZ7yySpYriEDqg6z08G9Y5MAD8Rr+twuCez3+2IvHUaNd6aq6m7Y1aTC1+/beOs/JOg688EsVo1JQsypj91g+D6mr78hhdSWZqVbFR+QwGMPCLLc0HQaRacrpEueVlSQJKM3S16ixem6FP01Z37tQgglHkJYOAM3CRqBby6d99F8D5ML5BDKDxaeuZMCf5RU4xdPzGLTT8r3LYvHo6RHu7zdsw+KH9LfuhgczkO63RdVhVIzAIcT9ifHu15KP4Qlqj79rUZcwUIG2AAzyHTdiXJgqtXKnfeo2zLnXildtRKs0TWBJhVGiu22XIjm3cR8VloLfT4RYPFbwDieuH+oA5sR1z9tBKhEuH2qUX63kErrRpYmkD12zdraeh6HSJy1+mmpTtswxTOzu5Va89FmBpl/n5eSesfHySpchkiz+ItKqGjTdRBMrQc7i/fZdFFytwqP2Z8oXFT1C1qT4wuznvPvCUJ9u/SGTAYOaLOs5GyIMPxxKcChJg2Ph6qcwwR0oP/tIKhp4iy6mUEIOVhNqzBtuOsFeQ6wjdkyqA9HfFdm2PIGSFluknEmy1jSTjrc752jIF2DdV+0fW49DJghP0DykMG8bPqi4hmz6sS3Pu7Xwdbj/ZQVUkCL+nzGvA8fpCJPF5+YXV6TJoZxMwZ3T1x9x/tQhU fMTzO0oJ Y5cbFsr/r5oLizpawJszicjLfB68xxL5hfnGFVmFgOLJEOgjvLlFr8BU4H9RbiSSVLttV4Ck/Ls92Ee+V8xJ3ETh+ybirhL0JKIjlGHTqVp8kiqWUHmnmqXuGHsc2U3MbTFpC5fuQ3yqGNhuHJkBByMZ44w5/feB7WQ5pwmxm4QWhyiA2DwwExedZIdCEuMrkViFybj40QvPAzTlwLAjsuQfCuhytNz8D2Mk1wQ4JeHOAKW1Kk+sM4axDiouDvRBlEQWJdQh8ugyvJmcFUaagiAbSYMLNHTwoOjvpCS43MeY3Yzttpw/zfR6CHaG6D3IgAEUDMXA6vvvs6fNAnFazIB1iYuhUPH58pSnda7St2WK5Qv4QkqMPgsTaBpbLa1xna57q1nFYx/vYN78e8bPGOR0V5WgHEU1fGV0cxuKISVhWf19Nu+Rjo933IT59MBzUVn+VWDsPOx4mLS5hRdBNtGyeWJUgASs8cJ3t2Ig+ILQ98aV9r/T6s1tzZSZQ/CABwCArmA6kGzL/YaaP8oaf+iriEg8+UCltTJy/nJwUi+zJxDizPLyiC8fukzlDlj2GcrQMB9B2PsO2GyumP3ogG147hBqiTVTcpaeh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/06/2025 08:35, Yafang Shao wrote: > A new hook, bpf_thp_gfp_mask(), is introduced to determine whether memory > reclamation is being performed by the current task or by kswapd. > > Signed-off-by: Yafang Shao > --- > include/linux/huge_mm.h | 5 +++++ > mm/huge_memory.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index db2eadd3f65b..6a40ebf25f5c 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -198,6 +198,11 @@ static inline int bpf_thp_allocator(unsigned long vm_flags, > return THP_ALLOC_KHUGEPAGED | THP_ALLOC_CURRENT; > } > > +static inline gfp_t bpf_thp_gfp_mask(bool vma_madvised) > +{ > + return 0; > +} > + > static inline int highest_order(unsigned long orders) > { > return fls_long(orders) - 1; > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d3e66136e41a..81c1711d13fa 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1280,6 +1280,11 @@ static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf) > gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma) > { > const bool vma_madvised = vma && (vma->vm_flags & VM_HUGEPAGE); > + gfp_t gfp_mask; > + > + gfp_mask = bpf_thp_gfp_mask(vma_madvised); I am guessing bpf_thp_gfp_mask returns 0, as its something yet to be implemented, but I really dont understand what this patch is supposed to do. > + if (gfp_mask) > + return gfp_mask; > > /* Always do synchronous compaction */ > if (test_bit(TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, &transparent_hugepage_flags))