From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FF5C54FCB for ; Mon, 20 Apr 2020 13:58:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 97FC920724 for ; Mon, 20 Apr 2020 13:58:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R/JcZkwu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97FC920724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41A6E8E0006; Mon, 20 Apr 2020 09:58:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9218E0003; Mon, 20 Apr 2020 09:58:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 290BA8E0006; Mon, 20 Apr 2020 09:58:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 1216A8E0003 for ; Mon, 20 Apr 2020 09:58:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9EED5181AEF30 for ; Mon, 20 Apr 2020 13:57:59 +0000 (UTC) X-FDA: 76728387078.22.fifth39_b8513f116241 X-HE-Tag: fifth39_b8513f116241 X-Filterd-Recvd-Size: 7819 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 13:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pK26z2Uz8J+xMXGm08XY3fCeYfVumTWEKpq3I9uMJ70=; b=R/JcZkwu1B4ZzBZFN6dQVIKNfDHLF067dQ/VbM9oDV5t6uYbWvbtuqkJ9oMnkSb3C77v7t 1yPjEZDOHc00VQzqoNntmFnBvFO/HXlT5EDlCGiwLHrNXwGd/gcYA2HBJE1N6YCDVpaN8g mD6cuvyGnm1SBknkkG5Hn/NVkyctUqo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-hCJsvRFbNPWik1qsw7i1nQ-1; Mon, 20 Apr 2020 09:57:55 -0400 X-MC-Unique: hCJsvRFbNPWik1qsw7i1nQ-1 Received: by mail-wr1-f71.google.com with SMTP id x15so3711427wrn.0 for ; Mon, 20 Apr 2020 06:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pK26z2Uz8J+xMXGm08XY3fCeYfVumTWEKpq3I9uMJ70=; b=fwbjju+e4Pf0Y3m/XeUN4YXO0bNkFLWjMtUXfOqluvSHAdA/80FLjb41uXQ9ove8/6 SA5riPJNhCChbM8T7uN0UGSGEzlKvjhDgW3BT53JvHvvcJfPRkld9rLD3NE6dyHXqgLu QSnDXWJc+Ffd6BB5eFnV6CNZBwm2XbzCtClnEmUQvT24EqCwovxbRzb+5+uxAYQRYdRP A/5nFeQpJcdkv05gP93QwWs6eu4X+AJBmeCOV5/a5ke7TqFbguKB4QJ7e8jYJizd19cR thnP16OceEGH+XkSgh2gBNGihehoBRfmFMUmxf3ssT0iwrD8/j8TjlqU4LJaYb7qyESo Ubjw== X-Gm-Message-State: AGi0PuYTWmEQ0g1fig99E2YYFvebFcSXVjgaAzsMdLDv+oNKQwLaDQmi R/n7UVm2uXfr74gEFE4JvVS5zF8Gw1mNkXPak9lHIKPPbUdSYOOpCYhFR+P8dLCH7PK0bVfJsul AqzyOaDxJa0s= X-Received: by 2002:a7b:cf2b:: with SMTP id m11mr16860519wmg.147.1587391073787; Mon, 20 Apr 2020 06:57:53 -0700 (PDT) X-Google-Smtp-Source: APiQypKZBYixV5ajKWzxEAUUh742/WPOg+S3dMK8bDyvyM4eMw8EIY0hxy1C7QN16yJpeFB4fL8+FQ== X-Received: by 2002:a7b:cf2b:: with SMTP id m11mr16860432wmg.147.1587391073551; Mon, 20 Apr 2020 06:57:53 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.102]) by smtp.gmail.com with ESMTPSA id l5sm1432890wmi.22.2020.04.20.06.57.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 06:57:52 -0700 (PDT) From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 6/8] simplefs: add file creation functions To: Greg Kroah-Hartman Cc: linux-nfs@vger.kernel.org, Paolo Bonzini , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Robert Richter , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Alexander Viro , Ian Kent , Joel Becker , Christoph Hellwig , "Rafael J. Wysocki" , Matthew Garrett , Ard Biesheuvel , Miklos Szeredi , Mike Kravetz , Mark Fasheh , Joseph Qi , Alexey Dobriyan , Luis Chamberlain , Kees Cook , Iurii Zaikin , Anton Vorontsov , Colin Cross , Tony Luck , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Hugh Dickins , Andrew Morton , "J. Bruce Fields" , Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , James Morris , "Serge E. Hallyn" , John Johansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, oprofile-list@lists.sf.net, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200414124304.4470-1-eesposit@redhat.com> <20200414124304.4470-7-eesposit@redhat.com> <20200414125626.GC720679@kroah.com> Message-ID: Date: Mon, 20 Apr 2020 15:57:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200414125626.GC720679@kroah.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/20 2:56 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 02:43:00PM +0200, Emanuele Giuseppe Esposito wrote: >> A bunch of code is duplicated between debugfs and tracefs, unify it to the >> simplefs library. >> >> The code is very similar, except that dentry and inode creation are unified >> into a single function (unlike start_creating in debugfs and tracefs, which >> only takes care of dentries). This adds an output parameter to the creation >> functions, but pushes all error recovery into fs/simplefs.c. >> >> Signed-off-by: Emanuele Giuseppe Esposito >> --- >> fs/simplefs.c | 150 +++++++++++++++++++++++++++++++++++++++ >> include/linux/simplefs.h | 19 +++++ >> 2 files changed, 169 insertions(+) > > What's wrong with libfs, isn't that supposed to be for these types of > "common" filesystem interactions? > > Why create a whole "new" fs for this? I assume you meant a new file. These new functions are used only by a few filesystems, and I didn't want to include them in vmlinux unconditionally, so I introduced simplefs.c and CONFIG_SIMPLEFS instead of extending libfs.c. In this way only fs that need this code like debugfs and tracefs will load it. Thank you, Emanuele