From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A795EC02185 for ; Sat, 18 Jan 2025 18:36:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0CEE6B0082; Sat, 18 Jan 2025 13:36:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A91386B0083; Sat, 18 Jan 2025 13:36:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E3856B0085; Sat, 18 Jan 2025 13:36:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6F1B76B0082 for ; Sat, 18 Jan 2025 13:36:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E7ABF4624F for ; Sat, 18 Jan 2025 18:36:18 +0000 (UTC) X-FDA: 83021427636.12.B6B243B Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf04.hostedemail.com (Postfix) with ESMTP id BCBD140005 for ; Sat, 18 Jan 2025 18:36:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GVkmy+AO; dmarc=none; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737225376; a=rsa-sha256; cv=none; b=6uJeBdLAF2m4DLwUsMOZXx1rV5oy+AgxwoXiKEOomts/xhKSezpn7h0kyraz7ISpqVPPDd YS53Snz6fhS0UPxqpvQaCgqppSOdsd191P0XwXeV9gAKkXdU8n5QB5rZGPA+oShi0Dw5ND X78eeSP7j0aReZ4tUWdxtubjxM+tPB8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GVkmy+AO; dmarc=none; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737225376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUkm3O5VXWECV1np9LBwbOA6nOJYwN4Zdwn94mUHEP4=; b=zl2yvta8PsLaihs1vPCnNU8B+63nRSR+J7ptk9Yu37EWucfdbdNf8s2VoA2H6kA0PElJax zVozoKi5/T4kV/1Pf/TcN0ZPjNUT0QQeGBf4OJgfJoA3Rr6R7xbHmruqB8f5kgnEotHt/p 2LD+UeYxgFjSyWWHJWwai9FP6M8At8Y= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21669fd5c7cso57733005ad.3 for ; Sat, 18 Jan 2025 10:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737225375; x=1737830175; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=OUkm3O5VXWECV1np9LBwbOA6nOJYwN4Zdwn94mUHEP4=; b=GVkmy+AOLpdIJn2i8damNSFk3AtBBs5v6zXXudtrfs5/6mbQFW5OGR7MqXiHfgIvdM 4acFomyZ6HEC9yFV5TZjA1O5dOqkTm5cpLlfDjGnCPGSeWvxkYLVbLbugMDi4zRw7zqd FHi9rYLUtlq7keeGectKhkjejBRN91WgXNUU8+xkurn9YUwd/xOe5etXnc2x60zEV+uo +HhYzJu25QbHl3VEiVTCKiRY8PsAh/g7RHHTS1EGuBRYnu0uf2XnrSVedF5PbCp+kreC yDkAhmdpFiAojoWqGVHI5Hsws8b/fHLw24fHZe4XX4hvU5EZw+hyuQjhxWcVN6/vKxwP liAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737225375; x=1737830175; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OUkm3O5VXWECV1np9LBwbOA6nOJYwN4Zdwn94mUHEP4=; b=CgMZQPTYBbZ6YwIrO4fV6hrzNx23XwhybYYZShuVgf1lAd+Uzh/ltbMMCHSmJI391O YTp82DL7o+mlOm0paS4/HuJu+k+o8rrXB2PMO/m1/FQilXPYQmjyfaaeZ8j8hM+dc2Zi 6m1usmOrddB0SLg6QZWS6nFuuwq3LI5xbBZ7dQn0ns1+NbTyqzJO+Hktxm2Aorh0Jnse Bc3BqjU01+gqQwqqH9eNtci+s/R+u/+Vpl5FSSuCh6zRsUv+9MU7bjdKXrJAMky7h2I8 Aj2KYqufF+0dk6+9EE9y/OkxTgMGbFefdqncMfRcmEsdR+ITSQRiZCMvzhfrV5P3tX5x QNHg== X-Forwarded-Encrypted: i=1; AJvYcCVSDObcoJpwNrOjON674/g0F/rS+BY5jWBKo7sJDb5YAbPSKLxZOVOkuTBdGIZgm82dMuKOmuSa0A==@kvack.org X-Gm-Message-State: AOJu0Yw/YmhSnVWY3bHNO7xJVQpPpb1aF3OcGkv9xcLYccm4zdl+x6Uh HKfV545h1MB8f8GXr7eF1Y5Ni0TsCJeam7ek2xxN+ATptdKcOCjQ X-Gm-Gg: ASbGncstoAa1vTidvKseLsX4Ily/eQ2+zLOePklAjZm9V5rmo6bF85w/h2rrBRp5Gq+ ksVAPOctSTLH5YJm0NpJLOQjH1K0cX60PCz0eR81ZLjAahId2kKZdLPFNkjv4cxJMrmbVMtTH/P 6sl10nD5bAFgv2vaUQYWSRDuOn8M7juwc/rEGmRz2nVs6foDfkEKb/kFFq/Q7AAvM74vXlm3JS5 6HDY6c11EySvjqCixzVRTIA6rSLtQY0xJ8Mc6plOVQ674L3hxNvzTKZWBfoE+GHrsGtPMVLNESs ash+MxefMGUl4asX0o5NcJmbf+dOmc7rMIp3dwIJvbA= X-Google-Smtp-Source: AGHT+IFvMhIT4I2uX6aqedtotZAF2akdbJK4GaZEVBZp4csKoRpE4kZS3khyNby3PJHrspUSH/Y53w== X-Received: by 2002:a05:6a20:2589:b0:1e1:9662:a6f2 with SMTP id adf61e73a8af0-1eb215ded51mr12411392637.35.1737225375282; Sat, 18 Jan 2025 10:36:15 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab813295sm4012547b3a.46.2025.01.18.10.36.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2025 10:36:14 -0800 (PST) Message-ID: Date: Sat, 18 Jan 2025 10:36:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Buiild error in i915/xe To: David Laight Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> <20250118180916.433bb73c@pumpkin> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20250118180916.433bb73c@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BCBD140005 X-Stat-Signature: dpr9nz4ab36ag98g89ha1sh4rxyqsi4e X-Rspam-User: X-HE-Tag: 1737225376-725945 X-HE-Meta: U2FsdGVkX19ik9agCRNyd5CHh1T+01Hf9n5IxDqArwSyqw3TQwNsqawG96NuC1tOXup2Dqn2C6hIfuFv9ITymdcNZ0wVhz5dn/Ah52mOMcYmkW7R7e5IpYUGXUlcxj96F/OiCGt0kSq3JOnth4E96RsFnzyB7WjHDnS7a0MegSB3d7Ovne68+5bK7UUtrfNls1UNxbP4uPeJThaZOnfoKbj7te1kvm5bVrWZGknbLXFRb9RKdu5/iAD0ohWeDD1YhpVYw61VaqlHusDe3Hatu3oWXeFK/2wzv76S50J2hKCPxemGwRYfd6ZsgXn1BSnVuHRAWKSLGG+Epbt+IN1NUCMKMgYjA12GHmYmXyoi0n4u+5BSlWSCEjrrWOVsEbI/BBYPv10QbUX/qeWHwhogzPYGP+Z/ZbKFp7Tyld+ZMG38bTRm2Fq4iq9PkEhKf+qu96RF5jsDWWCLQDbqVxA+YDjz90nZXiUqZM4R6L7Q2nsPs5FNQp7zRuh7M5YLwLLwObgz02TlArJXd1nm8bDRkjwfHMX4eicYc55uvJbxe26ZzXdq0AvTP2Pg6innxuXXfkRsqQyR5yCp4fdK1WCCvMycRGOCDsdupxmqRfXAG//mJkNFYfnRgP2j+LarfymgV7a9u58mc/ldyRk7C9u3m+G6pBbb9N9O0SW2Pz5CIP2QnFqXk9vCk0SDpx6h3T36bLpvFJ2oJHxRcLKw8cBrvQuAxwQxBU53cuMYCHS4j3/AWaF0W/cKbfS+hGt0Rrdbha6FmORlzFekSwxwSYFMQ7WvdsS6G1jv/LpLgRPKiQTBg2bE73lS2N5CvB+WwWz3XTEpMMR+4dzzHkxM010Jl4W7G1iQ1vACXBZt5G5XgaXvUT9PiV5ry3oEY9ElPBoIT3BHsXeMBgAwdmSOsRtIB3mXlv2nMrZjHdlOwE6bR2/AbBvz7ytzEMJsv1MQNfVaKrS21gIaA2qIhtERKQp Dvfef+Xx BnUq2YscFqxdIzG6HP5sZh7ZYBsAr/W53k+yYEB8YTNCZeNbOZrxA1HvsdCYrYnqU4Elmgc7xUrP59OQ3mcHN62DA4B2GlbY6WiqHP90e8DaNM933aZ5MAiZW3TdlY+kDruafH4E+3B4mZdXbieOBnRN3u+RCJP3Zf3+a76CbiVNxlp+ttkaLPxBMIn3j0zE/o4DqTy5n9IoZ+2C95qYN9u5wwj4ODGVpWCd9EQ9/TKZdYh9iuEYRxJu6F+29075gJnqeBqyFMIISv7LCqJbwABtavTyJH3xrrzw8ePl4bcIazxMw3DrAJDdnJrd2NyU1n2nAhmrAe8DB0j3VJTHyWq7L9ryxNMo3931cpiLbUHvs86zn3LQ7iUSqlLMVjMv+zj/+1rNHIBAolAe5/NikdiIHa8+xsUV1EBqtSsPEgSNp9DONFhWfsza/FptEruXCKEqHdTj260/Nxe/Jti0+vmfnV0gQV2O4njQY3dpWeOYZqOud5BfkqMrOesB1L6MErH8VDxYK+qF1/0r59WyEGDjMNskapKBPSuTUaLCUQCzNa3bhdpTzx1Ca4bZ3BM9XMm2S+C8yXdevEgQeVX1MvOTZ4SnT4RFSY2aX5n3XG4RRHHQq8vbQLZhnAPn45FcIOaYx20lEEODCXXk9bsVzKKrY4mHnl4tDM+OG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/18/25 10:09, David Laight wrote: > On Sat, 18 Jan 2025 09:49:21 -0800 > Guenter Roeck wrote: > >> On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: >>> On Sat, 18 Jan 2025 08:13:06 -0800 >>> Guenter Roeck wrote: >>> >>>> Hi, >>>> >>>> On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: >>>>> Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity >>>>> check of the bounds in clamp(). >>>>> Gives better error coverage and one less expansion of the arguments. >>>>> >>>>> Signed-off-by: David Laight >>>> >>>> This patch triggers a build error when trying to build parisc:allmodconfig. >>>> See error message and bisect log below. >>>> >>>> I don't think there is anything wrong with the patch. The underlying >>>> problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which >>>> tries to build the affected file even though CONFIG_DRM_I915 is not >>>> enabled/supported on parisc. >>> >>> This has appeared before. >>> Any idea which inlined copy of scale() is causing the problem. >>> On the face of it they all look ok. >>> >>> If you can reproduce it maybe try commenting out some of the calls. >>> >> >> See diff below. All three changes are needed. >> No idea why the compiler would know that the values are invalid. > > Maybe it isn't even an inlining issue. > Perhaps that compiler just doesn't like the function ? > What happens without the 'static' (and an extra prototype)? > You mean like that ? -static u32 scale(u32 source_val, + +u32 scale(u32 source_val, + u32 source_min, u32 source_max, + u32 target_min, u32 target_max); + +u32 scale(u32 source_val, u32 source_min, u32 source_max, u32 target_min, u32 target_max) It doesn't help. Worse, after that change the error is still reported even with the #if 0 elsewhere. Guenter