From: David Hildenbrand <david@redhat.com>
To: Ye Liu <ye.liu@linux.dev>,
akpm@linux-foundation.org, nao.horiguchi@gmail.com,
linmiaohe@huawei.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz,
liuye@kylinos.cn
Subject: Re: [PATCH v3] mm/rmap: rename page__anon_vma to anon_vma for consistency
Date: Mon, 21 Apr 2025 09:20:01 +0200 [thread overview]
Message-ID: <f345f393-9715-4d4a-ad1f-19a30dc3d7ef@redhat.com> (raw)
In-Reply-To: <20250421015823.32009-1-ye.liu@linux.dev>
On 21.04.25 03:58, Ye Liu wrote:
> From: Ye Liu <liuye@kylinos.cn>
>
> Renamed local variable page__anon_vma in page_address_in_vma() to
> anon_vma. The previous naming convention of using double underscores
> (__) is unnecessary and inconsistent with typical kernel style, which uses
> single underscores to denote local variables. Also updated comments to
> reflect the new variable name.
>
> Functionality unchanged.
>
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
>
> Changes in v3:
> - Rename variable from page_anon_vma to anon_vma.
> ---
Agreed to Lorenzo's comments ... tearing up patch sets is tricky :)
Patch content LGTM
Acked-by: David Hildenbrand <david@redhat.com>
Thanks!
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-04-21 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 1:58 Ye Liu
2025-04-21 6:03 ` Lorenzo Stoakes
2025-04-21 9:11 ` Ye Liu
2025-04-21 11:21 ` Lorenzo Stoakes
2025-04-21 7:20 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f345f393-9715-4d4a-ad1f-19a30dc3d7ef@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=lorenzo.stoakes@oracle.com \
--cc=nao.horiguchi@gmail.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox