From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EC8C7EE2C for ; Thu, 25 May 2023 10:02:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A4726B0074; Thu, 25 May 2023 06:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02D696B0075; Thu, 25 May 2023 06:02:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0FC0900002; Thu, 25 May 2023 06:02:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CB90C6B0074 for ; Thu, 25 May 2023 06:02:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 924FEC0B23 for ; Thu, 25 May 2023 10:02:06 +0000 (UTC) X-FDA: 80828336652.23.0F4EC9D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 0E157400DF for ; Thu, 25 May 2023 10:01:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uGYVCAfP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xHn03riz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685008882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fcaGKeQO8rFxxr202sw2vP0gVAY2NAJ8aoAl4iO6eiI=; b=M/PoLt9wkqmb6zmB+Ga9oHjrOFGTEMqy+tCuEf+hLDFiwB1y5T9p1illl5iJ23Kv5cxHDE 56bWUIdYp2B2V6b+yL4f5pDWkjbVJF4uljv02hpL92neOexuL+uAOTD1pqcEBCF7Lkv9gd 46oA+n2UPkR2rOU3hAj2bswa/DOWCu0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uGYVCAfP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xHn03riz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685008882; a=rsa-sha256; cv=none; b=S0qne+uTUbyocJYhaMaVMxIDraPJDvYz3WKb7FlAJZClFPlU7AUuXNhnQQHQML4a3mimNb F5KHPRIiaf/JzNxs56aFYvHQf2oW4es9CSveOeBFPdkFnMn5TLN7ymvzw1pu83wsZpNbTa Qq/3JgN4VgIbJcBYNwo5LtJ64sWOPHU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0857C1FDFA; Thu, 25 May 2023 10:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685008879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcaGKeQO8rFxxr202sw2vP0gVAY2NAJ8aoAl4iO6eiI=; b=uGYVCAfPehPquyJjUbhiNx6V2txpsmHSFI7n7xb3M5TKZNcnPJnKCNj49Qb0iJCBoeMyvd +4bFUtcHfKSo2Y96UG3nBtg5CYW0cd9XFMskVrzXKaWXLcXT3KUmYCI5DatMUnR+J/EXLP xUcxqL8nkaDDrzP1qbmZbzqvZf2z1Po= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685008879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fcaGKeQO8rFxxr202sw2vP0gVAY2NAJ8aoAl4iO6eiI=; b=xHn03rizVaTYNSQR8imtdC59I4GxgRM+Cy34s73SQeURU+gjTHropE/JX3tAmNFhBkD9Zl GproTgmgWXguoODg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D8C85134B2; Thu, 25 May 2023 10:01:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ycNJNO4xb2S3bQAAMHmgww (envelope-from ); Thu, 25 May 2023 10:01:18 +0000 Message-ID: Date: Thu, 25 May 2023 12:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/4] mm: compaction: Only force pageblock scan completion when skip hints are obeyed Content-Language: en-US To: Mel Gorman Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML References: <20230515113344.6869-1-mgorman@techsingularity.net> <20230515113344.6869-3-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20230515113344.6869-3-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0E157400DF X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oh86xjmbqt55fp9ejikq9yqpatgc98y3 X-HE-Tag: 1685008880-613887 X-HE-Meta: U2FsdGVkX19tTq/krkdbL/HFml3QTGLDXTXy1Es74K8cdQbb1uxNDSv8cp3rXatia7c+mIthiYDRE/7ydd+fBNXXuitJ9iAcHhJ4Gw6goHResrxnjDPsU/PnhELUEwIVyQw5Hm1ZwtBrS54X1s3eD65urF18+vOf8iN4wTqHuQ4052Wkl/s94WxvFI3mDwWdp7QZehLTMJd1je55473XFSsG65/4oCTvKnrIh8OghJsIBqFNy6e6/xB9YrRIzUmbnLUSPoxnqbrS17QjIaQ55ILMtTdI1vxJZ3SH4h+6bExeDu/YLM53BGXStB4Mx+UzeiLDUPpVD1UpzF5mjUTP8S3X2vhxW4ex+7XqqJ65DGHB36qwWSkcUdnHSOIGjd9wStINEbPoI32jgQAceazCdiWdVO66ji3Gqg1MSa1IPIG/HUE/LSYD0xlpFWq7e2YH97RMY5c3rp5mPNxHCPtTwYibETFFCibEdshnvUYbHZWFzy+u5t+ehd6nq9kREeWFk6zsDEQlyiLGtcoApboT7RaxI6bmH48l4/923rDYPYH7djeAIA6Fs5/fnUakN+oQf5G6aj7OOhkz9OJYRDqbpZjanPtmoMtbr+tIEkwR4F1CcK2cwtG3OmLWkuPqlGSOn/OdqksjYxwlQ2hrfTqQ2kjAB9zyTqNcAUmyZOeDgzLOfMfWA96EUg8n6KtnAkMRM48Z2x/3yqDK4UKZT6ia2ZGbbts+N9wtjq0rCLonH1YYG7mF8ffUaWb3F/D4xdZJPRCg/BtvZ3sR2ZwpkH7r/s64K2PYjnS/YiQYTrUn9LrIXXrIpkp3FueYxpthOCqc3agTR+vTYfVH4k+hn7JOsABgG32J788tKzHZrrqIsxiuFhW3wnn58YYoEXvWdn7dwMxYThMDYYvg69p+prqgm23JislxZRj+8EYl+3Kuoy9CCH+GGBRPRdvJnrZSUChkkns2cXgIcXDHMXsm7DL pxsNM4LF SqJnfjz46vHIn/rHJG8Ll37LhsQ0RLsY7/UKNQif5mg4GXjZqr4K+x1LRX4/Fo8f4mXpzt1IoR3ks7f2MUL8qF0Rz6Gq1IwGFVLA+gWe1RV/uvoQqTL9HvemqYz/om4AsUm8Fy06DRh0SApF/aLgziwqIZyiJCe4G9O428Wru2YN0H9RVMxd/jVB6wCFmOrAbVDcTzVBcU54m+Z4+1VaqQUCSmutBCnc6w8r3xeSevVFhJU5oqUFwYRBAgd7t0PYn/iRDHA0urZJPQoMhfs2O7xCLO1AAHKR5umR6DvtOUWniNHqOLvy+PCwgtoRs00lwoLsE9g1lY8CkpwM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/15/23 13:33, Mel Gorman wrote: > fast_find_migrateblock relies on skip hints to avoid rescanning a recently > selected pageblock but compact_zone() only forces the pageblock scan > completion to set the skip hint if in direct compaction. While this > prevents direct compaction repeatedly scanning a subset of blocks due > to fast_find_migrateblock(), it does not prevent proactive compaction, > node compaction and kcompactd encountering the same problem described > in commit cfccd2e63e7e ("mm, compaction: finish pageblocks on complete > migration failure"). > > Force the scan completion of a pageblock to set the skip hint if skip > hints are obeyed to prevent fast_find_migrateblock() repeatedly selecting > a subset of pageblocks. > > Suggested-by: Vlastimil Babka > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/compaction.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 81791c124bb8..accc6568091a 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2456,7 +2456,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > } > /* > * If an ASYNC or SYNC_LIGHT fails to migrate a page > - * within the current order-aligned block, scan the > + * within the current order-aligned block and > + * fast_find_migrateblock may be used then scan the > * remainder of the pageblock. This will mark the > * pageblock "skip" to avoid rescanning in the near > * future. This will isolate more pages than necessary > @@ -2465,7 +2466,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > * recently partially scanned. > */ > if (!pageblock_aligned(cc->migrate_pfn) && > - cc->direct_compaction && !cc->finish_pageblock && > + !cc->ignore_skip_hint && !cc->finish_pageblock && > (cc->mode < MIGRATE_SYNC)) { > cc->finish_pageblock = true; >