From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F6DCA0ED3 for ; Wed, 4 Sep 2024 09:05:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6B8D6B0388; Wed, 4 Sep 2024 05:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1ACF6B0389; Wed, 4 Sep 2024 05:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B957F6B038A; Wed, 4 Sep 2024 05:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9953D6B0388 for ; Wed, 4 Sep 2024 05:05:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33A1712063B for ; Wed, 4 Sep 2024 09:05:48 +0000 (UTC) X-FDA: 82526473176.16.0763349 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 920B212000C for ; Wed, 4 Sep 2024 09:05:45 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2gPuHFl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jCs5uxyf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvBHcvp2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v6rblfYD; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725440619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TYZWCq59RBY717M+LjQXIQTkI3xeZCPBTWNYganGX0Y=; b=s8P70dvWo/5SYEdEz6szg2o++E4+BxYvdCJdxeBgC0WSPfTWR0PQLFbnl0oOmrIX47beP7 /5SPxKt3f4oL1D5E7Vz7mNQKA/0pQQx1vbY+Yq+dky4gU8Zqm6Vnd8gipBw6lL0PnLUXdr uj9qmIiseTN9b3bMjHnXHQUE6/03Ub4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2gPuHFl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jCs5uxyf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HvBHcvp2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=v6rblfYD; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725440619; a=rsa-sha256; cv=none; b=H7Ua94PVAYgryq8WGO+vIfMot1yDj+MyKGERArogOwWzXzNyg2WMiYA0EM0pfvaqhZ5rjs PeumvsclOC8YZw/ga7h6jFki09lfGnV9bNFuBnQmtAY+jjwqsE7Iun2wwUBqYRGuXjYN4O 5APBD4A0YpzCK+Kwmg2bzjUWKePnBeA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DB4D21F7AF; Wed, 4 Sep 2024 09:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725440744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TYZWCq59RBY717M+LjQXIQTkI3xeZCPBTWNYganGX0Y=; b=R2gPuHFlw9YvEVv6BUS5BAbYjJqsfIByQ7iPDHbEtCbP2grNE0WF3pXusb0D/qb3DKnfbx oAPWI9Bgv7Xl/G78nteoqwk3ccAwyyIR9DaNDRax1ch/XCdRrs0KKY4gsWvTdzZdT0t3zL 2cl2Go+Sje/rLBI6/9MmFnVXgwH49o4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725440744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TYZWCq59RBY717M+LjQXIQTkI3xeZCPBTWNYganGX0Y=; b=jCs5uxyfFaNniK4VmEo2dlTPGDGdTyBYlmc71V4OczPS9Je3+BYKV4Q9k9ep0T7mtTDvE1 ownpH1PcUCw7x6Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725440743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TYZWCq59RBY717M+LjQXIQTkI3xeZCPBTWNYganGX0Y=; b=HvBHcvp2Lm9h3bHF7IZHE/n8SpIpYV/l3IabNTJ0WjoQEjqqlpPOyXcGaaEHAx8ZQ/lceu Z/n/JtA+021exkXWAoBACLobWrPHNCSGQvnDMclmjduned2moIuk7S5Aqv7FR3d/w3l+mI rTDx3E1QKQozE383Jz2uK7tM5akjfVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725440743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TYZWCq59RBY717M+LjQXIQTkI3xeZCPBTWNYganGX0Y=; b=v6rblfYDJcEXRys+kEQzTVnm7hrT5YgpNH4Fuao1eBxefQaIwBXwQgzMLKigrtPxKPcJQL /15GxGa7Z6bA5QDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C4D50139E2; Wed, 4 Sep 2024 09:05:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WMFkL+ci2GaZDgAAD6G6ig (envelope-from ); Wed, 04 Sep 2024 09:05:43 +0000 Message-ID: Date: Wed, 4 Sep 2024 11:05:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/15] slab: add struct kmem_cache_args Content-Language: en-US To: Christian Brauner Cc: Jens Axboe , Jann Horn , Linus Torvalds , Mike Rapoport , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <8d8da7d3-5a8f-4c79-84d2-90535324cdcd@suse.cz> <20240904-stauraum-kennst-5769fa810706@brauner> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240904-stauraum-kennst-5769fa810706@brauner> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 920B212000C X-Stat-Signature: re5jr6meugrrym3k7ozhz4b4568fnodn X-Rspam-User: X-HE-Tag: 1725440745-878717 X-HE-Meta: U2FsdGVkX1/OTrg2AmK33LL7C4CQD8YH+BxFQcWMBdCgm26O/1cgBg7godgmmwO6D3tgNYip/jLGy+SWi3vRAGsfb8VBaBeDbdiC8BHOm/L3nqW5B5qZwKj3LkAKkjtcjD9u5hzb8z2hgZbSj3QUSu5tWAAYDIAxMSPwjwzMd2LGrODSd2rv/iXCCFK6NpMqcb2sj5MT7XKDusas3Fp0XaAqk1aIG5SYKQXUhB3mCju/mpZi9jGLwgYZYwnHAqWgETmR/2OraduFc8Z3G+7XI1ueioc9R1SOvi1lK1upzYDDPK0QKUB0R06baagMT2+NZPT3e/4vtrMO4iNlbOG1r0Q5k03z0ag4zhJoWNuV/pq/hl784Xl2I9LZglKT1dqeMQK3Nax+33FE1LoPNTaXdVfAK68Htar0EwlXsL+RbtbiwDZ9yG8PqWskL4g9Cujc1tBw7mX6OmRDXzJDr/Qjm2H3ZO64LdylvuZprKXF/QK5HYSWEt8X+NFL4QEdpCspqlNGBc7kBh3+6kjit+opEsgVrjF1bV/Kr+rcTF7BxNtXoOsrDeDhqOGuIHd9tec0pT5x0JUBl9w4/jWlD2k48Gm1OvsLs8ZpFTSofUtqwozbJP3wAhEXH5HtZZPnd7PTR7Hq10IqTYO5TqvOuj87JiWvHe69/YCHcxDBp0KpSVpOUJTs75QYTP4zCcQsbRnRZP6RqVcbKqWP+w6AmxbH4XL53oB2LONMjW6WvGwE5BUddrcnSrDSZngMq7kTovz/XPwTFKIQXhB8wtID8rTkFKNCza/BLL+MiEaHE0gxtkVCT+OYIFwsxAUZvX6VIRIk9YDQW84lXnhgtuVTJKqhuINxGt4sA3kJcm1xG2tUyJ1niRuYnIYa2Xi1E3VyC3tGlmVtC1AOafLLv5cWzTT3g7PXC4I8I6erQwTCOoHDZ4uThDfwCwYpWxX63miwENlq3bn1tUFt+dNC6qN5Xdn 1xjL3EMd 8XbtNydDehSBKj18W2oWeVKUbvg2TiZJyRdXvR62UfnFCpFmREJGXNc0fYdV1528vtse9LfrUb6xcZzLYQE+CqGoc6bUrDefyOb/Yehh/74Xxi9tGlodVSxh43iPsx0a9Hh22zIyh3RPtqfxZg20eW7PHTzSA3jsmHJAitsgbTnEsy87S2OS3GhiR0++KUYTkIBZ/BvpNBOLqV6+Gif7hJMClEud+Qx/ItOLuXoUbksu9Uc0QJAf/HU7PUtWHCq7aDTfGy1HZ4b5riDJxhknMHBrw9ZJzZ4wPmYn3Tx3Rx4tT6itnk8+AIB/1Z/NIrK8u/bjEzz1P7oa4iTi/U4MQpoqkcC4+N3E7VA054UQvzrKB9z4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 10:42, Christian Brauner wrote: > On Wed, Sep 04, 2024 at 10:25:32AM GMT, Vlastimil Babka wrote: >> On 9/3/24 16:20, Christian Brauner wrote: >> > Hey, >> > >> > As discussed last week the various kmem_cache_*() functions should be >> > replaced by a unified function that is based around a struct, with only >> > the basic parameters passed separately. >> > >> > Vlastimil already said that he would like to keep core parameters out >> > of the struct: name, object size, and flags. I personally don't care >> > much and would not object to moving everything into the struct but >> > that's a matter of taste and I yield that decision power to the >> > maintainer. >> > >> > In the first version I pointed out that the choice of name is somewhat >> > forced as kmem_cache_create() is taken and the only way to reuse it >> > would be to replace all users in one go. Or to do a global >> > sed/kmem_cache_create()/kmem_cache_create2()/g. And then introduce >> > kmem_cache_setup(). That doesn't strike me as a viable option. >> > >> > If we really cared about the *_create() suffix then an alternative might >> > be to do a sed/kmem_cache_setup()/kmem_cache_create()/g after every user >> > in the kernel is ported. I honestly don't think that's worth it but I >> > wanted to at least mention it to highlight the fact that this might lead >> > to a naming compromise. >> > >> > However, I came up with an alternative using _Generic() to create a >> > compatibility layer that will call the correct variant of >> > kmem_cache_create() depending on whether struct kmem_cache_args is >> > passed or not. That compatibility layer can stay in place until we >> > updated all calls to be based on struct kmem_cache_args. >> > >> > From a cursory grep (and not excluding Documentation mentions) we will >> > have to replace 44 kmem_cache_create_usercopy() calls and about 463 >> > kmem_cache_create() calls which makes for a bit above 500 calls to port >> > to kmem_cache_setup(). That'll probably be good work for people getting >> > into kernel development. >> > >> > Signed-off-by: Christian Brauner >> >> Besides the nits I replied to individual patches, LGTM and thanks for doing >> the work. You could add to all: >> >> Reviewed-by: Vlastimil Babka >> >> Too bad it's quite late for 6.12, right? It would have to be vfs tree anyway >> for that due to the kmem_cache_create_rcu() prerequisities. Otherwise I can > > Imho, we can do it and Linus can always just tell us to go away and wait > for v6.13. But if you prefer to wait that's fine for me too. Right, we can try. Maybe there's rc8 anyway due to conferences overlapping with merge window otherwise, so there's more soak time in -next possible. > And I don't even need to take it all through the vfs tree. I mean, I'm > happy to do it but the vfs.file branch in it's current form is stable. > So you could just > > git pull -S --no-ff git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs vfs.file > > and note in the merge message that you're bringing in the branch as > prerequisites for the rework and then pull this series in. OK I'll do that with a v3! Thanks. > My pull requests will go out latest on Friday before the final release. > If Linus merges it you can just send yours after. > >> handle it in the slab tree after the merge window, for 6.13. >> >> Also for any more postings please Cc the SLAB ALLOCATOR section, only a >> small subset of that is completely MIA :) > > Sure.