From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480D6D2FFF9 for ; Fri, 18 Oct 2024 11:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C335C6B0085; Fri, 18 Oct 2024 07:57:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3766B0088; Fri, 18 Oct 2024 07:57:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAAC36B0089; Fri, 18 Oct 2024 07:57:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D6C56B0085 for ; Fri, 18 Oct 2024 07:57:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ECE3F12058B for ; Fri, 18 Oct 2024 11:57:04 +0000 (UTC) X-FDA: 82686572136.30.3337EDA Received: from frasgout11.his.huawei.com (frasgout11.his.huawei.com [14.137.139.23]) by imf01.hostedemail.com (Postfix) with ESMTP id EAA1540019 for ; Fri, 18 Oct 2024 11:56:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of roberto.sassu@huaweicloud.com designates 14.137.139.23 as permitted sender) smtp.mailfrom=roberto.sassu@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729252559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t54zLLccz62J9jiqXr0DHgwzXxXcHCFd0h6cd6qfgRk=; b=2tHrOh+RCe5QJ5BcGYPGYwi/uf9kKpPUvHLhPmavaVRA7+lRWeWCtpreTXCil9ssI4lxCB I356i5t7YL4w9lGatmURwwHVPkrbMyC19BXqqVy6Uwy5WDG5XPocOPW1L3d27bkjaJSXam FTJ2PgF+iw3qw8Bv+GYF3G5kvK3vVDY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of roberto.sassu@huaweicloud.com designates 14.137.139.23 as permitted sender) smtp.mailfrom=roberto.sassu@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729252559; a=rsa-sha256; cv=none; b=SoIl5lw2f8CIHTnf0Vu85hP4MyZyGy7rV4w1OHyd3wIN5Ap6WP7IAFganB8+iUiCPS9Ba5 tl4qvaVtaL4+A11P9bLxVkoUZQ7HR0c9FcsqloII9QUQjprBSRTDitQamkF3EXcJFZy5zR VLxUB9G0x2Q0CXrFk2DuJ0NH9nXR9Ek= Received: from mail.maildlp.com (unknown [172.18.186.29]) by frasgout11.his.huawei.com (SkyGuard) with ESMTP id 4XVN2k0BjMz9v7Hp for ; Fri, 18 Oct 2024 19:36:46 +0800 (CST) Received: from mail02.huawei.com (unknown [7.182.16.47]) by mail.maildlp.com (Postfix) with ESMTP id 9125C140380 for ; Fri, 18 Oct 2024 19:56:55 +0800 (CST) Received: from [127.0.0.1] (unknown [10.204.63.22]) by APP1 (Coremail) with SMTP id LxC2BwCnNi77TBJngFAXAw--.53565S2; Fri, 18 Oct 2024 12:56:55 +0100 (CET) Message-ID: Subject: Re: [PATCH 1/3] ima: Remove inode lock From: Roberto Sassu To: "Kirill A. Shutemov" Cc: Lorenzo Stoakes , Paul Moore , ebpqwerty472123@gmail.com, kirill.shutemov@linux.intel.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, jmorris@namei.org, serge@hallyn.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Roberto Sassu , linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, linux-fsdevel@vger.kernel.org, Liam Howlett , Jann Horn Date: Fri, 18 Oct 2024 13:56:39 +0200 In-Reply-To: References: <7358f12d852964d9209492e337d33b8880234b74.camel@huaweicloud.com> <593282dbc9f48673c8f3b8e0f28e100f34141115.camel@huaweicloud.com> <15bb94a306d3432de55c0a12f29e7ed2b5fa3ba1.camel@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-CM-TRANSID:LxC2BwCnNi77TBJngFAXAw--.53565S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw4UCrykCr1xCrW8Gw47twb_yoW8CFy7pF y8J3WDCF4jvrnrJr1qgw13Krnxt3yUKF1UWryrXryjy3WqvF13Gr4rGFWUu3Z5Jr1kCryr Za1UJa9xCFy5JFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AF wI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUIa 0PDUUUU X-CM-SenderInfo: purev21wro2thvvxqx5xdzvxpfor3voofrz/1tbiAQAABGcRw-kIdAACs3 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: EAA1540019 X-Stat-Signature: pq4ppe3x5xx53cpkwqm11r6xmjzjor5e X-HE-Tag: 1729252618-861902 X-HE-Meta: U2FsdGVkX19ZF/QuaEormR08WrNfED3LvitKa8K21DNHAOy6TRkb8kZJM1nivZEHv1zx1oHUbojILyTnh3J6iOSCGv24GfZu5zqGIg74fwd+gQcrRtTJHaWup1LYjmq/cJCWSSKmYbU8029Q4POEAIaYtfHCZKo+Bs7I5VwP7YyWuSlJGv85VzTpzd2/BlwqQdmDpNdqVLeMBL+kQCxlOkfOIgCZTdSas5F3xO/WNNbB/Gm/bxKbgiz/8y28d8gHk3sT5iXzfDSEOsvQ5Iida+N6pXtK4r/amF+lnhazTSYnp7pbPkkwnDKJRjLodcRqkYiMAFrbXF/FUTmnRGNVp+5XQIY2AqWCICHjzf3jQ0mWY4YsiEY512KqoKm1xYZimcXMUbEa6sPa+eRkJGaKP6jMxUozIjUJ/dQldO1T+Mc3Xk0GTaFuRbXJvT3CDTQ4kPSDag3X+GVDD616QwI6GzL+T8AvO6sStEDBe9ZmEgQIq21rab5aVKawauv+WMQh8HCkrUvBLnNa2snoEKBb1ryFzBAPXIA9tjvbs9j3EnVCuv3clnkTrJukbJYVwQ0OWC2HjA6vDm2/Qjvs58B2CTp+qNkwKMi0yQjnVa9VqBR23eGyE8KvyLDZUtDT4yYcQAR3b0oeAYxEWw7pbpkfBmBzzH7ImXleEVkURju5jd59pLDw9SJj93lEzVavGM1VWc2T5+JnkidKvagtWhH23UYblgeZIg3WHZhK5dD1uwQpVERklHnvT9DngAPTYvyTfdAoxKhlEs3PXmAPKpvoAH5fhn3LsU2TG9Ymtw8pK6Us3pdOvH8AOBkVI12YxREjXR673XDXKmu0r63g64Gwgxsz71+Ot8KF6j57y88jw2zMXE/q5gvS4UFkz6v87cfs86SsDnsP95wbBpuNT2u5e26e8tCDA3DlB6cQFyYgImMEshVhz/5G1M2yH+BJil6U5j81gFHWtIMV512zLAv qf0J6720 K0eGrgE5kuzEXvygoKAq/oLbD/pCVdz8/xvQblIyjLbd9JJlPMJEWVf5eUOM8UZWbJ0rcTkwwUCNBayeoEk5+Jus1X3LYU/9QVDLjsbnIl6k1X8WzlPVKn3goTI24yo8szFcPb5bKgIHWQRtOVJ284dikdjyRW/UGVKDonKxqE1F7qRv2nu65qmr6pyh9Lp1+Y144totYziQLDws35L1aq/Lpug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-10-18 at 14:54 +0300, Kirill A. Shutemov wrote: > On Fri, Oct 18, 2024 at 01:22:35PM +0200, Roberto Sassu wrote: > > On Fri, 2024-10-18 at 14:05 +0300, Kirill A. Shutemov wrote: > > > On Fri, Oct 18, 2024 at 12:00:22PM +0100, Lorenzo Stoakes wrote: > > > > + Liam, Jann > > > >=20 > > > > On Fri, Oct 18, 2024 at 01:49:06PM +0300, Kirill A. Shutemov wrote: > > > > > On Fri, Oct 18, 2024 at 11:24:06AM +0200, Roberto Sassu wrote: > > > > > > Probably it is hard, @Kirill would there be any way to safely m= ove > > > > > > security_mmap_file() out of the mmap_lock lock? > > > > >=20 > > > > > What about something like this (untested): > > > > >=20 > > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > > > > index dd4b35a25aeb..03473e77d356 100644 > > > > > --- a/mm/mmap.c > > > > > +++ b/mm/mmap.c > > > > > @@ -1646,6 +1646,26 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned= long, start, unsigned long, size, > > > > > if (pgoff + (size >> PAGE_SHIFT) < pgoff) > > > > > return ret; > > > > >=20 > > > > > + if (mmap_read_lock_killable(mm)) > > > > > + return -EINTR; > > > > > + > > > > > + vma =3D vma_lookup(mm, start); > > > > > + > > > > > + if (!vma || !(vma->vm_flags & VM_SHARED)) { > > > > > + mmap_read_unlock(mm); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + file =3D get_file(vma->vm_file); > > > > > + > > > > > + mmap_read_unlock(mm); > > > > > + > > > > > + ret =3D security_mmap_file(vma->vm_file, prot, flags); > > > >=20 > > > > Accessing VMA fields without any kind of lock is... very much not a= dvised. > > > >=20 > > > > I'm guessing you meant to say: > > > >=20 > > > > ret =3D security_mmap_file(file, prot, flags); > > > >=20 > > > > Here? :) > > >=20 > > > Sure. My bad. > > >=20 > > > Patch with all fixups: > >=20 > > Thanks a lot! Let's wait a bit until the others have a chance to > > comment. Meanwhile, I will test it. > >=20 > > Do you want me to do the final patch, or will you be proposing it? >=20 > You can post it if it works: >=20 > Signed-off-by: Kirill A. Shutemov Thanks! Ok. Roberto