From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36536C43334 for ; Fri, 24 Jun 2022 09:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9934A8E020A; Fri, 24 Jun 2022 05:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 942D68E0205; Fri, 24 Jun 2022 05:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832028E020A; Fri, 24 Jun 2022 05:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7476A8E0205 for ; Fri, 24 Jun 2022 05:45:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3AE7A1484 for ; Fri, 24 Jun 2022 09:45:49 +0000 (UTC) X-FDA: 79612647618.23.23AF515 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf22.hostedemail.com (Postfix) with ESMTP id 0DCDFC002A for ; Fri, 24 Jun 2022 09:45:47 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R311e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VHGe-V2_1656063944; Received: from 30.97.49.29(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VHGe-V2_1656063944) by smtp.aliyun-inc.com; Fri, 24 Jun 2022 17:45:44 +0800 Message-ID: Date: Fri, 24 Jun 2022 17:45:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 4/7] migrate_pages(): fix failure counting for THP subpages retrying To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi References: <20220624025309.1033400-1-ying.huang@intel.com> <20220624025309.1033400-5-ying.huang@intel.com> From: Baolin Wang In-Reply-To: <20220624025309.1033400-5-ying.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656063948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JkSlFOejivrtlrQ80IB4RfuveBO+OBloAi5t2G7Cu60=; b=w0I2+eT12kWZYru9GBNxxa3s4tcL+s/dggoHYSib7CnDCayzKdP0p2e1Tdo8ke/gNEHVG5 EL/66YwCnWvoEolUc6wdRwesMecNX9Srq7VOj6BPLHZoBsp4Vv1vRWWgojvDfpaUayqQ0Q LmaRUAs3ypnddyhemJBdXfDSzn8VB7g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656063948; a=rsa-sha256; cv=none; b=2Nad1leMek9mswfru+IG+dTIU2Ja0w/JB/DIezENhwz8lvuSISSXRgHNx1koyopBtYF8j1 GxiOl1KiGuNY4Su788P1CGZOfrcVH3XPHQbyGX5WQfqXuIQkBLVXAYtFr2V9V4WC7PdZ5B 7u/hWEH6S/uecthgjMnJka8Xt0oqRLY= X-Stat-Signature: yzas5m1cbmjr9dmme7hbw9qfrgr9a1n5 X-Rspamd-Queue-Id: 0DCDFC002A X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspamd-Server: rspam12 X-HE-Tag: 1656063947-454255 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/24/2022 10:53 AM, Huang Ying wrote: > If THP is failed to be migrated for -ENOSYS and -ENOMEM, the THP will > be split into thp_split_pages, and after other pages are migrated, > pages in thp_split_pages will be migrated with no_subpage_counting == > true, because its failure have been counted already. If some pages in > thp_split_pages are retried during migration, we should not count > their failure if no_subpage_counting == true too. This is done this > patch to fix the failure counting for THP subpages retrying. Good catch. Totally agree with you. It seems we can move the condition into -EAGAIN case like other cases did? diff --git a/mm/migrate.c b/mm/migrate.c index 1ece23d80bc4..491c2d07402b 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1463,7 +1463,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, case -EAGAIN: if (is_thp) thp_retry++; - else + else if (!no_subpage_counting) retry++; break; Anyway this patch looks good to me. Reviewed-by: Baolin Wang > > Signed-off-by: "Huang, Ying" > Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages") > Cc: Baolin Wang > Cc: Zi Yan > Cc: Yang Shi > --- > mm/migrate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 542533e4e3cf..61dab3025a1d 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1477,7 +1477,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > } > } > } > - nr_failed += retry; > + if (!no_subpage_counting) > + nr_failed += retry; > nr_thp_failed += thp_retry; > /* > * Try to migrate subpages of fail-to-migrate THPs, no nr_failed