From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2860EC433FE for ; Wed, 9 Dec 2020 18:24:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C9BC23BC6 for ; Wed, 9 Dec 2020 18:24:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C9BC23BC6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29AF68D0036; Wed, 9 Dec 2020 13:24:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 248918D0035; Wed, 9 Dec 2020 13:24:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 186168D0036; Wed, 9 Dec 2020 13:24:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id F12558D0035 for ; Wed, 9 Dec 2020 13:24:27 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AF665181AEF23 for ; Wed, 9 Dec 2020 18:24:27 +0000 (UTC) X-FDA: 77574568974.13.team73_220eb6f273f1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 8E53318140B60 for ; Wed, 9 Dec 2020 18:24:27 +0000 (UTC) X-HE-Tag: team73_220eb6f273f1 X-Filterd-Recvd-Size: 4486 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 18:24:27 +0000 (UTC) Received: by mail-wr1-f74.google.com with SMTP id g16so1495wrv.1 for ; Wed, 09 Dec 2020 10:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=V2rDh/PTRpe6NWZnEeAWnr3LbupuxXOheZwv6czKP7I=; b=sJrzjf+rsOdspdQKnYG9pg0y0KJCU2rf0QxkpTRnNcP3e6Aub3MH1asP3rLsM6Yq64 6sisT6KMQfH8oNrgEGWsXTZd3a3ZzfQwWKmo2YeftvCEs8fMbw2aspmzE5p531i4LWib 1VibozdtcpLde7sbMU6UwWyMSZ89dNKXMFuU8igBRvKCyjCCajbL1nH1Xjfeuq0wS6bN JOZE9p0wa5eM3Zr0LFT/S393AuaG2VtA5OsN7wa9eLZD46TKUlW2qLXWAuuXjEA/yxPZ Tlswk9BfFM5KF/UwXKuc/0LtX+iT/vGi4np7MS7nlxVqpQPKBSpyre6qGHsDxa5L2Nyg gaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=V2rDh/PTRpe6NWZnEeAWnr3LbupuxXOheZwv6czKP7I=; b=bUHK7V2IMt9jsEoSazdGUlPd1WRTp9ekeubXdMdVka1dlfd+MriN+5Zkb4uJ2QsKC3 zbO3T6FzGliLVJTHfoU+cM0tI7We5TW4Ehl2l3SxXaG7CioM67eh048neTXhHBXxQ4WB 6kq1iBqlWGQgc1XNaSPZ1VBoCiMk7mR+kLwybNWLGdDp5Q4MzOny9ptUSww8uwgZNofI N6oWyBWNc5+1jdo9KMIocc2Ay2IeOKTzz4Y3yIOnoiEILTqK7xaltibIquRJT8a7dhK7 44No7PpGec7QMJZRh7KUR4LiHvX4f2i22B3Bhwgeij3jwvkpcvb3s3s0GCYPwQBFXGio 7THQ== X-Gm-Message-State: AOAM533ZMq0zf7KnyTDLIyCeqzxdGdRSUHNYyrxC7mnD+5/he7eGJLKW WLFbzp1oFXGVyt16W/HOaA6MsoqTxiEdi7fo X-Google-Smtp-Source: ABdhPJyP0L7+kNbjb687i7w1wzyg+YrLTPf+fehJ67MnVyUl7tP85xcGPS2oT8rxgT392YbT4bW+Ohr26jGwv8aY X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:adf:e710:: with SMTP id c16mr4123641wrm.295.1607538265727; Wed, 09 Dec 2020 10:24:25 -0800 (PST) Date: Wed, 9 Dec 2020 19:24:15 +0100 In-Reply-To: Message-Id: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog Subject: [PATCH mm 1/2] kasan: don't use read-only static keys From: Andrey Konovalov To: Andrew Morton Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: __ro_after_init static keys are incompatible with usage in loadable kernel modules and cause crashes. Don't use those, use normal static keys. Signed-off-by: Andrey Konovalov --- This fix can be squashed into "kasan: add and integrate kasan boot parameters". --- mm/kasan/hw_tags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c index c91f2c06ecb5..55bd6f09c70f 100644 --- a/mm/kasan/hw_tags.c +++ b/mm/kasan/hw_tags.c @@ -43,11 +43,11 @@ static enum kasan_arg_stacktrace kasan_arg_stacktrace __ro_after_init; static enum kasan_arg_fault kasan_arg_fault __ro_after_init; /* Whether KASAN is enabled at all. */ -DEFINE_STATIC_KEY_FALSE_RO(kasan_flag_enabled); +DEFINE_STATIC_KEY_FALSE(kasan_flag_enabled); EXPORT_SYMBOL(kasan_flag_enabled); /* Whether to collect alloc/free stack traces. */ -DEFINE_STATIC_KEY_FALSE_RO(kasan_flag_stacktrace); +DEFINE_STATIC_KEY_FALSE(kasan_flag_stacktrace); /* Whether panic or disable tag checking on fault. */ bool kasan_flag_panic __ro_after_init; -- 2.29.2.576.ga3fc446d84-goog