From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C21C433E0 for ; Thu, 11 Feb 2021 01:58:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B8AD64DBD for ; Thu, 11 Feb 2021 01:58:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8AD64DBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=tom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 975EF6B0005; Wed, 10 Feb 2021 20:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 926566B0006; Wed, 10 Feb 2021 20:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 814F46B006C; Wed, 10 Feb 2021 20:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 6BB5B6B0005 for ; Wed, 10 Feb 2021 20:58:48 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 34011A764 for ; Thu, 11 Feb 2021 01:58:48 +0000 (UTC) X-FDA: 77804328336.03.237B4BC Received: from smtp.tom.com (smtprz15.163.net [106.3.154.248]) by imf17.hostedemail.com (Postfix) with SMTP id 1E08F40001DE for ; Thu, 11 Feb 2021 01:58:45 +0000 (UTC) Received: from my-app01.tom.com (my-app01.tom.com [127.0.0.1]) by freemail01.tom.com (Postfix) with ESMTP id 2B7391F567EF for ; Thu, 11 Feb 2021 09:59:14 +0800 (CST) Received: from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1]) by my-app01 (TOM SMTP Server) with SMTP ID 253431264 for ; Thu, 11 Feb 2021 09:59:14 +0800 (CST) Received: from antispam1.tom.com (unknown [172.25.16.55]) by freemail01.tom.com (Postfix) with ESMTP id 1EDAD1F567E3 for ; Thu, 11 Feb 2021 09:59:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807; t=1613008754; bh=ohmzkIrlnsdQhjkcGHacS1TY1XISXKjBkkpFgtIV8AM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=DKYuBABSgWXDFYCvoGlJrEpdbvNMtI+6sqmhySUBb1PctWpDH8Fgd/Q1PPBbNmyem 0X2Urdog98IlM9A5H0nWs4CvGBVA7j6OsD2s1ttGnLjfDKXU9hsvu/zwOSbcxChYVb wN5zZW6T3YrsWaPGC+25httr1TWrBnCL7R6OeFpM= Received: from antispam1.tom.com (antispam1.tom.com [127.0.0.1]) by antispam1.tom.com (Postfix) with ESMTP id 63D121001895 for ; Thu, 11 Feb 2021 09:56:46 +0800 (CST) X-Virus-Scanned: Debian amavisd-new at antispam1.tom.com Received: from antispam1.tom.com ([127.0.0.1]) by antispam1.tom.com (antispam1.tom.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MLan-69VtDF9 for ; Thu, 11 Feb 2021 09:56:43 +0800 (CST) Received: from [192.168.31.184] (unknown [61.152.197.197]) by antispam1.tom.com (Postfix) with ESMTPA id D6B6B100180D; Thu, 11 Feb 2021 09:56:41 +0800 (CST) Subject: Re: [PATCH] kswapd: no need reclaim cma pages triggered by unmovable allocation To: Michal Hocko , zhou xianrong Cc: iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com, vbabka@suse.cz, rientjes@google.com, willy@linux.intel.com, pankaj.gupta.linux@gmail.com, bhe@redhat.com, ying.huang@intel.com, minchan@kernel.org, ruxian.feng@transsion.com, kai.cheng@transsion.com, zhao.xu@transsion.com, yunfeng.lan@transsion.com, zhou xianrong References: <20210209082313.21969-1-xianrong_zhou@163.com> From: zhouxianrong Message-ID: Date: Thu, 11 Feb 2021 09:58:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Stat-Signature: zd4qh3eqx9t531ur933atjgytnyftan6 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1E08F40001DE Received-SPF: none (tom.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=smtp.tom.com; client-ip=106.3.154.248 X-HE-DKIM-Result: fail/fail (body has been altered) X-HE-Tag: 1613008725-882402 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/2/10 =E4=B8=8B=E5=8D=889:14, Michal Hocko wrote: > On Wed 10-02-21 12:07:57, zhou xianrong wrote: >> On 2021/2/9 =E4=B8=8B=E5=8D=885:23, Michal Hocko wrote: >>> On Tue 09-02-21 16:23:13, zhou wrote: >>>> From: zhou xianrong >>>> >>>> For purpose of better migration cma pages are allocated after >>>> failure movalbe allocations and are used normally for file pages >>>> or anonymous pages. >>>> >>>> In reclaim path so many cma pages if configurated are reclaimed >>>> from lru lists in kswapd mainly or direct reclaim triggered by >>>> unmovable or reclaimable allocations. But these cma pages can not >>>> be used by original unmovable or reclaimable allocations. So the >>>> reclaim are unnecessary. >>>> >>>> In a same system if the cma pages were configurated to large then >>>> more failture unmovable (vmalloc etc.) or reclaimable (slab etc.) >>>> allocations are arised and then more kswapd rounds are triggered >>>> and then more cma pages are reclaimed. >>> Could you be more specific? Do you have any numbers and an example >>> configuration when this is visible? >> It should be implicit. > Right but the scale of the problem is an important part of _any_ patch > justification. Sorry. The relative description is not suitable and should be removed.