From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE60E64AB6 for ; Tue, 3 Dec 2024 14:42:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DCA46B00AF; Tue, 3 Dec 2024 09:42:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48CD36B00B0; Tue, 3 Dec 2024 09:42:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37C316B00B1; Tue, 3 Dec 2024 09:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E5166B00AF for ; Tue, 3 Dec 2024 09:42:33 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C828E809E6 for ; Tue, 3 Dec 2024 14:42:32 +0000 (UTC) X-FDA: 82853913240.06.093F880 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 44B6B10000D for ; Tue, 3 Dec 2024 14:42:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733236942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ICEjb0LGt3DlsU2y9oxTBHbl8q/TedDzmYK4Su8crjM=; b=Hx+j83Zz5WAkm0ezLBOoEOtJURybG9hONiYdFLh43ly35JgU/1ShfPIsj8C8GoCQqnRtnx FhHfsryWnXxWiwDB1T8VIpfvST9fumF+VQxyAv9gXJLJh0fEdhhCq9m3s43Ahk1uCxxm7S QLe6ooK3bwnDBj7QQi2F3V2g166zz9g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733236942; a=rsa-sha256; cv=none; b=AhfzbFaxJ5h3yKKd7T2msVwsjOKvnXZGkc6qWWn8XLq8LctcdNsyRb9+WdN4CI8Q6AtMKx jYIt2PzvWyXL42uoZo6qy3ZtRR05l38b/L8AZx3F3MM/PFdWinBXYw9XMRuqGQvvKtBSYP daJs22rfEHw0dLxrRlgMvYBGjY1jXds= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A46D2FEC; Tue, 3 Dec 2024 06:42:57 -0800 (PST) Received: from [10.57.90.133] (unknown [10.57.90.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64AD63F71E; Tue, 3 Dec 2024 06:42:27 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 14:42:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] smaps: count large pages smaller than PMD size to anonymous_thp Content-Language: en-GB To: David Hildenbrand , Wenchao Hao , Andrew Morton , Matthew Wilcox , Oscar Salvador , Muhammad Usama Anjum , Andrii Nakryiko , Peter Xu , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20241203134949.2588947-1-haowenchao22@gmail.com> <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> From: Ryan Roberts In-Reply-To: <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 44B6B10000D X-Stat-Signature: jeoiu3j8raoyw6mp4d3z68yq5ishxutn X-Rspam-User: X-HE-Tag: 1733236936-534845 X-HE-Meta: U2FsdGVkX19E9YPYd57TekI9ZxQHnogLkUppxw03gm/p0565kMt7BflArCu4JQHejSDU47xV2euCSsRmboFmuc1ugmzTakDfxuRbd29uvBV2pTF+7PPs3LKviY7zqyhbes1HH45G7U6g3UgY5irwTq80ZmLAxRoQVznOB70TFMgBO0wYKb+B+shxCz3DimG93cXiLd54ZEZN1nL1mLUCg6RmQ9Ak/3QqcdTUxs3ogn/q8vhwO0R16QXW6iPaQM9czQOAWjaEqmlRgdS+pbcugpawcMtzMHNpzC3yRK5Rov9R6w0W6/BTEOumVHNFrmQLMB6pMLaIOfApluEyjK2lMr57OyK5Bn9ZDY70R4ZMGfNowkWrl4ls8UMo5ZtzkvYkt/6ROC+cjcxTFNy9ROOjc5/EzkVq5heJ7iX5CWx7ws+WeIb/7NrYIjyfNuXJ2Hz8zc7pJdut98a2Iz04zdZFUnCkQYubdx12JFqfB2xUGTg6QQ4rIWaLEto+HZeJmPJCdmmPOBh4861actWCawmVtGMNuUvjRjIxf5G6BDdR5LfjGbGv815RpBTy2fnnA0Lj0Y9ySUOCWosOQ4z+hgXwK3aubZB2ptiGZSx66DZkQzWU8xYtdGinczhV3tXy/nOvKScDTyyKvkUjvLbDmOOglSfsO4M8H2tR7QLm5jxD3ZKef8oxX2Sq5CuX0EkfAjeVUCfz9U3U7L2aQY7tCK77PBr+vhbMSgQ0RjzhzZOlC5tzW6+Ji4baexR5xygbHV19+Zkd2P3IYP7G4gg90PTSJlJMfFGU3s62pk7jRFtTGPJz0rJ757ONMt2JgWZPT2fF7gJ00X/kFb3QZDN+i7fl1qcH4J+2cEJ3A19V4fGoPfJeFRri4XdbxG1WpmaUZX6FGSadbfkg2gIFDtkcA5Kp4vFPz9ZDAs39HKRnbtX9+ota+Z+nwaB5kLZfb3sPN1pG3hANWlwCKB13oZHD39O 2Yoyf5KQ eeg41YZDDQGAXRYwHksmHPspOKMCgD8ODPrrrKLnPdV9GKUkAxSHQugjigszPqA0SXoXHBRciRkxpf65rZ8oP0invhaE1i9Ztlf3u0hoa67FurQMhD0l/M8axcq9abCztTva+YMBa2tAGZBNmt6h3JbbfGVWPFAdtBTdPa1RubBLLvOpwBsKtsJKGtvnNdNrris4ccYK1Yr6E0u5eZpWSfXbpf7tb7lbohe6xzs7fS8v0AQM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/12/2024 14:17, David Hildenbrand wrote: > On 03.12.24 14:49, Wenchao Hao wrote: >> Currently, /proc/xxx/smaps reports the size of anonymous huge pages for >> each VMA, but it does not include large pages smaller than PMD size. >> >> This patch adds the statistics of anonymous huge pages allocated by >> mTHP which is smaller than PMD size to AnonHugePages field in smaps. >> >> Signed-off-by: Wenchao Hao >> --- >>   fs/proc/task_mmu.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index 38a5a3e9cba2..b655011627d8 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -717,6 +717,12 @@ static void smaps_account(struct mem_size_stats *mss, >> struct page *page, >>           if (!folio_test_swapbacked(folio) && !dirty && >>               !folio_test_dirty(folio)) >>               mss->lazyfree += size; >> + >> +        /* >> +         * Count large pages smaller than PMD size to anonymous_thp >> +         */ >> +        if (!compound && PageHead(page) && folio_order(folio)) >> +            mss->anonymous_thp += folio_size(folio); >>       } >>         if (folio_test_ksm(folio)) > > > I think we decided to leave this (and /proc/meminfo) be one of the last > interfaces where this is only concerned with PMD-sized ones: > > Documentation/admin-guide/mm/transhuge.rst: > > The number of PMD-sized anonymous transparent huge pages currently used by the > system is available by reading the AnonHugePages field in ``/proc/meminfo``. > To identify what applications are using PMD-sized anonymous transparent huge > pages, it is necessary to read ``/proc/PID/smaps`` and count the AnonHugePages > fields for each mapping. (Note that AnonHugePages only applies to traditional > PMD-sized THP for historical reasons and should have been called > AnonHugePmdMapped). > Agreed. If you need per-process metrics for mTHP, we have a python script at tools/mm/thpmaps which does a fairly good job of parsing pagemap. --help gives you all the options.