From: Lorenzo Stoakes <lstoakes@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org, linux-hardening@vger.kernel.org,
patches@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: remove HAVE_HARDENED_USERCOPY_ALLOCATOR
Date: Wed, 24 May 2023 08:15:23 +0100 [thread overview]
Message-ID: <f2ca936a-1441-4cbd-b16c-ff2d54630a75@lucifer.local> (raw)
In-Reply-To: <9191d9b0-3318-4e70-a81b-69acff184fc6@redhat.com>
On Tue, May 23, 2023 at 10:28:32AM +0200, David Hildenbrand wrote:
[snip]
> > > The file is only compiled with CONFIG_HARDENED_USERCOPY:
> > >
> > > mm/Makefile:obj-$(CONFIG_HARDENED_USERCOPY) += usercopy.o
> > >
> >
> > Yeah ugh at this sort of implicit thing. Anyway it'd be preferable to stick
> > #ifdef CONFIG_HARDENED_USERCOPY around the prototype just so it's
> > abundantly clear this function doesn't exist unless that is set.
>
> I recall that it is very common to not use ifdefs unless really required.
> Because less ifefs are obviously preferable ;)
>
> Compilation+linking will fail in any case.
>
I don't want to insist so hard on something that doesn't really matter, the
bike shed can be blue, green or red it's fine :P
So,
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
next prev parent reply other threads:[~2023-05-24 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 7:31 Vlastimil Babka
2023-05-23 7:42 ` Lorenzo Stoakes
2023-05-23 7:46 ` Vlastimil Babka
2023-05-23 7:56 ` Lorenzo Stoakes
2023-05-23 8:14 ` David Hildenbrand
2023-05-23 8:19 ` Lorenzo Stoakes
2023-05-23 8:28 ` David Hildenbrand
2023-05-24 7:15 ` Lorenzo Stoakes [this message]
2023-05-23 17:02 ` Kees Cook
2023-05-24 0:31 ` David Rientjes
2023-05-24 6:15 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ca936a-1441-4cbd-b16c-ff2d54630a75@lucifer.local \
--to=lstoakes@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@lists.linux.dev \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox