From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E948CC433F5 for ; Thu, 10 Mar 2022 11:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 501B98D0002; Thu, 10 Mar 2022 06:57:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1188D0001; Thu, 10 Mar 2022 06:57:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3788D8D0002; Thu, 10 Mar 2022 06:57:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 25C688D0001 for ; Thu, 10 Mar 2022 06:57:56 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BEF08181BECC0 for ; Thu, 10 Mar 2022 11:57:55 +0000 (UTC) X-FDA: 79228327710.22.8CC98CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 17DE840011 for ; Thu, 10 Mar 2022 11:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646913474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TZYKuCaufEHQEij7wfPKMNByDrNFZ28XleuZYsmHjGY=; b=TXmOKjXwXJMibNgTfES+q9BZqBhuQsrdWx8WLMv8nTqvJNGyePBDNp2sQFfxpsWoBMpm4o g1vPwfARlYhNR/xYOLRmhtak9KfuNjqp9Fmd3kABkKHjHSxuhzNhru8w2LMys38vF7XO9n vus3gtgipp7VMKluRZ7utLM1up3+KmE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-qWofBsNDOia6neRYjN_WDw-1; Thu, 10 Mar 2022 06:57:52 -0500 X-MC-Unique: qWofBsNDOia6neRYjN_WDw-1 Received: by mail-wr1-f69.google.com with SMTP id x15-20020a5d6b4f000000b001ee6c0aa287so1608358wrw.9 for ; Thu, 10 Mar 2022 03:57:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=TZYKuCaufEHQEij7wfPKMNByDrNFZ28XleuZYsmHjGY=; b=nHCT5H9B7O8JEHqxcUF6iu3Pu4b6POm9ubCzxA2/mISGJVCxyLRup4YOoIRZ3yZIu5 4VwDE4z/SsgYKYX+2rAVNVZVqqqzTNKPY6yHzn/QQ8tps9/UNXXZLwwzytbqJ+eqwe2B c4U8UYSAk/3qjTFjJdCiyelLdlJ4qMobZb9RdsVJjTwfEyqZp1NWOZ0no/74hAaK+uAg pCrgqFo/rxTXEdKEp/oG+A0SueojSnfmIw2oSzP1iBM0n5qSHW085Whb55JrcSXaQWHG xiitbMe7Sggtfz8o+Wp21cWc1XSn2jE0qt7ZAmSJ6IiyLw7jJ/Mp+epdIerKideN3dQe 01OA== X-Gm-Message-State: AOAM533DhIW9ZnTXbVHnqqQEayWhQ1jEwlE/NARgwMH3DK07Ekjcf42x grQFKaDuD3OLdWEbLYyeMIZ8wFf8ZfnLO+UTVzlf0SIcvKOreKrmQA3AdAEcTxFpqPDILd4ekcb m6sRjTD4gQN0= X-Received: by 2002:a5d:55c7:0:b0:1f0:48cf:9568 with SMTP id i7-20020a5d55c7000000b001f048cf9568mr3369515wrw.379.1646913470866; Thu, 10 Mar 2022 03:57:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJz++U/wpOl6a/LR9/pa8J/lU8vzFbnm6yXOHWBiLvHSzFRpfwBSs9aGyz2BZYkaAeFm9lCKaA== X-Received: by 2002:a5d:55c7:0:b0:1f0:48cf:9568 with SMTP id i7-20020a5d55c7000000b001f048cf9568mr3369473wrw.379.1646913470442; Thu, 10 Mar 2022 03:57:50 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id z3-20020a1cf403000000b0037d1f4a2201sm4365294wma.21.2022.03.10.03.57.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 03:57:49 -0800 (PST) Message-ID: Date: Thu, 10 Mar 2022 12:57:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 00/15] mm: COW fixes part 2: reliable GUP pins of anonymous pages To: Oded Gabbay Cc: Linus Torvalds , Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Linux-MM , Khalid Aziz References: <20220308141437.144919-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 17DE840011 X-Stat-Signature: cw6cdsjy3quxi7t3bnbqg3gaitg7nkee Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TXmOKjXw; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1646913474-939497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.03.22 12:13, Oded Gabbay wrote: > On Wed, Mar 9, 2022 at 10:00 AM David Hildenbrand wrote: >> >> On 08.03.22 22:22, Linus Torvalds wrote: >>> On Tue, Mar 8, 2022 at 6:14 AM David Hildenbrand wrote: >>>> >>>> This series fixes memory corruptions when a GUP pin (FOLL_PIN) was taken >>>> on an anonymous page and COW logic fails to detect exclusivity of the page >>>> to then replacing the anonymous page by a copy in the page table [...] >>> >>> From a cursory scan of the patches, this looks sane. >> >> Thanks for skimming over the patches that quickly! >> >>> >>> I'm not sure what the next step should be, but I really would like the >>> people who do a lot of pinning stuff to give it a good shake-down. >>> Including both looking at the patches, but very much actually running >>> it on whatever test-cases etc you people have. >>> >>> Please? > > I can take this patch-set and test it in our data-center with all the > DL workloads we are running > on Gaudi. Perfect! > > David, > Any chance you can prepare me a branch with your patch-set based on 5.17-rc7 ? > I prefer to take a stable kernel and not 5.18-rc1 as this is going to > run on hundreds of machines. https://github.com/davidhildenbrand/linux/tree/cow_fixes_part_2_v1 contains the state of this series, based on v5.17-rc7 and part 1. I'll be leaving that branch unmodified when working on newer versions of the patch set. -- Thanks, David / dhildenb