From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 762FFF01832 for ; Fri, 6 Mar 2026 12:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CED2B6B00A4; Fri, 6 Mar 2026 07:43:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B156B00A6; Fri, 6 Mar 2026 07:43:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D046B00A7; Fri, 6 Mar 2026 07:43:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A63166B00A4 for ; Fri, 6 Mar 2026 07:43:27 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6AEE51C655 for ; Fri, 6 Mar 2026 12:43:27 +0000 (UTC) X-FDA: 84515604054.01.4F23DC4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id B70431C0006 for ; Fri, 6 Mar 2026 12:43:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9mC0Dtb; spf=pass (imf21.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772801005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QWdPDMTwGM6a5JRcgYVSuAzDD6OQV73Y1dH59k1txJQ=; b=cJUgC7QLLdMjfVeAyxf3pMuuhGStAHmt5e94PXx3CcVLRTk7qqyrzd4Ltiaj5D2PciOSAR SejlZD3TmCgsKsfvO1Ym1wZxqr4nv0jgPLRFdSuy+xYuR/asamrDfv6X7TxgTVkTtl9jKM DDo/MSJLUxWe9R505Tcu06hnz9Chgn0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9mC0Dtb; spf=pass (imf21.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772801005; a=rsa-sha256; cv=none; b=RiLYfKEnAjsu1D8WKP6RfTJCz6rT9uP0uPDRTJL6+SSXQvi85GNpgYArmkoRTIADKOymil z7RkD9lFbW9wOqldKIdDusIqtt6fNSLKpvUJ0D9IsPMlc+YzycJ+a2qrLFqDTeO0JoO1rw YP8QZ2WBW3xSmRSv+8I5CpWhXJMcfUk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C43F340571; Fri, 6 Mar 2026 12:43:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 149B7C4CEF7; Fri, 6 Mar 2026 12:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772801004; bh=laI5Gks8UKTtQyxqn7mx9nW4b8iCTs15iKu2otVUFHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p9mC0Dtb5HP8pcPpgD7riizGZNEqblFXhyCBB7gyX3iYqVlML2IEu/E46TQAfJ6kB 5ES8F1tVf64ZhuAJ2vES+zOK4kRMzYtKhCjqesskIYnO8sAKVgRvaUWEnRMwLwSDQe 6ozGy1rqY43AQN4mamdsvpi0UFTEWG/1ua9kPc8CcoyCTro7l1nx6xbY3HJtSjDB33 HoXIf0/JjwlmXYcHIiJHIJDR1zTA/RgIid+TR7+6DmUz/5MSsmXaWj5qjtxVswmSpB y7qIWK2NRTkB+QK0r3eC/5U81n1lw5TgFlHl0zqxfvXpiP2u3XAAAbXR9+cd9x48Kv 4L7tL1NMHpRqQ== Date: Fri, 6 Mar 2026 12:43:21 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 16/16] mm/memory: support VM_MIXEDMAP in zap_special_vma_range() Message-ID: References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-17-david@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227200848.114019-17-david@kernel.org> X-Rspamd-Queue-Id: B70431C0006 X-Stat-Signature: x4zwkmpcb5oirjxdfmbbhiogs3pcyxhw X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1772801005-262467 X-HE-Meta: U2FsdGVkX1/L6xmZ9WPYEuutZAB5Fn5lx65RbaBrDr+up8WFWoBmdDXFQo9THNAXHtp/dELwkSy4paJOvTv6+ZGZopEqrWLELKgz2EkDJWE853zY/WCg+rL1ZyLAqWm57Xdn43VkaMPXiTOgqrsw26eZNnF/YXSmql24i9ucYHDZGhoGYCKDrr21x0bn3Bf/IKNhADnJSQQWTsIEwS+ymB0jHTMc2gNnXjIjzJgbNCRJfP0P5r1Ql7uquYXQVsk9hL+6CKpqCiT1P92SJ5WtJbKCCHChIfaPFi9x+tREl9u1ubNwjK1ktNGRBR/uhyrU73fbsGqt0QNx9rTkLML8Y3Wfkd3TrY4ehwHPyvgwfd8GMEP9F1bG2B665XGS9veQ0FZqOxjMk31VJ1cktrKsrQMv6SUvdIxTJsxEy+QEwEs1FKFYlLsk5OuvetpZxfDxkLaeAsuy/grFCqzCHhZUsen98d5SBPfTUEuNoWqhcsBHoamWPUuSUNbaghxY+n0ljyD6yplleFl9MmM17QwKkT2kns+4UKzQTi11JXghYU5ifcHPJvq5aZ96xdlz6lva4IhHuYBtA8GPtlp/NpZ0EICb0xmVDXCVA1jHk6ihMavXnY4lPFYo5Qh4cps5fL0G7USvEq7ym2/RmD68YU+nIDXejWEwvJfZ+iWhzUa5WdV+N05czCULIQxXMzYTgFLaEolg4Y6vfEjk0vtJIDWsVSiPj1tc/UsAWZmJkz08DLZqmHrlCVAe5HWYbHAt1UFGeQES6YEFVxBpl0L35ofvublEZoOuSrlPn47LYTWFjtJjaON3LyTTgUb+fkYjaFe1sX0botPvm8uA5wnlmnwWV1JM/P/ZVVKkuy8h6IA9D6jOPZRhMHWSG7Vf1LjlHmPCqeORxHsKUBLAogHj7Fa4pwCZRl9jDJiLzkR8ZriJYQhsQNF+DGUtg2rb0yCdz6I5T+5C9s8UVbbmEGwAHsA URjenKKe CdOz8oM8SylUdpZ5aUk/RCN4P6FNn4Suc6Vc+TX0QcCUu9iauv3Wx8/XniVQMyoaa8yKOW6JOZNoIKmDS5MCV1XRvWqBO6MQNWKDPyYRlOwfj2xvWr1UBtG0iiHfWZu91zRi+0yzYP4XQfDtMXb1PDIhFGHL6niWdD6x+EXatKfW0vYrh4iQhkmYa+zW9Sm/o6d56cbP68kO1Xd9l4wnehkh6h6dfMFrKsqNuvgXygNk9Ekk0TcC1RT/JKNA/apJBkCjNOZ4vFA1ocyYmGWREKnGfp3KnX7YBayvu1Bzlo+1lGP5bNHzez2Jg0Q== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 27, 2026 at 09:08:47PM +0100, David Hildenbrand (Arm) wrote: > There is demand for also zapping page table entries by drivers in > VM_MIXEDMAP VMAs[1]. > > Nothing really speaks against supporting VM_MIXEDMAP for driver use. We > just don't want arbitrary drivers to zap in ordinary (non-special) VMAs. > > [1] https://lore.kernel.org/r/aYSKyr7StGpGKNqW@google.com Dude, you have to start your indices with 0 what kind of programmer are you? ;) > > Signed-off-by: David Hildenbrand (Arm) Agreed that there's no reason not to allow this, so LGTM and: Reviewed-by: Lorenzo Stoakes (Oracle) Thanks for this series overall, very nice cleanup and I was frustra^Whappy to see that there was nothing major or really of note to comment on here, a rare occurrence in review :) > --- > mm/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index f3b7b7e16138..3fe30dc2f179 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2239,13 +2239,13 @@ void zap_vma_range(struct vm_area_struct *vma, unsigned long address, > * @size: number of bytes to zap > * > * This function does nothing when the provided address range is not fully > - * contained in @vma, or when the @vma is not VM_PFNMAP. > + * contained in @vma, or when the @vma is not VM_PFNMAP or VM_MIXEDMAP. > */ > void zap_special_vma_range(struct vm_area_struct *vma, unsigned long address, > unsigned long size) > { > if (!range_in_vma(vma, address, address + size) || > - !(vma->vm_flags & VM_PFNMAP)) > + !(vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP))) > return; > > zap_vma_range(vma, address, size); > -- > 2.43.0 > Cheers, Lorenzo