From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CB9C77B7F for ; Mon, 23 Jun 2025 13:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FFDD8D0008; Mon, 23 Jun 2025 09:51:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AFEB8D0005; Mon, 23 Jun 2025 09:51:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078068D0008; Mon, 23 Jun 2025 09:51:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E6C628D0005 for ; Mon, 23 Jun 2025 09:51:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 61F39140530 for ; Mon, 23 Jun 2025 13:51:41 +0000 (UTC) X-FDA: 83586803202.30.FB622B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E9E96140013 for ; Mon, 23 Jun 2025 13:51:38 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HyQPMUxE; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750686699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aTMs4wV4SuVKhFSHjMzqgPgB1cu77va3GYx+Y9ijEiM=; b=R/vYghBuPtml1V2tObxN45cMkLNIgUCvyOk/+k5EET2gNL8w++197AYSZxf6rGI9yfYUkb X+PDKXKAxYb5ylvlzooOWi8R14ICpzfjltRymrpiK+8FZ34oXzmjDCz8jPNYZd1dKV0axX XM3mXQu5UH9xnTjOVCLFewCyiHPvx3A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750686699; a=rsa-sha256; cv=none; b=14Bp7mHWXzH2wJFr6CR5pMHi3Z0NgSqhYz5rJYqr0eIpjWBoxDOdAutFCkLKoIQHygkgqM NFkD1WpKE45kVRU7s5kl1jlyE0fj81Rpu8f6OPVDVUT/OP3dbidAsKkxZCUpDq7qDNSVeR Q7xMamfsxfIgeWLUSa2+TK+5X/8omcg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HyQPMUxE; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750686698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aTMs4wV4SuVKhFSHjMzqgPgB1cu77va3GYx+Y9ijEiM=; b=HyQPMUxEY6eJOepHbw0docuBnrzJUPP+kZe9wS5ozllBVKn0VSSO5FWH9xlMcYp4M+fNdD aWMeboMp9z/YnhYwnm2lnfJykSKmfoNlwYb2NZ9Dsp8Rg11ra1rIq/c+Mj2fztfP4bS7uk D9/7C8eP2ar/w2n+iDN1ScbocqIpiKU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-2U_me1c2M0adRAVeq1xtOg-1; Mon, 23 Jun 2025 09:51:32 -0400 X-MC-Unique: 2U_me1c2M0adRAVeq1xtOg-1 X-Mimecast-MFC-AGG-ID: 2U_me1c2M0adRAVeq1xtOg_1750686691 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4535d300d2dso33760155e9.1 for ; Mon, 23 Jun 2025 06:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750686691; x=1751291491; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aTMs4wV4SuVKhFSHjMzqgPgB1cu77va3GYx+Y9ijEiM=; b=qXgiTdDGzZVbbzi65HV+pHYKzKt2EepyqJh0ov0kYssJTGmUN/tCOyJgbfZXbEiJrN jSKPaKR1ET0o1Ok7JKS37IM2yGbW8b6IrLZvT+SWygF2sFnRbEcMOrohzxTSBCHmhtU3 Hr11pAnZAWFPzsLnEsp4bPEKjibdW+FSmFL9K6Sv27lggCvgdGI0b40Ops1PSpFSCRv8 3Z6XyV0cObRC7uKeLP0BbRlk5hf7FhcBO6VAq34FGTJBw3bc4R4s/OPIcLV8HtV3LtGg F2rMXclmeppx8OFx1GyqF2L/tgBPxIubOYd4gZ5wEw61Muwy3fOqZCAx6VOtmeLwWjI8 AJUA== X-Forwarded-Encrypted: i=1; AJvYcCXqzFhSfACZL+5BiwMPiarNYO4NTH+Mww1FOTHi1kLBP5baXFuGIDRPWTrnLp1g8UQqc7gUBoX6ug==@kvack.org X-Gm-Message-State: AOJu0YxcqtjH1n2q1NdgCvwLA2W0sx5F9uIVA5j8TsLxE93YmggKyD2c utIRu9OojU0RXpMQ8eHsEkZM+giHC3qsKcaIoAtqHkWnEpSsU+B4mhg1yvNxnMRRHQKdsFwQcfE U2y5vP+N7pbymREf7qcJXhuQ9UNLgVYnkDdmkgWn07ADgvGEssHdR X-Gm-Gg: ASbGnctBUsu1b/n061SNAgPEH2c/8OFGBJmk9wiZbXdSo+Z/pSx7/3Vu0VwqqaxyVAp p94XePLebaBJ0/A5eaQPaew7fG5/4se0FZX69f+F9eaY4hrhHddX7PyONSutTwcX2NmUprFcfjY +Id5Yv2FJ5ocAudQ+Afmzn7QrXe4XQWIAFJgfYypSiwBFU+IANTq6KTPp+N7wpHPWiz1Toml9mc 34OTYpyshOawRIiccM2+Lsh5hFcODj+DTwSaJvoqDQec2O9J9Q/IQRvzsJXulgFXWJzYQMm74Yn LpOkOOtDH/YI8e7bMEKM3f/GQ4Hb7C0xdSx3z8V/1HX1FQn6eT6uIi7waT1wrocJOaZO2ltZKRe TvS/wNafd9rwCU91/L/kF8aJ9OtiWSxFu4b6MnCY0vID6cub7fg== X-Received: by 2002:a05:600c:3b1e:b0:451:df07:f437 with SMTP id 5b1f17b1804b1-453659c0c47mr137895785e9.30.1750686690816; Mon, 23 Jun 2025 06:51:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3wPA2NDZGNU+tezB/9zWFnuVdchez0lrMy4aiZ6nmbAqIOhTpniZoMot4ic342DXsB/1krw== X-Received: by 2002:a05:600c:3b1e:b0:451:df07:f437 with SMTP id 5b1f17b1804b1-453659c0c47mr137895525e9.30.1750686690404; Mon, 23 Jun 2025 06:51:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eada7adsm147297065e9.35.2025.06.23.06.51.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 06:51:29 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 15:51:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass To: Shivank Garg , akpm@linux-foundation.org, brauner@kernel.org, paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk Cc: seanjc@google.com, vbabka@suse.cz, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20250620070328.803704-3-shivankg@amd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250620070328.803704-3-shivankg@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FBhXsiHzf_icdFJSdXBQYVsD5KMIf-dKRI8uW_v4ey0_1750686691 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E9E96140013 X-Stat-Signature: q1y3iocr6qaxeuq3mu6jbgpp7cnzt1hk X-Rspam-User: X-HE-Tag: 1750686698-979693 X-HE-Meta: U2FsdGVkX1+j/DbQ7Ydto1B++jqZ06m6SEClSHAxPziYYhu5StjHBaHMbbUvzab/fk1Wj18HuOgcAgShsVCyzEuVfMz4UXbxTnIs/vQsYFQCEIQ9KYJlMvAHW0H61GOndFQecEvyTVLRTacjobKog69WLZaOkojKHygjXwVUvLUoxZxg3gtlz5ch01jyf517hRu5kRbFUzsRHieBPNwsfAbz51prxU/nIBDcmMX3RKvmolmdOzANRa1WPH5eoMq/nvCghJISV/8+UZSUC+X4+8wxIf8PNFOqCcJxAKd7LYmWOyl+iQnvApxOCKMdo3zJLkFUsuF7oHYWnzi7xrTpx6sl3k16C62DU17IAPB0gbCUjKNUm8NT35pvvLGNpqOZIBpknxgbdiNKuMo57bT3rlrS8I6zX/CoOtfChnXdDmrm5uWvX2JKRBl4GCObOggjbo8E+ndQEU0D9bW81xWgcDWsDUySDbGA6hcolCUzNWNEgUVCTFpeJ2z2gwYRLQN0Cn644xDM1ElPdN5CZTjewG1groCgOK2Wrhdt05oNA5ASzcWvdIV8X2NhyGuma5KFgOl1DBMB49eHbKZr02bBMkEMlywZRqrJafhc/U0aoeRpuGTg+57kxrxojEJUxTZhE4xwAYEjRxkRJutI74rKPSLz9TgY3e1I+mImRwQkrAjzOO7Zn7OkQUJqZJWqImCtdMreDfVFolqesONVffNoD8+MggkVEVV/8R3RYHx7jShGDtSBF5/Iise+WOcCVnW4QTKKQeo+nZ0MOKducaPafQL60K/30SkvxMwPqouH2aIYBxyWoWcm6nHVYR6Nsx4m7+xskeUpQD9+omGkWImiwHhCVmtO21lOq3LnewfHQYKogSLXJd/AVDXyl+5leQpNWr0kQVtXIUkw51Vh8qg12DxugbZP9J8sYBz3rfXphZ9cuPxV5KGVCdf9817AvWLO09SxMD02U1DBklcTL7d PY2YyTLt mNwpq+ELl5/MGDhogv47ztIIdaUh0Os1ZOfMy7BfnKMjoPfP2M09wZXZ3tkAv5StMFHdBzC2tsGBH7qIescJzkwDNkYQisVO5/5tvsY3n7YzQz/hL2j+GWkJcdj005ZCxnjMl0Z59VNBTERGoDmbGIzC/+Q635xspR3QVG/mL2QA7nrNBjOo0VfpWYB7QpvAeut5Bc6W3D8wLyo92saU2NqGahPASWqcGHSOUQwTcb91tkME1xzbW/z9u09s3RBohE5kY13rvWQ0u4F11wuuwD22F4y7mkarEC8GMz0IdNmavxSryGG6TcBl5N6mw52RoDfWNsrUKVvYEZ1yNu9aI+r15snj1beKhjC3gFIlz2AVuNc7r8y1IkoE0NBA9qZRV+P/Z9+30zzcMrjaO+mTY+NinutsHQrfs1O/rOCS3oPFXt4B+uU4uqSKe1cbQZVO4evlMUpGthzj7u4OQpxsYse9wTlczmmtOicVIBESi3o/Ew9x2VKzBeFoMfktkok9hTJX4xzG9SERKr7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 09:03, Shivank Garg wrote: > Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create > anonymous inodes with proper security context. This replaces the current > pattern of calling alloc_anon_inode() followed by > inode_init_security_anon() for creating security context manually. > > This change also fixes a security regression in secretmem where the > S_PRIVATE flag was not cleared after alloc_anon_inode(), causing > LSM/SELinux checks to be bypassed for secretmem file descriptors. > > As guest_memfd currently resides in the KVM module, we need to export this > symbol for use outside the core kernel. In the future, guest_memfd might be > moved to core-mm, at which point the symbols no longer would have to be > exported. When/if that happens is still unclear. > > Fixes: 2bfe15c52612 ("mm: create security context for memfd_secret inodes") > Suggested-by: David Hildenbrand > Suggested-by: Mike Rapoport > Signed-off-by: Shivank Garg In general, LGTM, but I think the actual fix should be separated from exporting it for guest_memfd purposes? Also makes backporting easier, when EXPORT_SYMBOL_GPL_FOR_MODULES does not exist yet ... Leaving deciding about that to fs people. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb