From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E573EE784AC for ; Mon, 2 Oct 2023 11:09:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BD118D001D; Mon, 2 Oct 2023 07:09:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 545C58D0001; Mon, 2 Oct 2023 07:09:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BF4B8D001D; Mon, 2 Oct 2023 07:09:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2765A8D0001 for ; Mon, 2 Oct 2023 07:09:06 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EC87D40211 for ; Mon, 2 Oct 2023 11:09:05 +0000 (UTC) X-FDA: 81300249450.27.27E83E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B29BB4001D for ; Mon, 2 Oct 2023 11:09:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhKqSTkK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696244943; a=rsa-sha256; cv=none; b=hN1xnjpa5KMvVI+jP+bICq+VTEWocaevGnpar+HHcurrTxvM/Xv5zo5onTDlUQcWYYTNWD bqiDsiQesyrhEfsezRM3ijpWpxDp6jhJjvtfKdSzBiYvnB62/XzdMqB2B5B6IduGmCjVI+ +LDBn/QxSJpYpVhkmB3mwFcr5rvy/PE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhKqSTkK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696244943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gtgcf+hFLMW3q0sfoiNdr0OOcMu3cpe/tcYTwFuRDbE=; b=0+boI6+JG953WeSTGgL7id39IcGNqIMq2AYfY+EWgB0Cmo/d7kgDmFYFTUUQSZRKa55Fbs fVked4Ly9gFctaZPdP0ZvInI+ipCWXd2bl/jslW7yu/S7MX9jWDHCyyNeT1tevoZ6dy/Zf QlBiJylwgcr9NpO5r3rjtDx+6RlHc0g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696244943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gtgcf+hFLMW3q0sfoiNdr0OOcMu3cpe/tcYTwFuRDbE=; b=XhKqSTkK5wb5BFFK4thG8Ln2B2CYj7vNJNhuKD8ZnHxjiCZz9Skokn7VMOU8pxKer0av8w MuWlffkaIF5WqUrBYRY3N4eGL8PyoB/lXOEEIgziJbB5tRqd2gO5X5Jg0+qdFBOWhKyPhL WS+xh8+ERNr2V9pwgcg4ylWOlO/IiFI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-XWT5UgJQPx2KKcx7hoR8Yw-1; Mon, 02 Oct 2023 07:08:51 -0400 X-MC-Unique: XWT5UgJQPx2KKcx7hoR8Yw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4055ce1e8c4so12653285e9.0 for ; Mon, 02 Oct 2023 04:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696244923; x=1696849723; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gtgcf+hFLMW3q0sfoiNdr0OOcMu3cpe/tcYTwFuRDbE=; b=tt+diJYtSsRl4sldkU9/gIZm8jirjVKilnZ4PlDXZ4KKxeQOBykdmi7kw5ecYhkru/ Dz/plinmRvNK11t1xJEjJVMGiUzdxyBa7Z72SmMusxnoziioV8QLoJVRIHmF+gj+8Lwq j6HrfMQpj7OrQMdouj3GuK5pZ4yiofUj0Knb6Kn045aKoBWrOGoZW0B9fJ/mGcVQFHNT M/e301Vav18cyFBj00abyNmXddGTvlzr1yJtsgEgcluOAn2XmLiKILAn1jZmYPshojyd /vP/HTufw3QpxuUNT4ytYBIf8M0X4/teViOU5xm+477NfmiPgVSF/ZRT9s+zHKMo7mmO HQhg== X-Gm-Message-State: AOJu0Yxz6vrHUpN4LKb734/Bmb/m2ug8nbH1z09OAS0m9A6kLcBsDT6X jxOygYJg1b69XNyq3vmASxsdNER2oL5yBVMQUwqskeh3aXraBqy/OgkvGD+p9kKgs8R+/vekG/f q/7ejlMN/vRo= X-Received: by 2002:a5d:6e53:0:b0:323:2c2b:baf0 with SMTP id j19-20020a5d6e53000000b003232c2bbaf0mr9621464wrz.15.1696244923536; Mon, 02 Oct 2023 04:08:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpSIH9QMEPaTkwE3Pxv/GuJdWgAsIruJxlHcaN0BwZf/RLEKQjG7gDlDA8fY8072jNa2UhZQ== X-Received: by 2002:a5d:6e53:0:b0:323:2c2b:baf0 with SMTP id j19-20020a5d6e53000000b003232c2bbaf0mr9621435wrz.15.1696244923114; Mon, 02 Oct 2023 04:08:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id g16-20020adfa490000000b003232380ffd5sm19920471wrb.106.2023.10.02.04.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 04:08:42 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 13:08:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/4] mm/gup: adapt get_user_page_vma_remote() to never return NULL To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B29BB4001D X-Stat-Signature: hr6wfjcwfxy5brmdb4pzub6hgu6mkwbm X-HE-Tag: 1696244943-526518 X-HE-Meta: U2FsdGVkX1/ZoojZu76p9W9CNW8i3aE9Q3YVRocwWv4FEgAOp4D6CTyQu3NGTgtS4WDpulJV90O/oKdtbCd0IHHjaSuU9pERtrppNrexJ/7qt2uR4hpkpXcA/EtQ5D6c4esZPE24xQcfvXIduMbOrNUvvuZN0vl4cBaNStYrO41CskYDlpTFK1UTTiEP3V0ZTq2ANf62QFBOhcT3tUMJnMiYZEJ0XbFJJZ4dJoIyiIQHcxpEI/D/dyR3s4qKD89tc0A++V/tr9sXtYeond6ysK/yAzPporyY+lXco0bSO3u5cwSF8jpTyY9KXUADf5L/RADGekcUQLmp3medTLqB5qmFeIf5gjQ/dJDjfZq3w5oOPd5/wxOs6qAjx8zRZzFI9P1Q7juMHpkBp1eBwwjcqjvy1rUqjq5/GT1gdd2Oa2Nl5rQvSN/ktx0/nQxZ+6WAQnfDSrgepS70z9eQS2rXRuPs+mYngopXa8sgk9+IDZJIbmzEXbk4X3WhxVP9aUpEdATQlW7wuAWi6K6N8JpSSSdvRnYgATvgtcKuiJgCe0tJifNJpwVON+KTxWDkFG3HOKb8ZI5G6IqbnXfaCPhOXDJHB8tz9lcVr64ta2n8C0PY5jeFX7LrNjqzNHkUL3nwcXcwrtJ/+7UiKQsIPKMVIay7bh6jcYiMbhjZECa1wqudPAMYmvbFDDdoWDtPUUGhGaIZxgKdnre35BjBIKGFmc36MDi9kCgGuNYiinll5le5NCG4vRhIP95zAz2Ww9uV/MhauDSKFGLFoslLL15NzbK+hogIJ5sFSo55BYLH3XAHy8TLh2x1RFDLMoAmecWoJR3ul5TMp/hLRjC01vNzxSYAzVWNcJeshVgpz0n+sLH7MxwUtdnr6q4F1n5QrF79E35lzVu8YJ2jy53VzbZCQnZBeKOujY26cHxpPUwXk9R1bomm2cLq4A7fVY5MGK3B0a2EAVkGivN33YNAVB8 OzXNFlKO s8Dc7wj9/MpshR0auIU38LnI6SZro7dsH7SzudMA25XwcCI4gpEW7gY6oPUzwgoTGFd93VpNFz7p19bQxoviKJC33sRpC6QD0gilGbspa6xnzhG2TpkgyFhHPWfL6DVtfWBUhOVQ24d3zkmGIuuMun6RkN1BethQ47byYEgiXEn8mpTgrk1y3bOcURvRKPF1SJkmg5aAsGWHJhkQbn+xZlpVQuMKur/GNJ2m2VYCruujn+PNTd18arS03g2+UNeae4lOQYJ15+V4Iz7aSZy4a+y6RA9WlVi8wDI3Jz3wLZXb4ZpkGh24zk1pfaI/F5iz/5lMo26NMdbYDvVTn8bhQW06gaSMH9HVy+EA7jcLgNNLLESqvzaF00oz1Pp3VMvC/xwKeJodnFUMvtsST6Qm+1YpsP+8hdI3djwIOXdJ9LNSfrg6RqhNFkVRQznUQPEhES/bRoxkROzzLx48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.23 18:00, Lorenzo Stoakes wrote: > get_user_pages_remote() will never return 0 except in the case of > FOLL_NOWAIT being specified, which we explicitly disallow. > > This simplifies error handling for the caller and avoids the awkwardness of > dealing with both errors and failing to pin. Failing to pin here is an > error. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/kernel/mte.c | 4 ++-- > include/linux/mm.h | 16 +++++++++++++--- > kernel/events/uprobes.c | 4 ++-- > mm/memory.c | 3 +-- > 4 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 4edecaac8f91..8878b392df58 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -411,8 +411,8 @@ static int __access_remote_tags(struct mm_struct *mm, unsigned long addr, > struct page *page = get_user_page_vma_remote(mm, addr, > gup_flags, &vma); > > - if (IS_ERR_OR_NULL(page)) { > - err = page == NULL ? -EIO : PTR_ERR(page); > + if (IS_ERR(page)) { > + err = PTR_ERR(page); > break; > } > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 7b89f7bd420d..da9631683d38 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2425,6 +2425,7 @@ long pin_user_pages_remote(struct mm_struct *mm, > unsigned int gup_flags, struct page **pages, > int *locked); > > +/* Either retrieve a single VMA and page, or an error. */ > static inline struct page *get_user_page_vma_remote(struct mm_struct *mm, > unsigned long addr, > int gup_flags, > @@ -2432,12 +2433,21 @@ static inline struct page *get_user_page_vma_remote(struct mm_struct *mm, > { > struct page *page; > struct vm_area_struct *vma; > - int got = get_user_pages_remote(mm, addr, 1, gup_flags, &page, NULL); > + int got; > + > + if (unlikely(gup_flags & FOLL_NOWAIT)) > + return ERR_PTR(-EINVAL); > + Do we have any callers or do we want to make that official (document it) and use WARN_ON_ONCE() instead? > + got = get_user_pages_remote(mm, addr, 1, gup_flags, &page, NULL); > > if (got < 0) > return ERR_PTR(got); > - if (got == 0) > - return NULL; > + > + /* > + * get_user_pages_remote() is guaranteed to not return 0 for > + * non-FOLL_NOWAIT contexts, so this should never happen. > + */ > + VM_WARN_ON(got == 0); You should probably just drop that. Not worth the comment + code and its better checked inside get_user_pages_remote(). Ideally, just document that behavior for get_user_pages_remote() "Will never return 0 without FOLL_NOWAIT." -- Cheers, David / dhildenb