From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6787FC3DA7A for ; Mon, 2 Jan 2023 16:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BFD68E0002; Mon, 2 Jan 2023 11:10:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 070828E0001; Mon, 2 Jan 2023 11:10:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7BE28E0002; Mon, 2 Jan 2023 11:10:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB5C58E0001 for ; Mon, 2 Jan 2023 11:10:47 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A5D031A098D for ; Mon, 2 Jan 2023 16:10:47 +0000 (UTC) X-FDA: 80310347334.18.B90F0EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A947640010 for ; Mon, 2 Jan 2023 16:10:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dDUJqyiT; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672675845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0NmhDSiaQrrVJCMvGRbMDi8tVjpwlzfwkqxg2mnsE2c=; b=nuXns+z6Q9czpY4z60HPfNxR80kEXBsYIzKy347wQ0Vm/QPPso3M2JKhAOi3mPyX4DtG/f N1iCDkCLk689XgCZkFDBPfmztjrAngAHXw9hggf3dqLE7l1pI13eotcktgkO7r+EeB4Rra G6amiO2/OoQxNmQ0NNAo1iVYnKs7cpo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dDUJqyiT; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672675845; a=rsa-sha256; cv=none; b=CyJC0OvUVjXmesmb6B9fDUejjJmkhhydX+wY1rIIIVoY65fAUia+7m7XB9IYulKB60gXQA kPRbMplZP7C1VS2JwZPu7MqID0asNCs6wpG8TsnSwha54VYX3QcPS8A1t/dNXV4Nz/U2DW y81LBxg+MDNB0GXb/9XPeLS38vrcZEA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672675845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NmhDSiaQrrVJCMvGRbMDi8tVjpwlzfwkqxg2mnsE2c=; b=dDUJqyiTFnGuhoBgxOzTEOr11QmceXbZ4DU8aXAOAod11Gth5FC7U1XS15ots4jPvZ8rXl SVhUozAwee83AS/Z7EXzwR78WWgSylLhzd9ROzYanIfsBwC1aZpg6debKmoIKzVHrk2XLd ZRC49ItQ8ICIeSNbQIPQd5n4t0OkxBI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-503-xxML420xO2u9IhLnVLxUVQ-1; Mon, 02 Jan 2023 11:10:43 -0500 X-MC-Unique: xxML420xO2u9IhLnVLxUVQ-1 Received: by mail-wm1-f70.google.com with SMTP id m38-20020a05600c3b2600b003d23f8c6ebdso10516059wms.0 for ; Mon, 02 Jan 2023 08:10:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0NmhDSiaQrrVJCMvGRbMDi8tVjpwlzfwkqxg2mnsE2c=; b=ZAts/RdBj0zAdT5vnL68RUjxECIRganLvizqGjnMuCAX49F0mMZk6TCKe4Xs8YGPcW OKdJr3LLAUekh9I+5e2baBHnJs4mC32HGXJy0ii59FCKb+19P3o95xN8b+CtcCS/HcZJ GE6JeWSEMRXJjxPNOPMEEehn77dawojPtSsCdCgRYvdVwIIBHVeYIax9QZXFqJ9qs255 2vykNko3RMqTpcot3klIQHn2nEqANe4yEgVwfaMx0e1QTKs31FX9qD+zwHZmCXOGScfT I29sj7/a9rH/KjzTEGlhn0V0FJDSRaqyGlCwLFoteWoNK16M+G66ungcQM3P3vlE+wH6 8xBQ== X-Gm-Message-State: AFqh2koXztrMHnEiRa5ER9N50ILCfxxFezsKVzDbdZWjBWs8ZSgklTUK ulNVx8NOuwn8HLfTqvyrEn06NLwgmHWnwfe9I9vU+6hyAjqM2hWfVWeXIZxb4aQBr5vtsZUAUGV 2jYXVrOXHVXI= X-Received: by 2002:a05:600c:4920:b0:3cf:7514:a82e with SMTP id f32-20020a05600c492000b003cf7514a82emr29615536wmp.23.1672675842678; Mon, 02 Jan 2023 08:10:42 -0800 (PST) X-Google-Smtp-Source: AMrXdXskldjRSYhz4SR5xTIRDebGy49uwim8uWpYjsQBMgXFHdXu5r42wcRaBTeTwn2Jjj3Ngw9FZQ== X-Received: by 2002:a05:600c:4920:b0:3cf:7514:a82e with SMTP id f32-20020a05600c492000b003cf7514a82emr29615513wmp.23.1672675842475; Mon, 02 Jan 2023 08:10:42 -0800 (PST) Received: from ?IPV6:2003:cb:c703:500:9382:2e5a:fea:8889? (p200300cbc703050093822e5a0fea8889.dip0.t-ipconnect.de. [2003:cb:c703:500:9382:2e5a:fea:8889]) by smtp.gmail.com with ESMTPSA id d9-20020a05600c3ac900b003d973d4fb28sm33175942wms.4.2023.01.02.08.10.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 08:10:42 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 17:10:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Jakub Matena , Matthew Wilcox , Mel Gorman , Michal Hocko References: <420e491062db9151504aef5661c8a2d928ef6bd7.1672675224.git.lstoakes@gmail.com> <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A947640010 X-Stat-Signature: c8ttu4homc3ibs5h7dgh9ejpj9a53hzx X-HE-Tag: 1672675845-442724 X-HE-Meta: U2FsdGVkX193ldS5xPI+Ot8rNpEWI4WKNTKviWGYvRgxQTQvq7VQu3MBMmXTozkC8xm0w3Q0ROeFZewdOuLDfcSR+VEWeDwgbf2aPY3ZFe5bLM9M94CVEGoAfJRVffjD/T/i4lEo3SkyF8Nr7/LO5/5YkdbTi4Dl3Q20Aj1WRJGzLqz86e/fESNiL4oSPMmySFDFHTckJmIcXqF3l0gZzCf2bbjDhIZ2/O+F8KFAN4BcMBXuir6IFaECwfzYGUgOmZ0GuRo/LETgifBhew5j0WSX+/RaS7zbDgqX8P77HBhJg3I6F7iLh5GePVYmLSEH6hCZVnY3MMK1eFaz2M37ds5pLMbI7AU7hSPvjCM6kN2AnTqMhGcG/EAdVGpu9R2t2jRGS8xu151z1BFa72sOqKByUg82Gc3F+EXkDZN+x9rVt4IuhSZzGMCKfTbYgXUZAifaTaK7zF46DpKQm+0jFfLRos3ajV3DkF/ixy68Pru6V8e/pfCPPrA0ek/84QypRgsua7jPrq141c5mCBjs8C6AFbfGQDNM7o/PLq9x9u8P/G3xTfjLq96oddQYKWtAIO3Q7hcny16ellsJELLuC0NiRsIC89fHc/zATd6ma/z8AIrsiI1mbST5Re/OZMt8V5rQPCUQPeazsImZM4eQFnyWHWbXsWIUwxO3W99bbQDhXAxKI0jY7u6qddI3Z9Bmt7WyOO5Y2FvKeT9jNWsucTNKbuX9SNFViNjqNTHUJyxARkc52MwlUoNtCKWkovHBsZ+KXbHObFrV7Q+TQkg7JnJuoEiukS/AqFg1U9R6543ifMZL0EtGcxocwiCP6uXr4LwSpWMBBW7euuC/gApZuuTj6vtWxvfil5d9SiMvDD3ojOdWpUdcXKMlzLXEvJ+rAO0NyITBuisENZR1lOMAVFZ965MIBspV2kk1GuzWgfNoKisT8cCc0FBQQu0OUP2YpaciWoIUYTQ6vm0z1/V Gn6P5yjj mMQSAEM0kIsi8CzImbB0qjI0W21Pukt4ysTGIuTUPE1JiWfnFl3Ub0dEvZIHVASq6eFuqV3wFolW8yjOm9A+kpoA5U+Xz1uEM/R5h8X37F/NOYe5DygSETu+pilHwWUuKJsmZemc4AlVeLys= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.01.23 17:09, Lorenzo Stoakes wrote: > On Mon, Jan 02, 2023 at 05:03:31PM +0100, David Hildenbrand wrote: > >> With the exit() in place, the else branch is implicit and the else can be >> dropped. > > Good point, we'll go to a v4 then :) that does neaten things up > actually. Hopefully this should suffice! Maybe wait until tomorrow for feedback from others. Make sure to include my acked-by. Thanks :) -- Thanks, David / dhildenb