From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Greg Thelen <gthelen@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] mm: oom: Remove thread group leader check in oom_evaluate_task().
Date: Tue, 18 Jun 2019 22:23:38 +0900 [thread overview]
Message-ID: <f2960ffa-124f-b66d-3bfe-cc9302d43797@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20190618121418.GC3318@dhcp22.suse.cz>
On 2019/06/18 21:14, Michal Hocko wrote:
> On Tue 18-06-19 19:20:57, Tetsuo Handa wrote:
>> Since mem_cgroup_scan_tasks() uses CSS_TASK_ITER_PROCS, only thread group
>> leaders will be scanned (unless dying leaders with live threads). Thus,
>> commit d49ad9355420c743 ("mm, oom: prefer thread group leaders for display
>> purposes") makes little sense.
>
> This can be folded into mm-memcontrol-use-css_task_iter_procs-at-mem_cgroup_scan_tasks.patch
> right?
Yes, if we want to do so.
prev parent reply other threads:[~2019-06-18 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 10:20 Tetsuo Handa
2019-06-18 12:14 ` Michal Hocko
2019-06-18 13:23 ` Tetsuo Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2960ffa-124f-b66d-3bfe-cc9302d43797@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox