From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8ACC36014 for ; Fri, 4 Apr 2025 13:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDE28280006; Fri, 4 Apr 2025 09:15:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D0F280004; Fri, 4 Apr 2025 09:15:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D077B280006; Fri, 4 Apr 2025 09:15:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B37F1280004 for ; Fri, 4 Apr 2025 09:15:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB71D1C6C31 for ; Fri, 4 Apr 2025 13:15:03 +0000 (UTC) X-FDA: 83296406886.12.0A1CF4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 4BC0140016 for ; Fri, 4 Apr 2025 13:15:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q6xY8vMO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743772501; a=rsa-sha256; cv=none; b=Mx0uw3wwfaEx4Njp/0iLNOQRO1zmdUoOjuFZ2uLAOuo3Q+Pu5Ng3b5TPKGQ0QaUBqrr3uZ CG6B+QFNSB7tFirE2shjR+0OYV4SaR8/9kmLjR5gN9gMzr40NSQCw9koCoBmpPWxvlnRXt XsbdhH+4I9mQr7i3rmtkKY8YjiLBdIQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q6xY8vMO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743772501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tH/nAZaQYAUEjrfNhy9sHHGSOGo2HXmsmBYYGxcbGak=; b=mlzF8IFptQdEsupZ0T3l+Bxtvik2R8EF5ra24DJqzDFze7TIY3EzZFs3Dhb4PJ1E8mDPiS KbXslan2QJhaS0SSRf2Qjd6pc7EjAip/ffJZEXa/VhgFumQvQIPx/1Lg8eRDrA+kRXEMoB a06fc78psygQ2PTser1Wj/b+7L2cJ8g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743772500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tH/nAZaQYAUEjrfNhy9sHHGSOGo2HXmsmBYYGxcbGak=; b=Q6xY8vMOSJp6GX1HWBU8kgiWwhQ/Q7+I8pRYwlDp+VxtdBSZ1v98f/lUllTLFaa3amPOqb PdeIwvntX61hBw1lRSFw+KHEBC6LX1d0101DMHDFCId7UQe0DP/Kil5Fr14BZMVEkSZ58L JSFc6AVoF+u/C9ZF9pcDynH67It84L0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-U47PecojM_eqM2Au_4N0rw-1; Fri, 04 Apr 2025 09:14:57 -0400 X-MC-Unique: U47PecojM_eqM2Au_4N0rw-1 X-Mimecast-MFC-AGG-ID: U47PecojM_eqM2Au_4N0rw_1743772496 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3912539665cso1658231f8f.1 for ; Fri, 04 Apr 2025 06:14:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743772496; x=1744377296; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tH/nAZaQYAUEjrfNhy9sHHGSOGo2HXmsmBYYGxcbGak=; b=GOsnCPr2CI154tQiTkGZe1QU8b+bj9GdBN2cf7L95rLCcPXiu4kzGl/TaWCxnqwg3o zscNRa8JDTF3lwLrv7EaCqbbAD1YUngfGXR0CM1SOeDlCSGrUw6H7bxOe8aW7Nx2bmkI oCAQ00iDdXm0La+HbBz6CyBdZrZd6EwB/veAtyYXDczslWsG0aHOSCmBR2hdwEyGaEi7 iqIvgcs6lIcJF/aez4xdk3c1U+vORTrkDzU251aqBXzLWRXaZREUVqcd20QCqvHD3yuC /ze/h7IPxhmazDcCWtp6VLNrrj++W/I98BOD0mvYWWPt3mBYp41lrTTrC6ExrNgjL1d2 b3lA== X-Forwarded-Encrypted: i=1; AJvYcCV8btgtB84J49vzRYf5mIqM3N9nxs9JpMQ1xzoidMmaJmjaFYj+zO52D2j+xjPcthsQzcCXz3C2CQ==@kvack.org X-Gm-Message-State: AOJu0Yxsz/D1YzL0uiZ71XnDqHnvyfjXWd+nMGccTRhdwI8BbUJw0vx6 Nli5M8qAA3P5S0Hulo2zIUpes0hfhfrvJvw/WrykaddiPPOLjXzgXZc4/uMxYu1liGlofBoPNei NRItlwwAS5ZGOzwQo/OICrEi7pq1/WhLy+0azXymYCyzEGkm/ X-Gm-Gg: ASbGncsCWZzyPNcwKyZRj2YkdTByIgSSlL18nQ11yZNwS1vIPDuuaZILedZpIXKzKnH hffUzIw0noA9jU9zWgCYDD17usbNMIyp28UfYMdYsv6FT2bDVINM7UDU5lpSnFImxwCiq9ATR0X kEQJCx6vDUdWrhNMTWHE/iR/Hj56FzRR79j+zy8OAyCn0o4LZGGlMk3SErz7TG9aZDg/cjRW0Zz XH7AeNsmaYb2GujNc9CZsTEfR5goAku9lEzdWGqZo+3vKNowP1p81zyefOxV8pt9pRTVgUuu1lN KtZevJ+h0XtYYYfbHVev3fqmDVFbF7Ua3YrJv04Pk4qrX/bQDJ6SFWGMHVyrrk9yEz3+rwx3DNu XAxWSOoNNNu7p64bKnbcJRG9UphXF+KK9t0ojrjLzeL4= X-Received: by 2002:a05:6000:2511:b0:391:386d:5971 with SMTP id ffacd0b85a97d-39c2e6221bcmr6688870f8f.14.1743772496104; Fri, 04 Apr 2025 06:14:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhpWP0+tSryE/F3HrLI6J9Dy/kxt4ga6GvbmOj8N/pwCmdRImjCHfTs54PUopmUXbTvP9ydw== X-Received: by 2002:a05:6000:2511:b0:391:386d:5971 with SMTP id ffacd0b85a97d-39c2e6221bcmr6688843f8f.14.1743772495734; Fri, 04 Apr 2025 06:14:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec366a88csm44791195e9.37.2025.04.04.06.14.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 06:14:54 -0700 (PDT) Message-ID: Date: Fri, 4 Apr 2025 15:14:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm,memory_hotplug: Implement numa node notifier To: Oscar Salvador Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, mkoutny@suse.com, Dan Williams , Jonathan Cameron References: <20250401092716.537512-1-osalvador@suse.de> <20250401092716.537512-2-osalvador@suse.de> <9d5567ee-8c48-4fbd-97fd-d13f28325621@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x9uLcOXYxhbn4wb0oj0o-ZVCEois1XBolqAfpMjqs0g_1743772496 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4BC0140016 X-Stat-Signature: eqqarjkyxrgbi9ibyka7dgagooxhsraa X-Rspam-User: X-HE-Tag: 1743772501-192882 X-HE-Meta: U2FsdGVkX19qtu7hqU5mejI1uKtewEZWq0zzwA3/Zm1j2pLPCmwFOUs4sKBtrvJdDlTGe2zm0T60aNGFSdVUdtJYUSMYmfz5M4R5YQ/V18opJ0EjDelpjr2Av/L2WIC271RciGjTr6P9umbzphBnHNJEZ8OfXflHgIWu3JK9DVbFnsstrb41hj8ZM93uN1df4WnycNBu1Gdzr2VkrKJ6y1kVd5MBQ0v70BlXmz1g5KzWgScfI54D8fevM0RicM1N4t/va1qMzavC7xt4qcHoqDxLg2ISPdG4Crh1cCppaS5TbvY6qx3dQKW6gDsUMJ3AaWsTdXmcNVD6S7STGqP0Vaitqoun79UeM5KrCeUtQG3Cfl5gcs5+sA7dfTlPfLbV54DT66VJqrUkjAT6DAlWeYZmmALQCMNPqRiYXsUDctNIA3gp4G6zu5wPqA29BYALi3Zb0xBwh/1nETh13HLyNw8ZRK9zfyMZ4TDTFy1zZreIjgQOH1HK8M1G+uTxQnSXMjHoKe0IESMHVN2v25DxR5mGaVxxHJ00WOuKQY0yoKo3Bue/K5ZTomqfpIPTRcWQYi2h7Guweoq5Lrw0jRCb6lPxCiMPOMYEaVRuklWlDhwc86jBlgQUl9QAk+rkIRzaIkt/etHv5krkFPrZ5+0t9obnZUoP50DVgcw3/pzzznjS30731q3GqG+taJXC9hhBOA8Bm6Nr54xXKPCSKsfydoiaddYJRTculveoUfyVqolD5QtFCT96eeKm5bFNYTVnEZq42Us3QNqNDO71NtMi7Hpr40XEc6DsPSQP2ZExgrk7IqD59bpZdpImicWFTxY5VEsq6YzVG7ekd191yHGaMo3Q8TXvm3e4XmuL6FAmQu2NA8ZH6Kn8SvFbwuVQm7Xj8DzfkD2dGJaBiEn4wxTBmoGcp3xMKQvkj8eZVCgK1QP45x1q7FmdKxErzByRQPm33p7jQ/iW6WrTVHx3gF8 VmI4kRBX EJCEWJxds07BRaWsp1T5EGFxsUqGcWxQ8jE4t8hQ67PsYQbnzRxO+fYmSkTMpNwZBJxJp6atUi2whQxs7Z1ruoqbtFOGSQjNGuoxmjfwclNbbhIX2+wpaApKmdhG8CgsbjMb9CBIYueWoGj5J5pRIeP53ydvBEwniqKJtR4DsWOxkuj71zlhTsCIA5045nMWbp/SeNccHnMHrZafxRAT9LrdK9FwAIs2kJfe33OZFzkfRHAYNvXnXKXcLnDFCp47/g54okwfYu8QieE4wrKVX5o2uwYnEpuOQE16Nngv3zoaG0MzE1Uq8tSDaW+0H2DTAJ8feHDT+2EWe6pmu+PkjhtjiS/5KejJQ57z7Hr8MJhv23EXx/w814cL+mHu92wAF7+RgKMuvvTU8CXyuoVdlVutbVSH0OSmcS/yk9sKP4uR0GBmhZ4+c/AgOhHnvxi7H0N/VLVw6iYzffc2YGX0lrWcDXURP3cJqdXqatsrrU7SID+SXLVlxwi5Z0e8Kl5ATDdT8AZaeiYaTJjU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.04.25 14:56, Oscar Salvador wrote: > On Fri, Apr 04, 2025 at 12:09:39PM +0200, David Hildenbrand wrote: >> Assuming we can remove the _normal stuff and we can do what we do in patch >> #2 here already ... meaning we unconditionally store the nid in the MEM >> notifier ... >> >> What about extending the existing memory notifier instead? >> >> That is, we add >> >> MEM_NODE_BECOMING_MEM_AWARE ... and trigger it using the same notifier >> chain. We only have to make sure these new events will be properly filtered >> out (IIRC, for most we do that already). >> >> Of course, the range will not apply to these events, but the nid would apply >> to all. > > But that would defeat the purpose of having a diferent notifier for > those only interested in node changes, which is not having to bother at > all with unrelated notifications. > > Yes, the handling would be simpler than it is now, but honestly I still see value > in having them both decoupled from eacher other, I think it is cleaner > and expresses in a more clear way the change of what the consumer is interested in > get notified for. No strong opinion, just a thought. > > Unless there is a strong objection, I would pursue that path, getting > rid of the _normal stuff for slub along the way. Yeah, getting rid of _normal and just have a "nid" will make things a lot cleaner. -- Cheers, David / dhildenb