From: Vlastimil Babka <vbabka@suse.cz>
To: Muchun Song <songmuchun@bytedance.com>,
mike.kravetz@oracle.com, akpm@linux-foundation.org,
david@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com
Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*
Date: Fri, 27 May 2022 09:39:41 +0200 [thread overview]
Message-ID: <f25c03d7-d9e2-2ae3-4dcc-0d054a15ad2c@suse.cz> (raw)
In-Reply-To: <20220404074652.68024-4-songmuchun@bytedance.com>
On 4/4/22 09:46, Muchun Song wrote:
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -188,7 +188,7 @@
> #define RESERVE_VMEMMAP_NR 1U
> #define RESERVE_VMEMMAP_SIZE (RESERVE_VMEMMAP_NR << PAGE_SHIFT)
>
> -DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON,
> +DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON,
> hugetlb_optimize_vmemmap_key);
> EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key);
Hi,
looks like just below here you forgot to update:
static enum vmemmap_optimize_mode vmemmap_optimize_mode =
IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON);
so it refers to CONFIG name that no longer exists?
Vlastimil
next prev parent reply other threads:[~2022-05-27 7:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 7:46 [PATCH 0/3] cleanup hugetlb_vmemmap Muchun Song
2022-04-04 7:46 ` [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions Muchun Song
2022-05-31 23:47 ` Mike Kravetz
2022-05-31 23:58 ` Mike Kravetz
2022-06-01 9:28 ` David Hildenbrand
2022-06-01 10:48 ` Muchun Song
2022-06-01 10:49 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled* Muchun Song
2022-06-01 0:01 ` Mike Kravetz
2022-06-01 9:29 ` David Hildenbrand
2022-04-04 7:46 ` [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Muchun Song
2022-05-27 7:39 ` Vlastimil Babka [this message]
2022-05-27 7:47 ` Muchun Song
2022-06-01 0:20 ` Mike Kravetz
2022-06-01 9:32 ` David Hildenbrand
2022-06-01 9:54 ` Muchun Song
2022-06-01 10:10 ` David Hildenbrand
2022-06-01 11:56 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25c03d7-d9e2-2ae3-4dcc-0d054a15ad2c@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=smuchun@bytedance.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox