From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCE8C10F0E for ; Tue, 9 Apr 2019 13:44:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 860532070D for ; Tue, 9 Apr 2019 13:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 860532070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 235786B000E; Tue, 9 Apr 2019 09:44:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE106B0010; Tue, 9 Apr 2019 09:44:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0393F6B0266; Tue, 9 Apr 2019 09:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by kanga.kvack.org (Postfix) with ESMTP id D15006B000E for ; Tue, 9 Apr 2019 09:44:11 -0400 (EDT) Received: by mail-qt1-f198.google.com with SMTP id x58so15875628qtc.1 for ; Tue, 09 Apr 2019 06:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5+Z7yNBBWtr4V3bYce4dDkC3S3mdH2ZTNVcAOlvXRdk=; b=KxewK1wU83kiircl3QwGCj95zf3IzOtiINN9UA4sMn9O9aSK2a6Pr0SbQn+nBjlQyJ 2AeSlP4+HSePe1H+jzyoJYDljBCI7NWrH07IdGSGASobfsDXCGvMgi9ROEPhgW64TnTy iny8w1KvoslcCJX9qcT4NOlN/ffRhgfqYoJF+F14bEC2ptVUrHy7bgzgwzuQLTkDNbTA kWffpQEDJfGIfM9hXIofrRj37ZE1tjUl3rQgx8nzNwAKzzpNabY5E+mol1CRh51XdPmN xIPshs71gJTEaXc9iACZ4uyLtPv8rWFqn+3ptiIun45t/uBTaSZ2Jf1WxqcCB9iZYlmR xLag== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAVD67k5DwDtJ0NQr6qhh4ttfHCLR6vzdxsm2HkSQSXU/PXmAQAQ IUKxEEfzQuKV4glWj2Mej8n9uX01f4Ut4j62Or8QbZxORJqL6zj+yEVI7sKXP+8HzPGHQx3mn9F O4hpYQ6WFOD5Rii7nKs+Qxo0PRMWHu93Ku6j+tzVshiBd/7WiBw0J00pnYmZyhunkCA== X-Received: by 2002:a05:620a:1429:: with SMTP id k9mr27174216qkj.238.1554817451569; Tue, 09 Apr 2019 06:44:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfgGA7oB68/g+s0H9cWvFzMe5pb9sS674tLaPXxecF/VjaSTjUXkhwuf10OlIQdgCDgBwv X-Received: by 2002:a05:620a:1429:: with SMTP id k9mr27174187qkj.238.1554817451041; Tue, 09 Apr 2019 06:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554817451; cv=none; d=google.com; s=arc-20160816; b=iuYWJStVqh+Gq0I1jmmd+LkknQD+kyOm52x7h3NRozpxysMOI4vpzwQtN2Yf1/IFWh JZTOIv/G166G78JTyaZVHLIrnBl6gt7fkyA6QMbs0uaOz7PpX0JqywKUVNjxyLcbSig8 2ASHz4C24oAgc2yL71G+G9b7Hsxd0FrAwXKjkoRa7gyndglkIQJSUUrPqAjSCIN1Lz53 lNA8aId+JLsy20YZsO2owbVF+1sV5osy7Cx2/e9nvSqYirNMoxWDUj8gXbIZcOFGM32F P01D8rLgmtNw4RFmgz4bJEvQXBUanzHYZr9Z1erwGkoBGISzISO08qQkDX4Lazb9H4/9 wWHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=5+Z7yNBBWtr4V3bYce4dDkC3S3mdH2ZTNVcAOlvXRdk=; b=MGYx40sR8VhJwKt1Lx4MRFjHRDBS4V8hsbHZIFTztdmP03OBTyCaIigLCgs4gQmi2F OIh2Ma5MduyhZQeMoS1RLOX+mpFfUX7EssQpkaHjgYgolsAXMrsBBNijh6OQDp2aEk0X 9TOY+MO+6qXu648yYqkIbW1Bk7XVqKXexbC1s7Xk2fdsstGoP4edRIZ9gxIwS1CBczou mix2bPVSxLDvEZkwPHqtVMw7iMoF7pPBunB2FF78PbvVynfDa/wCgcHebdwowG2yF6D1 eVuQzu729ZGZHe33oRMup9H3qq4yrd3C+xPhdjUATFzns/FbhcAjO9ZirMkkdknvuzIo PsiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id y35si3030889qvc.84.2019.04.09.06.44.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 06:44:11 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B95313A5C; Tue, 9 Apr 2019 13:44:10 +0000 (UTC) Received: from [10.36.116.33] (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23BA917996; Tue, 9 Apr 2019 13:43:58 +0000 (UTC) Subject: Re: Thoughts on simple scanner approach for free page hinting To: "Michael S. Tsirkin" Cc: Alexander Duyck , Nitesh Narayan Lal , kvm list , LKML , linux-mm , Paolo Bonzini , lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang , Rik van Riel , dodgen@google.com, Konrad Rzeszutek Wilk , dhildenb@redhat.com, Andrea Arcangeli References: <20190409092625-mutt-send-email-mst@kernel.org> <43aa1bd2-4aac-5ac4-3bd4-fe1e4a342c79@redhat.com> <20190409093642-mutt-send-email-mst@kernel.org> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Tue, 9 Apr 2019 15:43:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409093642-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 Apr 2019 13:44:10 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.04.19 15:37, Michael S. Tsirkin wrote: > On Tue, Apr 09, 2019 at 03:36:08PM +0200, David Hildenbrand wrote: >> On 09.04.19 15:31, Michael S. Tsirkin wrote: >>> On Tue, Apr 09, 2019 at 11:20:36AM +0200, David Hildenbrand wrote: >>>> BTW I like the idea of allocating pages that have already been hinted as >>>> last "choice", allocating pages that have not been hinted yet first. >>> >>> OK I guess but note this is just a small window during which >>> not all pages have been hinted. >> >> Yes, good point. It might sound desirable but might be completely >> irrelevant in practice. >> >>> >>> So if we actually think this has value then we need >>> to design something that will desist and not drop pages >>> in steady state too. >> >> By dropping, you mean dropping hints of e.g. MAX_ORDER - 1 or e.g. not >> reporting MAX_ORDER - 3? > > I mean the issue is host unmaps the pages from guest right? That is > what makes hinted pages slower than non-hinted ones. If we do not want > that to happen for some pages, then either host can defer acting on the > hint, or we can defer hinting. Ah right, I think what Alex mentioned is that pages processed in the hypervisor via MADVISE_FREE will be set RO, so the kernel can detect if they will actually be used again, resulting int 1. A pagefault if written and the page(s) have not been reused by the host 2. A pagefault if read/written if the page(s) have been reused by the host Now, assuming hinting is fast, most pages will be hinted right away and therefore result in pagefaults. I think this is what you meant. Deferring processing in the hypervisor cannot be done after a request has been marked as processed and handed back to the guest. (otherwise pages might already get reused) So pages would have to "age" in the guest instead before they might be worth hinting. Marking pages as "Offline" alone won't help. Agreed. -- Thanks, David / dhildenb