From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD68C3ABC9 for ; Fri, 16 May 2025 09:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EFF16B010C; Fri, 16 May 2025 05:18:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79F5B6B010E; Fri, 16 May 2025 05:18:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63F9E6B010F; Fri, 16 May 2025 05:18:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 456806B010C for ; Fri, 16 May 2025 05:18:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 83CBE1D2C35 for ; Fri, 16 May 2025 09:18:35 +0000 (UTC) X-FDA: 83448220590.03.CFA3DF8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id EC935120005 for ; Fri, 16 May 2025 09:18:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TjpcEnh2; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TjpcEnh2; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747387113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BnyL+8xhsHOx/hwMbuje6f9Jmtf+N+7ay81zs9ZK45E=; b=e0J/QdRAzRAtNG/kstIu6z+qh5L/GqSWUJ8tU9aHLBHrzJ1i7FXhVZkEfUsm4chI8sYJgK 15P3GX7rVsb13lclCyIGtbdqWVwSH3TJD4wpDOavBZbnTlhtvk4NLLUZvbdxEkw2mPQzo4 AqJ4pIVSPsovZDKTKK21QX4l200tk4Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747387113; a=rsa-sha256; cv=none; b=PrYoGgHC3uv9V/tLttvmCMR2CPADarVdj/Iv4215dYHvSoYGzpvxxC8H50xrDls235qT1h o1v8hRVCXybMqcHoWnkvS6r+KBYaHP2giNJ75s9+OHwdpjjgbDQWQcOQCx770xBrXB1U0f 3BvfCDwsD16+Bri16HTJF9X9kNPP9fw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747387112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BnyL+8xhsHOx/hwMbuje6f9Jmtf+N+7ay81zs9ZK45E=; b=TjpcEnh2MX69AMkuaVuufzD1xxn+JTQL3ECjXTedu+Bc+55OxuN0XmcHUQCYioFlxIaR5r zen1rNEbJcwdCK5hTB+GnSSqQEeYmYgco/4rv3+yh/CHIOKWpgwE18BQNMEdSraVm+SzuH 6uTZ8bhhBFXLUw1fYOi7LTvFye8BC7Q= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-Z7Ng4ilzNBqgSn3Xsd4Q8g-1; Fri, 16 May 2025 05:18:31 -0400 X-MC-Unique: Z7Ng4ilzNBqgSn3Xsd4Q8g-1 X-Mimecast-MFC-AGG-ID: Z7Ng4ilzNBqgSn3Xsd4Q8g_1747387110 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a34f19c977so915802f8f.0 for ; Fri, 16 May 2025 02:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747387110; x=1747991910; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BnyL+8xhsHOx/hwMbuje6f9Jmtf+N+7ay81zs9ZK45E=; b=fakLxdDvDgUOkKtth/kRc50jITybTmj4ymLVrS/YpFSCmvblnZGYsgVLjM3Q3wTVsL t31c7Cnf7zRx7TLo3wzlKWwh4fJ1FSkHeZF0wLWmNKXBdFPBwMtsA4FFXMl6vJToopSS SIbmB4PcTVhHnTTRbhExDbAMUf/PuaK/uGQZGKh93eWXOGZADTnnOKmWsTuI3S526Q9g hxEzSSYkOTg/2TGfKzrDL1VFG6RUfqRu+7wJZq836YjR6IvJKAn2TFygAS4XhAk/eCTq IeTPWxVORkDXDY7lbuoDMqyS4dFnWkwvg18/9hKJ7uNCD0ojUsDA+nMNj9zB22Ejx4mI Pw/w== X-Forwarded-Encrypted: i=1; AJvYcCWqtF78/rXB+2n3MMEn8bhLjAGFWyDqh5kYgxoTu48YUxSvErjQHycMk8LY3CjbozM9fjb/JFT6dQ==@kvack.org X-Gm-Message-State: AOJu0Yxj3/dWhALewni7kb9+IbZDLvOPPGb3+3TkWXyC/dxVfhXIcpiq jVZ5dwbBfdyAH3mNadOCC6cBB35rZON00cIu2QVrs+VR0u0Fa7p2XIE7903ilhcKuei+WZwKmyN +CQIggWf9eq6TiqTWo4SAzQHf8ChF9EHM4imjvdaq61E01iSXK0PI X-Gm-Gg: ASbGncvc2ntYr631AuYgj3F+hfS0hxlEyLJ3shYCbLlqTS4valQjIiT47P/Rd2bBa7w g4zz3V3bR89J9XBnJzOv6r8VnVYeMXiRxlUW8VDVmyvYzOszYJ8TsnS1thDCiRu22zL4ajVIlDd XK6P/y3w+Yzi7Z7uUy2layLDgjQzHQha+21uYYLhpZ+Ac4slqmsdNLDg6lw5SlLQZliKehMiV88 yMJYUh0cVNWfUoD+BdqHk/JNwfnqwae8E7i5yMpny4KlJRxjx89repJCrTW7/qpdcT8GYMOGjfG tnYE1cAQv63bmqkrs3X8PPlJBT7nk6UH0CBTzIpaaBaOzBd+LwkWTLsXvhM9zHRDfiLlhcnTQyS xLdTQgfDYpY/TfLJKCFQPJhFJItjteymBbVq80Ac= X-Received: by 2002:a05:6000:22c5:b0:3a3:42cd:3701 with SMTP id ffacd0b85a97d-3a35121006dmr6177657f8f.23.1747387109374; Fri, 16 May 2025 02:18:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKgMzwSlMBVhcC/FPwYFo4rG2hT+TNdLoFs9mvpWOK1Lt/3LuMG8CN5jCXDf6HMpWA8XXtvA== X-Received: by 2002:a05:6000:22c5:b0:3a3:42cd:3701 with SMTP id ffacd0b85a97d-3a35121006dmr6177579f8f.23.1747387108032; Fri, 16 May 2025 02:18:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f47:4700:e6f9:f453:9ece:7602? (p200300d82f474700e6f9f4539ece7602.dip0.t-ipconnect.de. [2003:d8:2f47:4700:e6f9:f453:9ece:7602]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442fd4fdbfcsm26451055e9.3.2025.05.16.02.18.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 02:18:27 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 11:18:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node To: Donet Tom , Andrew Morton , Mike Rapoport , Oscar Salvador , Zi Yan Cc: Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0upHwPrjNJ7BkaqaupAkBJpd44EdUGA_tydtdWAnoN4_1747387110 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EC935120005 X-Stat-Signature: 3cnrq3jtk5ncwxtyjj7sgh5xr6dd4ncr X-Rspam-User: X-HE-Tag: 1747387112-142521 X-HE-Meta: U2FsdGVkX1+zfw+yYJFBoGjmkAEQUqoFNcZVo3kH9uprkqAH981DCEWCOjERubPHqFEZNcyMLrgcC9vQSlSQlEoaNPX5nSJuOX03yK2+uij7QPMbJu7K15G+iRCnOdIxL3WkAxMjzWStEInHuJHChNvb6JHS3wrxfUyhcA+PcdO6k5gwj+FSF6SxP+9yIN2slCX3kSDRreUE9oufh6Ks2E96BKuIPNt/W04r5J04dTc2Nddx8Oi+K22OIVm6JFwlM1rtq8rTMA9/FAVPVeLOZpPhvpKo25u98ldGSQMcHJvmzvL1sL4UJx2QMkma0M68GUF88CTNuUgFDjWqfr/Xq2KBRgheRgRU7zo7JtqWcMzR5VewhzGRnsmXvSv+HAg/npTyrTxuGljxAuUlXfDkL30TYvDCScy6t635Y+rEzQc0gXUsWDdvkxQ5MMQ/OnXBz4Mr+qKsK+1ZRNM+pI09LGJNqJpL6GbM9lbjyF4E8b9ORpFQ17wOoX1eEvyD2qPUjRauLn8tkLTAhyxyvm587/VbJiRcKyfmaQeWBgvbEReZJRT3cf/hHRUzT2clKpdjz+wje3sOobhnbE4DoeEWio3074F2p5SeZAf82w1vO1ufJjVpWLdgSInvUdlFw7JX0FTUyljxNGsln3E5EgR6DZZ0eyGGOaeAxKe5WNLvlnZHebGihdneaP3PzCdyjdGfSx4er8yXrAIQleVVQZ6kkRgU0ulyjql8repFNvU6EEyOrLoiDXx+wDK5yWgmpk+sVJYn4hrQp6r2qFlEt1ku8DkNzsbe/n/09c+g/UqnivR1FN6wELLb2yHpUZ0FjEHCEfqm/wPyyWDFFxCr50KUGiwGCsSVe9pF5Li0DyPwc3x5UTK672qpI2/ja3bBmAt2Rf0cVFO6FMMl+ARxKZnlG9O3DNxIZu9H4UO8ylXW7zWt63zFYYeZWx/A2NLYFwxBJk8+Dd5mQYOXJy/EgzK +zUSBgUr fNHK2WZ2NUlfz23U5cowPRqRASzueh9OTzAPzaGCdZ+gOqfetlBjwjLGk9CX4eFYrVECRhG1Vzyg+ojPeSMpvsdOJcFt5aTC5WKwfKqcVIlhL6Nx3J2PFe3Y+tKmP5iR2veDzQvsrrWNNwvd5AkdZa7SKcjfMmVHnAp/IiWdFhwm5q3kIY47I0STumvamcDotCFRQLnjnjRDUD7VdGJfI5rd6mlO4enqCXQakF2zlAEq+4XNahGhkhlKRQjHWiaBwUiVDMMA103KLum2p4Y1/g81minmE+QtZ8GMkpFntxa4SGo93Be1O+eFp1kExFKV3p4rnJZHTCRxhBTftEn4qarlx5n2QbmihZqfuOD67gEcltBcevD/cjL7CTEFBKvSppdS5GJ7u1VhVFMzN0xUcLM7M+C02qwrdRwcIGTWc8+sMBGOrsLHQq3iy/ndVJCvMkSF/8R+Sqhf4vs7YSPzN4BBFZN0+N3xb4BvNflN6DvK65k1vR/aSsyGouEyFaK7LMwjx8ALPnjKMuRG2YaE/tjeJD9jsgVoOPGOhD2NKktUrXPweQHraY2O2sP1qs/vnk8EBCnsELHggtgTN5zyf20YjQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 10:19, Donet Tom wrote: > register_one_node() is now only called via cpu_up() → __try_online_node() > during CPU hotplug operations to online a node. At this stage, the node has > not yet had any memory added. As a result, there are no memory blocks to > walk or register, so calling register_memory_blocks_under_node() is > unnecessary. Therefore, the call to register_memory_blocks_under_node() > has been removed from register_one_node(). It might help to throw in some empty lines to make this easier to read. Patch subject should start with something like "node:" or "mm:" > > Signed-off-by: Donet Tom > > --- > v3->v4 > > Addressed Mike's comment by dropping the call to > register_memory_blocks_under_node() from register_one_node() > > v3 - https://lore.kernel.org/all/b49ed289096643ff5b5fbedcf1d1c1be42845a74.1746250339.git.donettom@linux.ibm.com/ > v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/ > v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/ > --- > include/linux/node.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/node.h b/include/linux/node.h > index 806e62638cbe..8b8f96ca5b06 100644 > --- a/include/linux/node.h > +++ b/include/linux/node.h > @@ -137,15 +137,9 @@ static inline int register_one_node(int nid) > int error = 0; > > if (node_online(nid)) { > - struct pglist_data *pgdat = NODE_DATA(nid); > - unsigned long start_pfn = pgdat->node_start_pfn; > - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; > - > error = __register_one_node(nid); > if (error) > return error; > - register_memory_blocks_under_node(nid, start_pfn, end_pfn, > - MEMINIT_EARLY); > } Can be further simplified if (node_online(nid)) error = __register_one_node(nid); return error; > > return error; -- Cheers, David / dhildenb