From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66884C48BF6 for ; Thu, 7 Mar 2024 14:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB48E6B018C; Thu, 7 Mar 2024 09:31:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A64656B018E; Thu, 7 Mar 2024 09:31:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92BEB6B018F; Thu, 7 Mar 2024 09:31:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80BD96B018C for ; Thu, 7 Mar 2024 09:31:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 468ECC04C3 for ; Thu, 7 Mar 2024 14:31:25 +0000 (UTC) X-FDA: 81870480930.30.7B26DAC Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 3A53740021 for ; Thu, 7 Mar 2024 14:31:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Q18XmgoE; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709821883; a=rsa-sha256; cv=none; b=KitUudM95R5Qwf8ZQQvpYx8+K6rjugzTwBlI8UnDs0U/R2lbKqs7Nseoq3+l8EIR5j0lCr neArQJ/n1Xl2asxRhep5dxco92YPg1vjJJFEulctmxSHjRpgWa2V/wKonJlqusSv3IZB6d lkR5dtY+o+RE4QHAYW4YVJS0b6K7RAc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Q18XmgoE; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709821883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQ1oDDQ8dWm1tNO9fmsmkt8ln7ANF5qCeaHGCwzdir0=; b=dA5DEyNtW5zvk01QunSGEGM+WpoWPb4DkJ43s1TxLGYRqANgAKNOqrlHHW54PudAsXVjGb wuAOcMahTRdLyWJ63L8BGNSk3D2UX+Oh1tt8Zk9uaEOWA9VkyYDV/ay+oS2a/rYvx4nssm KgVO4qt4MLOAXEaWVttbCTfEUAY+Rdc= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41311383a11so4683185e9.0 for ; Thu, 07 Mar 2024 06:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709821881; x=1710426681; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QQ1oDDQ8dWm1tNO9fmsmkt8ln7ANF5qCeaHGCwzdir0=; b=Q18XmgoEbhsaoFCFtFNVGg3Jo/wX179Bb1LuLoRDuC4/OyY13Z9qfLO9rgwkydch8V HDvmDdp0aw1qoJUEKkoSesmlPg3Hv8Ex8NVsATVA/PTAdTPnhdWMp6RA8GfPqR5x1aT/ y8TyMJ6BfU9ktuj5nIunixOxgCW5zMojo1Yx6pl1rkUuEotdD9NvMAdZI9mCLwQluHPd BMycSReyn3Msqzid5wAcKeZU3uzLWSyss4rS1595siVq5N+txli7jrI7rFL7JvFh9SaA 6CJRJfe/J1z7ke7vnmLQE1Zr1zcfwbaUvGxb59SIAPAEsJE6BFmsaeKh5OSSi/QnHquE LlHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709821881; x=1710426681; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QQ1oDDQ8dWm1tNO9fmsmkt8ln7ANF5qCeaHGCwzdir0=; b=Rk5lR9b6PDo1EmCkbvqdgFwuEjREFkKvCQAkMfsTKtdi3BLh5pZWw4/n6Insyy8KNL N+AAv/rvQ6korx6PlnemOxU2D0itbJ7vZu/sptOQ0HDUqysVpjz4Y7X4bqICLwP/huvV 9clsDyrZAF6+HUZy/Jaup0nIBSnDUAQtwp8tK82giAUgCXzDkiZoY1tsg4l+ZqQcpbqo sCPt+QWisjFXkAUOu60O+RowURNN0jP1cYXz3R3iXFEZCZE83GDVt54exv1ZjZz8B/U5 3H2rnvAGeaKi0hkf5HiMYVinMSV+2JUO2kxPgB8K/1JWUJXL7YpnOP9xakaN6t+5iH2z 8+lg== X-Gm-Message-State: AOJu0YxhuTdMdKVe9Qhwvax9Oz9XFZG3+/fzaiUtmMKKU4owsC/jHFT6 u45syFMxi7pdUrhjXAJbqJLV1QUzCk9eHsYrOA+O/Bu72OYK3eZYTdBfcIEYSog= X-Google-Smtp-Source: AGHT+IEjUGk03M5jgRbWzNdvlP3dtj2ZDBnj8Hkk7NP9S/q/u7m0Ld80myOSWhm7WiSUTKqhNct7OQ== X-Received: by 2002:a05:600c:4f86:b0:412:a06d:6cef with SMTP id n6-20020a05600c4f8600b00412a06d6cefmr13864561wmq.37.1709821881317; Thu, 07 Mar 2024 06:31:21 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id z11-20020a05600c0a0b00b00412f428aedasm2895793wmp.46.2024.03.07.06.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 06:31:21 -0800 (PST) Date: Thu, 7 Mar 2024 17:31:17 +0300 From: Dan Carpenter To: Zi Yan Cc: linux-mm@kvack.org Subject: Re: [bug report] mm: huge_memory: enable debugfs to split huge pages to any order Message-ID: References: <7dda9283-b437-4cf8-ab0d-83c330deb9c0@moroto.mountain> <4EFF8F91-5B42-4E90-BFBB-FBA8DAAB8301@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EFF8F91-5B42-4E90-BFBB-FBA8DAAB8301@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3A53740021 X-Stat-Signature: zj6eenzp6jnbxff7xobxwrbxcpwok9m4 X-HE-Tag: 1709821882-738913 X-HE-Meta: U2FsdGVkX191SyYpf+cS1vHYngiWruZ6cJ/IWxutb37ENZ6AFkIYxBFp0PkxUJ/NPfny4jBl0Q/SBZSlOAtI0IFqh+JIE8AfxYAMDHwpUWAz9x+4s/ksPdFWlNVoSM1sy0qgDQJ4Af1rL0w2JIYeQY7bqiWo74j+L82/tRtJ3a08xGsL+BkSQkHaclw2ksGlje6qpQnKh56Jq7H7xz2xx+BY0XB1mvd12bwxE0B8v++sMRnAcCataM89Y9kFzxF8uMrWz722ScBeLFs3q+fPK35Z5lfnFtxuk8A0rRcjhxq3F6NusU+KQvJrzLY7hdMJtta0t4uWQHEhj5trTarTalmB4YCuG7ibJtpirkEKXR40fgIwM6KIlTp4qxxFp3ux/A1qh71y0e/rg7Daanq69QcClwc8QXcvjgAtyDaOlRqQhxreVTtuxzAlL3WimRvzXQR9g0Tx4jXGqHCylgf1M5dFLIf/ut4bZDCjI1CgmdxTplPO5/srpmByRppeUNA2L/m1ph93W2oE5zctPxCJfKEzov7+4egYfZUT8zXf3oj+HJA+HnFU/AGl4kmBkgUZbF4u/WbmAo4Avfc5nVh8svN4TF4qc/pZAakIQ6apmoS3E6a5J8NX4kW0gTGraqunn+fuJ4xD5gT3V9IQ+tZQf/24PpABvbCX/TSoyQ6UctHTHoTVGeCW2Jy2MR7SR9XSZACVwkD4W+viBR1Ll6I/6RQOiwXjZJwGERXOVFSEczoHgaCKTKuDcGXt3wLKrfYSHJYznz/uL6c1qsicqFSc5Mhoknv4MV8hrM+F4qFDJLnYd6iDXgNRXN2D1GuzijVSV8sLEdwW30bc+ladDDTNbVsvqsNK8koyawTBU0A9UR9qrlmVie2ypZrYiMUvVQBR1BBeMtswlwEDD4+wYlhiBqtI1dJwRl+mwXV92DSKix6RTru1S+c8RIT8lKOYkolGIzg0Ol7OYLa39yIrMxI oZRT5w8u 8MWD4v/3uBrv6a5jzj1lLaPKKcoF8kdzkfkvr03YpdtnZLKbEt7IOC/SY5l+kf0IdpuVfMWlPCMpzT9HKXSc5xe2/JKiyIvVwRLmFCLFfKET//idqdYOyy+6BuRKHgxWfAwpDFB5AWB16sQsuvRw6mLMbGh86uDfShecTlGQBYrTWeENgb8Gx3oRHUIGc4Itcnv9DCQmPlmVRri1IPgy37avhHjblwWN+Ta0PG3i3G/lsWOxoFr4W18DwRSM6SUHm56KhGXfYGAaaMSFvTWOFF88WjwUEP96Ddw4PsOAo7nkh738bnm05BwaxWpn7RK9phyBMtbkzB/8hcriRlHajBerpP8ACxMihImzF6VpT75GBaNEyuOTjdVcoYG+OmYFum9nFjPAO93POrSHQNpxJPJnm4f7E3so9dn1D X-Bogosity: Ham, tests=bogofilter, spamicity=0.109207, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 09:20:09AM -0500, Zi Yan wrote: > > Can you check if the patch below fixes the issue? I checked the inputs from > debugfs and also inside split_huge_page_to_list_to_order(). > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index a81a09236c16..4d21e57a7d07 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3052,6 +3052,9 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > + if (new_order >= folio_order(folio)) > + return -EINVAL; > + > /* Cannot split anonymous THP to order-1 */ > if (new_order == 1 && folio_test_anon(folio)) { > VM_WARN_ONCE(1, "Cannot split to order-1 folio"); >From a static analysis perspective I think just this is sufficient? But I don't really know the code and don't object to the other parts of this path either. regards, dan carpenter