From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86588CE7AFD for ; Fri, 6 Sep 2024 09:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16F4C6B008C; Fri, 6 Sep 2024 05:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F9106B0092; Fri, 6 Sep 2024 05:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E66A16B0093; Fri, 6 Sep 2024 05:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C73FB6B008C for ; Fri, 6 Sep 2024 05:56:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7FA60A9E33 for ; Fri, 6 Sep 2024 09:56:08 +0000 (UTC) X-FDA: 82533857616.18.7A344CD Received: from flow5-smtp.messagingengine.com (flow5-smtp.messagingengine.com [103.168.172.140]) by imf30.hostedemail.com (Postfix) with ESMTP id 7CBB180018 for ; Fri, 6 Sep 2024 09:56:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=Cma88D0g; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="Y gAPQau"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf30.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725616493; a=rsa-sha256; cv=none; b=yVO3nemgoTjzH5zk9WvwAuQwCwbK+VDY745SvVdJUosQtIah7wHfUyOIpdPZI/lpSfCtmP esJBqL690EhdXW958OknoTRllJh8A7SSZxarM6KylRXm3oBhGXnTj6KAzUI3MJZAYNVstA aiOMsrRxCidhqzpYZnqmpScDjnhxPvI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=Cma88D0g; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="Y gAPQau"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf30.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725616493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=spCdL3tE0yzwRJuzWoP/dh86M1NxHAaaOfguj/M3bzI=; b=PF0E5FJNZ+c1XeDDa0IbgiBuk1zohNCP1cVMQd5+gRGDnY20wo8rkBPZHthuhXZoHc5TDn Nue0jSmj45ftR27ywOBGsoIlz2ovuAV1uUP5/VsUUYAFLYLNMGTmT4sQWy/kS/UBTe5lRv SsqpVKYMADEpxRXBrc7+GRGn1hTFgGo= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id AFD7B2002D6; Fri, 6 Sep 2024 05:56:04 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 06 Sep 2024 05:56:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725616564; x=1725623764; bh=spCdL3tE0yzwRJuzWoP/dh86M1NxHAaaOfguj/M3bzI=; b= Cma88D0g5A7fxF7e1V4mXGBjVHxirMssk0FBQK4EMQSGfMiy8f3dyAvI7/6AtwOO YlgJllHqtEY1khbMWztrp3oPt40NDjJ8BMGNKtqqEmVfPaujpnhFPkvWqUGQxl8c /2sMwk3DR8zPvU9L0cKnOiIRhobWNxb5t+HGLJOcjG6ojTfQDNGhu4fMhtzaZwos lK7fymt7/XY27ZqAK5m0zM5JPmNyD3nJQ8bbZ1bW9N9ZRZEgxtjz/o2OgNxr97Ia 6yUnUFzOGylWbu7MeihxJR00a9yL82ng7KCYeQqYZpFaxBOAyZRb2gGcDEIXBt4N hs6L15qVpt/x6SHz2lvwNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725616564; x= 1725623764; bh=spCdL3tE0yzwRJuzWoP/dh86M1NxHAaaOfguj/M3bzI=; b=Y gAPQauNE6VOg0WAPifu+oG5IiSAqrQA5hlf1szYIEejmGSMwas1zqtJyqaWuxUY8 XUp4Iiff3woDjsCEpNo3Ovp6hVjfrJ4m+MxaKp85JPmZ5EAnaQ7sogz83cnKRbMB N6po9qOAKMy7yGwr4bCcQUQeA/0hS+vAYY7QMtgxtDXzq6W05ci3KwMv0b3oj1p7 GZND9HyrwkPrRnb5yHeWBVKaJNL16/BdsXZnW1hUslxJtBm+yqi8NagtKQlkmvaF d5r/bn0SPtFIA139lN5cnU+I+OsmGV6ZdcI6K7xxx04PkF05+5daJhgLUNJyNSQD G5CFmU3NT6E2KPibGRmvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiuddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdej necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhepvdfhvdekueduveffffetgfdvveefvdelhedvvdeg jedvfeehtdeggeevheefleejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohephedt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehtshgsohhgvghnugesrghlphhhrgdrfhhrrghnkhgvnhdruggvpdhrtghp thhtoheplhhinhhugiesrghrmhhlihhnuhigrdhorhhgrdhukhdprhgtphhtthhopegthh hrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhrtghpthhtohepuggr vhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopehmphgvsegvlhhlvghrmh grnhdrihgurdgruhdprhgtphhtthhopegrnhgurhgvrghssehgrghishhlvghrrdgtohhm pdhrtghpthhtoheptghhrhhishdrthhorhgvkhesghhmrghilhdrtghomhdprhgtphhtth hopehmrghtthhsthekkeesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E5FF5222006F; Fri, 6 Sep 2024 05:56:02 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 06 Sep 2024 09:55:42 +0000 From: "Arnd Bergmann" To: guoren Cc: "Charlie Jenkins" , "Richard Henderson" , "Ivan Kokshaysky" , "Matt Turner" , "Vineet Gupta" , "Russell King" , "Huacai Chen" , "WANG Xuerui" , "Thomas Bogendoerfer" , "James E . J . Bottomley" , "Helge Deller" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Naveen N Rao" , "Alexander Gordeev" , "Gerald Schaefer" , "Heiko Carstens" , "Vasily Gorbik" , "Christian Borntraeger" , "Sven Schnelle" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andreas Larsson" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Andy Lutomirski" , "Peter Zijlstra" , "Muchun Song" , "Andrew Morton" , "Liam R. Howlett" , "Vlastimil Babka" , "Lorenzo Stoakes" , shuah , "Christoph Hellwig" , "Michal Hocko" , "Kirill A. Shutemov" , "Chris Torek" , Linux-Arch , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-abi-devel@lists.sourceforge.net Message-Id: In-Reply-To: References: <20240905-patches-below_hint_mmap-v3-0-3cd5564efbbb@rivosinc.com> <20240905-patches-below_hint_mmap-v3-1-3cd5564efbbb@rivosinc.com> <9fc4746b-8e9d-4a75-b966-e0906187e6b7@app.fastmail.com> Subject: Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7CBB180018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c7un3t9fa6kj54xnf8or6ji6bh6efbwc X-HE-Tag: 1725616565-586675 X-HE-Meta: U2FsdGVkX19eMSYBCrV9sWQlU1EtQfqwcMIz83ydk2jSpHjOF5P3sdEdtinorii+uS855PYRVYlS3Oqi2bnKIK3iwPV3vwafrD8C8mK1brsAF6aLr6mMm0+CaWztIFVYKzGNls9cbIwcpA//hVHI9EQFQgiZ14Gl2sE790Z3/1IwCKYsAPPtMYPCJ2W90M7KBo9H7an+0v5ZnAQX7KKCQBt/lMxAPLR5wnBGtETXLdw5ZLWAzAJfc5ti2VFBSjghweQzjGczhZybtFJqHJwFSBqefVsSSf4CO4s+/U9kIzGmecD9e/XrFLsA/TD+dXkXV9N39yIYh6cQeVHqZraoDD2JBDirGw+hJg1ig8+muvFsyINMjargKTyY5ui/ixLH++26pPE5GEdvzaarep+VKXoRssmjlw3SYnbv4uqAxwTAhIY1rINH51oUdWOaUmnZAM0jBFKFIrstaeDw7E6VaYtykR6t+nKqQ3i4+HszPSweqq3HeMW0Ho9irVcMXG59n5qNbKCZJUXpWuQ367lcdh7b3IvufuiY6Vlt9IkWO7D7xNxj6ckIsziXVVQetNDNvr2S7Hh/9sdkyafG6vs2uhupjOS81mPv831FDBM+8nam8vyhBuz0+9y498mPIj6tH+/fidB/pZIIVHHduK5gwPgBNa1hC/dC0/tIixzEsNcfBAD0BMLUTsE8Tyzo5y5fVaz3vGT3YDj+C4VAtGgRXlQ4CF0JvteGwtqlB3qw2LBCsJOpaEXRKU7kH2VYLgViuEZ+v8N/xfvZ3F4gbIGh15DSoIoSW3BWd/6ZCk8oXHMiq/viXC98zkmGzBk/vp6rYJXxIgUpvuLXNQ9YJ9QAInLBKK8zIQ6xaiMGGXw4WFNFw45ETeVXNIC/2oVH7wiGsY2Z0oxFjvf/DGn/DlO5fUv81TltKVgyyuGG0DmUiUu5Nqpddhwob/nxrp9F5W+t1MqaV/ql1P6NpVAWOHl 6yxWfmXT 4G4cA6Rte5Q/EcYnt1hsDlRIBMaroG4kilZ+0ek5j0SfJvtHkP8VKvLUNMZ+IsZilBvbcc58FDd8vTvoFxjIYigMHdXmmXaZMvsYA2v0g6z1plZHDUEmuecw31YlX8e9AvQTkP1dRFOLaBszhvmlA/f5QGC8u61gz7Cbecjc+tkkaDNbMVqD2WzUsZx6LT33PZoyLjUFBh0U6xMOQpdkHbzbFIUhIYgFTsxAjfe+wCUwQdXF+m/emZKPwCrv6KFOQWrqmkd6E4bTrEqlEfwZq4uFUCEQV500/PNzyuiGIeKeoCzZYSSr8FE1ko+iH6tW9YC4ru5jjceEGN9irKYccGjz44/6DeRJKiJJimpTPEnQOHGMxJKRFgB2Sn4+17X73vaAQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 6, 2024, at 09:14, Guo Ren wrote: > On Fri, Sep 6, 2024 at 3:18=E2=80=AFPM Arnd Bergmann w= rote: >> >> It's also unclear to me how we want this flag to interact with >> the existing logic in arch_get_mmap_end(), which attempts to >> limit the default mapping to a 47-bit address space already. > > To optimize RISC-V progress, I recommend: > > Step 1: Approve the patch. > Step 2: Update Go and OpenJDK's RISC-V backend to utilize it. > Step 3: Wait approximately several iterations for Go & OpenJDK > Step 4: Remove the 47-bit constraint in arch_get_mmap_end() I really want to first see a plausible explanation about why RISC-V can't just implement this using a 47-bit DEFAULT_MAP_WINDOW like all the other major architectures (x86, arm64, powerpc64), e.g. something like the patch below (untested, probably slightly wrong but show illustrate my point). Arnd diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm= /processor.h index 8702b8721a27..de9863be1efd 100644 --- a/arch/riscv/include/asm/processor.h +++ b/arch/riscv/include/asm/processor.h @@ -20,17 +20,8 @@ * mmap_end < addr, being mmap_end the top of that address space. * See Documentation/arch/riscv/vm-layout.rst for more details. */ -#define arch_get_mmap_end(addr, len, flags) \ -({ \ - unsigned long mmap_end; \ - typeof(addr) _addr =3D (addr); \ - if ((_addr) =3D=3D 0 || is_compat_task() || \ - ((_addr + len) > BIT(VA_BITS - 1))) \ - mmap_end =3D STACK_TOP_MAX; \ - else \ - mmap_end =3D (_addr + len); \ - mmap_end; \ -}) +#define arch_get_mmap_end(addr, len, flags) \ + (((addr) > DEFAULT_MAP_WINDOW) ? TASK_SIZE : DEFAULT_MAP_WINDOW) =20 #define arch_get_mmap_base(addr, base) \ ({ \ @@ -47,7 +38,7 @@ }) =20 #ifdef CONFIG_64BIT -#define DEFAULT_MAP_WINDOW (UL(1) << (MMAP_VA_BITS - 1)) +#define DEFAULT_MAP_WINDOW (is_compat_task() ? (UL(1) << (MMAP_VA_B= ITS - 1)) : TASK_SIZE_32) #define STACK_TOP_MAX TASK_SIZE_64 #else #define DEFAULT_MAP_WINDOW TASK_SIZE