From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 142B3C369D5 for ; Mon, 28 Apr 2025 17:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD27E6B0099; Mon, 28 Apr 2025 13:14:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C801E6B009A; Mon, 28 Apr 2025 13:14:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B22306B009E; Mon, 28 Apr 2025 13:14:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 944796B0099 for ; Mon, 28 Apr 2025 13:14:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 097AA120E08 for ; Mon, 28 Apr 2025 17:14:02 +0000 (UTC) X-FDA: 83384100324.19.A386C90 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id 8D9EEC0008 for ; Mon, 28 Apr 2025 17:13:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=lxsnSifw; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745860439; a=rsa-sha256; cv=none; b=cPN7JYuhSEK4H/wk6JF8K9ZCqjdrAMB6ypYXS8luj28cZlsvSYHul5H9NpuK5kEAN2xURY vwOsm40P3VXsDaKSYqQ4Czb0zaIv9rX2V08gw9HZ26f3hee/4zkgO7DKfzT/vnMaST/h9/ BTqP5dyI1yhX/JbS753DNGpNdJhgN8Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=lxsnSifw; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745860439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KomaKdZjhofElzsKOtg4I+kL2PS3yimbP7HbLJSlulQ=; b=FGxn/AkrqTUNPG0HkHoqnsvY3w98Wxa3oj6u64v85XEyFJ1fN/EFjtBfDBsiKMiJVWkUpt k4Fxfgv6fkeL0FGfQ49Axc5tw5l7LfOzr8Eh7/NdSGfbN6bSxiKobk3ogR/cPUIMT+VdMx g7eUQIXfXOg6IVat/VqAGJ9ibanGx5w= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53S8vRI4011968; Mon, 28 Apr 2025 17:13:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=KomaKd ZjhofElzsKOtg4I+kL2PS3yimbP7HbLJSlulQ=; b=lxsnSifwoJMmlWz8KjinGm pyb3sVziw0856i6roV0tj3wCP9PhAxQVQEPxpr2ZGmNUC+JS79cPAhyuCqU58WrC BYYiNIjTGgnGR6pn+jYvPSXt27JpZEUMlO0bBXFYIBGfQn6ZFVLHbAYCigwowZ5M y9Qn/q+kf1lSkMyhXDUb44g9D9AQUeYDEEmqwt6PnM6FBqo4QjP+oTFd0OdgfdHn ixfvzBdxmXPMm48N1Sb65hVDmKw6InGQUEzENJNUwZzWHa5ON8yeRqnVPl14/k+U 6HRIt0P6OBJZ56KrtENGAXE+zxM+FH8/q7ZSd3uYCLBjS55VrqGUdKQHng8wsL1g == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 469v5kmm69-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 17:13:46 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53SG4hau001803; Mon, 28 Apr 2025 17:13:45 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 469bamfcyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 17:13:45 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53SHDiwS31785558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Apr 2025 17:13:44 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7054C58059; Mon, 28 Apr 2025 17:13:44 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 762E658058; Mon, 28 Apr 2025 17:13:40 +0000 (GMT) Received: from [9.39.16.18] (unknown [9.39.16.18]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Apr 2025 17:13:40 +0000 (GMT) Message-ID: Date: Mon, 28 Apr 2025 22:43:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] selftests/mm: Fix a build failure on powerpc To: "Nysal Jan K.A." , Andrew Morton , Shuah Khan Cc: Madhavan Srinivasan , Michael Ellerman , Segher Boessenkool , linuxppc-dev@lists.ozlabs.org, Kevin Brodsky , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250428131937.641989-1-nysal@linux.ibm.com> <20250428131937.641989-2-nysal@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: <20250428131937.641989-2-nysal@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: KbhYiEFmmP_tUzB4rpXFNi3_j7M0PyVQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI4MDEzNiBTYWx0ZWRfX8vQd+r/NVdK9 fVj89Nk81fj93yIB2WK4uyLM7M2mHWCc2/y4CfPB3vhVEHD61xJsc2tkwaYLeMAo1yZPGG2x6dm N6/occobZIF5tvvDpMBVNLKqwuD0ILpj3AhpKOro+gHjepSmyAR3zwBl4jwSjOC0XFRdJO78IvF 63cjTo0OVdK2T0jqwU+mT4ZrZpKUZ9IXT4LlK8EaJ5rjawUKpt/6t0aslWBLVTDSR3Q/Oij9URI gbRM6RAky3R5e1w7XWGL+4tZoNYi5BSFK5TvAt5U5U/yjvaXvZL1jx9fj4NrvENMq7KyXXgLXUW eu3eugR/BYKbxdOp951n729X4QIrTsbuJG0jJmbMjsVpG946nf+Pkcdvxipk9dHdfgIAGhD47QW 8Z7aBlg4v4J8yzNtx5fmE2j6pB8oC35I7r8W4BNQsUCCmMki2/wpZhW72L+YobWf0ODzjd9E X-Proofpoint-GUID: KbhYiEFmmP_tUzB4rpXFNi3_j7M0PyVQ X-Authority-Analysis: v=2.4 cv=DvxW+H/+ c=1 sm=1 tr=0 ts=680fb74b cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=QUTIWzIZJQuvQjQnFLoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-28_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxlogscore=906 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1011 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504280136 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8D9EEC0008 X-Stat-Signature: am8fj59upgrxi3dyxfrropjjhxemit59 X-HE-Tag: 1745860439-67551 X-HE-Meta: U2FsdGVkX1/Cvv6CRV1y8LIcjRqqdkNS3+RjNv+ToWj2VkLl9khzNhLvLZlKuRiWqN6R2IZg0WlEYHf8ZsafgDCihosX1jPW85posZg4E9u1GMCStdpHLaDx2itDGdwaPoIpjZoTDnxkkdWNo+5m1wbVcOIyTK9s+1/+aYU8L/yDSpj63WsTqNHB2Rxvtw+PRN69S0anlxqym/4xakc6McIm1Rvvmn5Nr6KkmVTvMqezvVKyKdxZ8TMlP2civT4SQDy6ZA4zuwNrZtrlZySNrqUM//RBeIKlUJCXoRhhy8hbPesU+cxq+zkuvsXl/XlQmTgOJ2CqvR2igzvU/0dfHC/anCHW4z3LgiOyc7hE6kBPmOBBMXeyUjiL+uVy4VH2aiTlqxqyUMBC9fSZH4r690SBfXzvW3/ssiXQngGUPqco85JJKYBLhSfesQEv9QlfaYQSL4BXyPqm5QiLDmIZ8RbGDd6dxnjKMmGIm5N7F3Ui39voe02irZxh7GDN0n9wGkVZbEZz7cZP3PEZI4A7as01qkFGhkMwNFmgHWcfwOVbJ0B/CYcFwqilipQgUTXULUfJe0fGOPfGSoNj5bOksL8KNhavXGKgQWMrP1j836v4kVXOp0JZl6/A+zGAwEDNrKDdZjU6TXURzjnI7NAIi9XxzUSy5CY/9msmm5lKM3QR3QndgZEOb2FBspvpe0vsMyF5VXPk9/i6ZMl8+HACjatKen6U0J/I7C819jgcxD90whhXKqnDmVI76KL2t4ly/7tKWsbF0iuzUCaikRQsu+LFkQm4qS3OcbkoMj1nS1jELM1XTS2dGe/hRUIKijD6sP1v2Rs62zsankLHQ6txWh40TXiZJGmIItg6VB7ChnwoHOuNPk3Z8m7N6FfQNJdwL2qgrHFUr5+doJz0wAhiAQsDFK6drrAaj9fSRFPc/xlm5Uf9gij4aMvDfsWdci+2shhjF/U6mS72nY4kSLu gtzjyKE8 LLt2TjIW6JvLIGiCuASUOsVkoMwLRF5/9tF2ZTwHXykqy+VtXMfOPIQ6TONuERxhDc3XVcKm6faqAGZaWoBsncnLydVNSrVrzNj/bkrTU/RoBeM70TYgJ1qy8htnl3WWI97wwkLvjsl9Ll2P31iT/Oas8/wUkNu7zhWauFRsIVc9c2e7rI8V2IMkTq+bHmyOzeRdsw4d57wpv701Gq1CalrVNCoY7M1nI19F7Zu5lFzNXNm8cYNjS2zCyRZeR6H/nJo+K9iwDFUt4+Qkni/orhY0UkcCuIltoUjkChO1U/spzVXCCEilUR0af7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/28/25 6:49 PM, Nysal Jan K.A. wrote: > The compiler is unaware of the size of code generated by the ".rept" > assembler directive. This results in the compiler emitting branch > instructions where the offset to branch to exceeds the maximum allowed > value, resulting in build failures like the following: > > CC protection_keys > /tmp/ccypKWAE.s: Assembler messages: > /tmp/ccypKWAE.s:2073: Error: operand out of range (0x0000000000020158 > is not between 0xffffffffffff8000 and 0x0000000000007ffc) > /tmp/ccypKWAE.s:2509: Error: operand out of range (0x0000000000020130 > is not between 0xffffffffffff8000 and 0x0000000000007ffc) > > Fix the issue by manually adding nop instructions using the preprocessor. > > Fixes: 46036188ea1f5 ("selftests/mm: build with -O2") > Reported-by: Madhavan Srinivasan > Signed-off-by: Nysal Jan K.A. > --- > tools/testing/selftests/mm/pkey-powerpc.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pkey-powerpc.h b/tools/testing/selftests/mm/pkey-powerpc.h > index d8ec906b8120..17bf2d1b0192 100644 > --- a/tools/testing/selftests/mm/pkey-powerpc.h > +++ b/tools/testing/selftests/mm/pkey-powerpc.h > @@ -104,8 +104,18 @@ static inline void expect_fault_on_read_execonly_key(void *p1, int pkey) > return; > } > > +#define REPEAT_8(s) s s s s s s s s > +#define REPEAT_64(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) \ > + REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) > +#define REPEAT_512(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) \ > + REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) > +#define REPEAT_4096(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) \ > + REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) > +#define REPEAT_16384(s) REPEAT_4096(s) REPEAT_4096(s) \ > + REPEAT_4096(s) REPEAT_4096(s) > + Hi Nysal, This change looks good to me. I tested in on power and the error is not seen.   CC       droppable   CC       guard-regions   CC       soft-dirty   CC       protection_keys   CC       va_high_addr_switch   CC       virtual_address_range   CC       write_to_hugetlbfs Reviewed-by:Donet Tom Tested-by: Donet Tom > /* 4-byte instructions * 16384 = 64K page */ > -#define __page_o_noops() asm(".rept 16384 ; nop; .endr") > +#define __page_o_noops() asm(REPEAT_16384("nop\n")) > > static inline void *malloc_pkey_with_mprotect_subpage(long size, int prot, u16 pkey) > {