From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A5AC77B7A for ; Fri, 26 May 2023 19:42:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21542900004; Fri, 26 May 2023 15:42:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C513900002; Fri, 26 May 2023 15:42:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 067F7900004; Fri, 26 May 2023 15:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9FDE900002 for ; Fri, 26 May 2023 15:42:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A236A401F5 for ; Fri, 26 May 2023 19:42:07 +0000 (UTC) X-FDA: 80833427094.22.C06B522 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 62C984000C for ; Fri, 26 May 2023 19:42:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OYsU0+Oj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685130125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AQbvDzRrNGGmJC0cFwixRt7YyXto2u7DcheHfHIL6TM=; b=yo9F7197JKYHvTRCmTQ3QJxTf64BiBqP8bRjl2lP81vlli2lA5nlbHG4o2KQbnbDrKog/J ZdXE2UGS6E+MU1WdUs97DIexXueQuOKTS4Z9K9yzv+WrJhDSfBQVbbonlhjvz+iPSmkf+p diaV3j02ntk/p2OpD/H85c1EqVhohas= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OYsU0+Oj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685130125; a=rsa-sha256; cv=none; b=mYmcxLVKSNrJyAqN0I9pvLiPcYv9p91BHU18zCURh0O2O9Rqr1EZaoELjyaxQZ849WOxN/ XKIPes764ShCB40ulKiUqUQ1YJAd1Fcv7foDCRsdAhOOhpctgksMpCN+4/y2pIsDqVbkyt PmHrT9DqIfJPCblRi4eYWyuhDK8PUAQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685130124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQbvDzRrNGGmJC0cFwixRt7YyXto2u7DcheHfHIL6TM=; b=OYsU0+OjhamxJKamSgkSp/7bkjbZqPzBIg9R6Aqza2jiaiD5hJumOxDDsBEqZQzhGbyV4e lD2TkJtptNBJo+/U1HIsJdTcRRX5JYrT4wf6kpsnVy7vA3GmDao3N/FZ32A5OTNS/SPEMw xTlGRvZQSfjazl9IDak81+1foULFboM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-zGCRl3KzPwuTG7cddcGgJA-1; Fri, 26 May 2023 15:42:03 -0400 X-MC-Unique: zGCRl3KzPwuTG7cddcGgJA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f60f085cd2so4616545e9.0 for ; Fri, 26 May 2023 12:42:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685130122; x=1687722122; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AQbvDzRrNGGmJC0cFwixRt7YyXto2u7DcheHfHIL6TM=; b=VPzrSBmvI9h2nfhCfqVvYJQLJdje/6+k2VugERnxpY7jMz6dm5f8JF2sWiJ6zXoW9y KwGYaMVjHx77DML6wYIFRJli/SGajRIRqLHnkdrMEvzBiiX5HvJceNsjpgbFBnL7FFt1 g9Y6bFXVZ8Su7ySGpDTjddx6CpkT5UntsOL8WNKrXmc1Q6+Y7AOnrMs8J8r5t/OUH2sJ Xocw0T2QRUSFh6osm53fNNNFY31lOQ2PH+IRgxvtnZWCGQav4A1EEKRSJ4TY/gk1rGEj Rz+lmN8hAVLioZum5ayzu/HhjcFUy7/lYEtFvA+WgkN56iim9unN0PHDgKnDBpL3o/xo pq2w== X-Gm-Message-State: AC+VfDxLwWJ/aQ/ywB7ujzOuq8xff/ic6hHOezNhyA6MRvy3HxluExUd i3N0zCJj9EZdlMaSyU1HdKLwqG/iA0jrbWZu6Ty2FLqnoQhEgbQ69egvJGdbxA/lHzYHF5uHDjM cq765sLQLI6g= X-Received: by 2002:a1c:7407:0:b0:3f6:cfc7:8bce with SMTP id p7-20020a1c7407000000b003f6cfc78bcemr2507522wmc.22.1685130122172; Fri, 26 May 2023 12:42:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Fy1XekX9Vh+eeukEwm41budqTXKnvaC+Uc6qWThUB3TK1m5Tn41fjaNow0dI/Ly8Sf8pxmw== X-Received: by 2002:a1c:7407:0:b0:3f6:cfc7:8bce with SMTP id p7-20020a1c7407000000b003f6cfc78bcemr2507506wmc.22.1685130121842; Fri, 26 May 2023 12:42:01 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2e:ae00:f2e3:50e0:73f7:451? (p200300d82f2eae00f2e350e073f70451.dip0.t-ipconnect.de. [2003:d8:2f2e:ae00:f2e3:50e0:73f7:451]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c024800b003f4e8530696sm6035997wmj.46.2023.05.26.12.42.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 12:42:01 -0700 (PDT) Message-ID: Date: Fri, 26 May 2023 21:42:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm/gup_test:fix ioctl fail for compat task To: Haibo Li , linux-kernel@vger.kernel.org Cc: Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, xiaoming.yu@mediatek.com References: <20230526022125.175728-1-haibo.li@mediatek.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230526022125.175728-1-haibo.li@mediatek.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: j53ndn9y3fg6q5yepq1c5oagq4knyuqe X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 62C984000C X-HE-Tag: 1685130125-277640 X-HE-Meta: U2FsdGVkX192n3efXh09ZNr6w8zQSf6Qtu4ZNKraSSOuDjdHhByvYgEe0OEp7WjrroBoWJciaJS5HArA1RZosq/j5o/dKXx1BozsHJw2n2aj7RSi4Y0cVKMmCCx/n1aL4OnPIKujHlFxACKTN6eobMFYJS4Yf3CjfqRUoeaInD4sUWn4TJfxWs9/Tsm0UChp8z+Uw7ykO7kX69CkjsDy9yMn9sWWthyBzyoFLQpJwbClwYVUqtfpDjalKEvrT/gsflQdjItuJH12tX+6AarobAePAV+/+9q6nmKv7luiBGdTQVf6r5lQeFfwpwaIG2s4ibjQAOz+btoSynu2cVoUhjhDhDc+SBtdvyqql+jBtoTxZcRyy7fhgWsU1E+ajd4pWZ73IekqzbXRL0HD34+ouu5QLu2W6SS+nKk2yHKAX2JKHnW2kgUVkNQ5n/JQ9Kli/oEwVZkRcChy98aXeTkGeJ/y+4G1Hlycwh7ZUTUe326xmjxSVbXss/EdE3GjjH+bDQGUpxjit0XllrZ6DH+Hryp9XNyc5d6x8qmz2iYSsmuRcNbHkrf6/oLYwfI67aJbKhWCRkIZw5Bm9sYq1o5nCW4oJBYYmU5/NXWUKcJyG2ZyVeCtLyw2Jq+xH9g1C7eoLTGypg0VYR2mL0BTLm8TRv4IycdqYAmXng+LcxhIKbGvLy1MNVjTxXsJHEJfgXiu/wtnJrRcViY/OzsdXNgZbpQ+9U+hUjSp7qc46A30Glw/kpLIPNXqr1wpV1rFdJxKdnxIFJX6S4tBFgkjDwctfQT0W5H4nNaAJ4GwkYGibnYCRoRZPSmpuuYR0CnE80nSxAdzNOa1sHFP8bY/MahOVHbNrYUxje2NhhtC8pQgiva40q2HXAM1GTNjJvgmi8KhK1I13icAVO7BdMXownRsDvmnMypB9GKAUVTDSKwJveAiztD+WP42ZHFFCBmw2TEyREbotKGFZTTpN8h920i syUUWVTg /MbcavwiNXBXnfRq2rOANJYZET9NEbiDuSqPGVFpSeMkpOfWz3Jw/h+eKqBDge9GeT34aqMpq9s/jluMwbQCNZR0NkAMJRDAl62ocrq3b6ZvrCDi2rVpjiSSYv95AdzW7GEnR1GU87X3IsD5dUCA93vFCFLLQ3oxHQ7OhoZRSl+mdzyDrItdSheHORe32efuBx9ihSSzsS44gkc5trAS5n38cpmencgA2lvR6FB+08KAoHphWKtOwpy1uMV9Gg8VkkkyG1wZIwT0hKt6S2eLPf3mIEa8KAEpPHF3IMAtqyeyNvnxa/AFH/mJA99UURGrtRDb4geVieeiq/tLr2SOoLS/U0a5u5B6PTr2a/L0inxyRcxZgHE07ynHiwL3j9Tp7l2bUw+lcNhgMj3MEhI3agc8WPkLsXxpb9J9aMIrLif/VtSF5/S0krdnxTFALCYctqhodzUx1+VLdx+K8cOPk3XEsZxek+bLwuSknI5zqY1Sr0Cu+jdZl7mUI+xwLuxKMuBZIUpGQulPwJm8bhry8Y5IdIVaUOQJNNQsChTVdygjKa6TZ2dzRvFO3QpVNWoj8QxWTdLWUPyQSFytxhBMm7TlnCc5PGzqtSHuK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.05.23 04:21, Haibo Li wrote: Nit: "mm/gup_test: fix ioctl fail for compat task" > When tools/testing/selftests/mm/gup_test.c is compiled as 32bit, > then run on arm64 kernel, > it reports "ioctl: Inappropriate ioctl for device". > > Fix it by filling compat_ioctl in gup_test_fops > > Signed-off-by: Haibo Li > --- > mm/gup_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/gup_test.c b/mm/gup_test.c > index 8ae7307a1bb6..c0421b786dcd 100644 > --- a/mm/gup_test.c > +++ b/mm/gup_test.c > @@ -381,6 +381,7 @@ static int gup_test_release(struct inode *inode, struct file *file) > static const struct file_operations gup_test_fops = { > .open = nonseekable_open, > .unlocked_ioctl = gup_test_ioctl, > + .compat_ioctl = compat_ptr_ioctl, > .release = gup_test_release, > }; > Acked-by: David Hildenbrand -- Thanks, David / dhildenb