From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F47C04FFE for ; Tue, 14 May 2024 06:41:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B5AF6B0123; Tue, 14 May 2024 02:41:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 166256B0125; Tue, 14 May 2024 02:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 054A36B0167; Tue, 14 May 2024 02:41:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD8176B0123 for ; Tue, 14 May 2024 02:41:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 62649A1B2D for ; Tue, 14 May 2024 06:41:38 +0000 (UTC) X-FDA: 82116055476.20.6372190 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf27.hostedemail.com (Postfix) with ESMTP id EBC7E40010 for ; Tue, 14 May 2024 06:41:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JRvbgVHn; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715668896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qq9BIghgoJ+LZ1XpMSxI2larmjAnvQoJQ/47VqjuHhc=; b=0yk6pBKXczQxr33o1YnLERQxTZT7nIsq3p++3cD8/dSVWMXLll1wTtL0oJXM3MHNMQBjPc 7F1gifrcv1kyXUas10q7pszMuIAsuxylg5JNN/q5+ArmD/LVydlm/SoVzNOeFxYP0qJOG9 tMyBlLCjV3Uas9XejVBTVRsCNNlurk4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JRvbgVHn; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715668896; a=rsa-sha256; cv=none; b=WB8KMfeReX3DZANCXA83cMC2F2J0AskiFW1wyd2UwVZvtR+vFu3g2+2Q2ADXqxieYbKBJN 5fQq6yPrtzbphXbJKv6YrB1dz6WCSs826oJ3k42r8Jg3Kelq8HaLW1Uur+2eNdws9dm2uS fvjaq8iAKz+wUoZcl65iNQlwtK29r98= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715668890; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=qq9BIghgoJ+LZ1XpMSxI2larmjAnvQoJQ/47VqjuHhc=; b=JRvbgVHnVOCOxk+LgcNUGZjP8LE9HWYrqeeUvbc63kjUEKPW05as9t+dUypSHwCq1+Si61jgtotiPYW26ESh6dg1yT+CmANLGRXnVMXPIGJk477hEVzplODvGVI1QTexoLjWtk3sTPBCc/19bLMG4PJYmvL6kXZOePvK3X8Yu0E= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045046011;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0W6TyffK_1715668887; Received: from 30.97.56.67(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W6TyffK_1715668887) by smtp.aliyun-inc.com; Tue, 14 May 2024 14:41:28 +0800 Message-ID: Date: Tue, 14 May 2024 14:41:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v5 3/4] mm/mlock: check for THP missing the mlock in try_to_unmap_one() To: Lance Yang , akpm@linux-foundation.org Cc: willy@infradead.org, sj@kernel.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240513074712.7608-1-ioworker0@gmail.com> <20240513074712.7608-4-ioworker0@gmail.com> From: Baolin Wang In-Reply-To: <20240513074712.7608-4-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: beas8bw1xsr8c6skwkuqtnkidyy7qgq1 X-Rspamd-Queue-Id: EBC7E40010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715668894-651456 X-HE-Meta: U2FsdGVkX1+d7SVkBsiG5rYjewmHs0dpDlmiTLspsMsKPOm51oyH7d7tbOgm2P8MdUV8/t81keloHOb+Q6jvPOCAjBiA6V+tCBqjVkOsRe3BIt1+axiaLy4S/DeOS5gDm2GcmTWhovMmSqHYXGVgIcGbfvSLvwaHvAIGv1NxZtLKk+GltpEDqUnBdeOyNYvCvS63OHdwDas29+LoPuSGBnAQx9/D1ZJL4b3RKb89qvHZ3bdjZsFIsk2Hig5TZdLdtNJtGgYbNDE/HSnR+p+QOCp8ze8rz6IfuixRV+UDJss2PgcMRTfcXoHjDqAvI+sxpJ3OlgEQ6kwi+3bigB1CyEIb/Lv+rQTKXRxHnEQS1dx0g89RYTZNWC4SQXbkoMhvefHBP8bJbvG0hPV4fHaP6lJ/DHb1ln0XObUb5WpkI8iATaY0+Zb1RknoJE6iL/NC832j9MyAlIp6e9eJ8hjMvoTmo7ikdj0JZJ/046/DTJgdiah+D35hpgwxQTEspyEqDS4+0W9Ww72urUIYbTCblZnAi6ARrWy7aQ/EUTe7KY1QPDygB11AL+DLuYNCfC9/2NjZ/wcbpMfehqbcXeHP2KJhtNLUe7EcXcwwOJL/hGdjCMcMCVDZoVQyfMb5hFMkFcueMXcT314RI8DeSiek64DPg+qheJHqf/T8t89QQTYy+OeX98KA7eUoWS3DkRiz5GlM/+v14XCsNopyAeI7CTIk6oguvVfez545PGaZOSLgolCMKBDs+guME7OQ87X2VgfvBQw6xX60vVcB7zlZrwfEFy0IWjQpunpdtN7Xq/JCcJLbj2paAVzsCGM++YiY6N2ULH++eYcHq/BeacZHMsTwQUFa8CjUYKzuR+2iGbS9YiCiWChaLF4EmkuVLfulhVySbPl33sFUxjSLHUlxohy+fymyzBq5mEC4zrDrOBm6UkgZaFCEkmsoEB9v8s8HsCAnBC97hpFEkzQjupS sF25Ysgq b5Q6AIIx1Dan6HR9FtddBa3jNbvz8uQFodATuza1oSlT843mk2q2pMjdPeqvL+yFQCPhcuiC05VT/Isf/gfZbSOTGThvgXBaEuXUWm2YAfZVbWzaEiiyoA6RL7SEW+8zj0DRKNvMLxbjmt549nr3EquqM9+XGY6Pz9rtacT95m8tGlDbaDPVwVxUwrCYLTYp29/PZ+FvN+Vv7WOQvTi3hJ5K961JTcEensTAxnB29t1MHxZNNpy6/2UjUEbtRjr4R16wG//BvKNgTJ1Prl4fhkR8gqrtqjO0onxDx1oLqXFjmDhunUL3bJwm58/3W7tGswKLzLet32VTOdZRf23btY1hqqZLm2vmOJuqIRg9MtOUkUGMvjQZ/1pz2LRphoNebnU5HqcuMUf1N52I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/13 15:47, Lance Yang wrote: > The TTU_SPLIT_HUGE_PMD will no longer perform immediately, so we might > encounter a PMD-mapped THP missing the mlock in the VM_LOCKED range > during the pagewalk. It's likely necessary to mlock this THP to prevent > it from being picked up during page reclaim. > > Suggested-by: Baolin Wang > Signed-off-by: Lance Yang IMO, this patch should be merged into patch 2, otherwise patch 2 is buggy. Quote the description in the 'submission patches.rst' document: "When dividing your change into a series of patches, take special care to ensure that the kernel builds and runs properly after each patch in the series. Developers using ``git bisect`` to track down a problem can end up splitting your patch series at any point; they will not thank you if you introduce bugs in the middle." > --- > mm/rmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 4c4d14325f2e..08a93347f283 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1671,7 +1671,8 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > if (!(flags & TTU_IGNORE_MLOCK) && > (vma->vm_flags & VM_LOCKED)) { > /* Restore the mlock which got missed */ > - if (!folio_test_large(folio)) > + if (!folio_test_large(folio) || > + (!pvmw.pte && (flags & TTU_SPLIT_HUGE_PMD))) > mlock_vma_folio(folio, vma); > goto walk_done_err; > }