From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048DAC3DA41 for ; Wed, 10 Jul 2024 21:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FD0D6B00AC; Wed, 10 Jul 2024 17:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AC086B00AD; Wed, 10 Jul 2024 17:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C716B00AE; Wed, 10 Jul 2024 17:12:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5733E6B00AC for ; Wed, 10 Jul 2024 17:12:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 075F6A0207 for ; Wed, 10 Jul 2024 21:12:36 +0000 (UTC) X-FDA: 82325091912.14.DFD9D6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id C4B4740007 for ; Wed, 10 Jul 2024 21:12:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hzZdtfeu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720645929; a=rsa-sha256; cv=none; b=HoyGQmhiPlOLPkt6GWo+hktLsmSn4IWDXaveaMhv9IgJaF33VvpkDzd02QV2BVzS88JsDv HTpukg4BERzM0en6n374PxT+ow/PfXt9IK6inhXVLqH/dC5fvIxnnu9mZYT0ycnUD6vWPJ +lLgKGPLHzvX9rPurL8g4AaQK4ybAcw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hzZdtfeu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720645929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EDkAtSJPc4fDTZHD3QI6mFYT1Fgs+3upA6c38pBIcU0=; b=zIg2zSAGx6kZ6zAyKlyhfXwnnqyceqzU8YEYNa6kMmJOXHCkq5qLYb0iXoUFA4e/nH7h0e OuDxbw/8PTMg/ltN3qa8+wcyONvpiypZRXe4EZKZluEd4YbnHNbsqmxxrEGpovwrZ+7Vhf xSiN4h238/jnikgCC6Mc2sB1dGadatk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720645953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EDkAtSJPc4fDTZHD3QI6mFYT1Fgs+3upA6c38pBIcU0=; b=hzZdtfeux+cxAdLSrjk9qPcHk1KgG3sL74lF9jbgkpTJutD8ta7lNRw7iuo5Vf6SDiS2W0 2Q9IYHD5F43Ih+jxV/WjgaVRJOKT4PVUQBpShPg5NsB8RG59izZYHx6TjefTq9H1MqeJ1d IJa7QhZcTWd9d0KqjsExQ4Yi3IA5bo8= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-EQAV081XMmOkcVAC8YLdbg-1; Wed, 10 Jul 2024 17:12:29 -0400 X-MC-Unique: EQAV081XMmOkcVAC8YLdbg-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1fa91354ce9so1015735ad.3 for ; Wed, 10 Jul 2024 14:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720645948; x=1721250748; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EDkAtSJPc4fDTZHD3QI6mFYT1Fgs+3upA6c38pBIcU0=; b=pGrN09Y+Rd7J28+KSjES6brXpao32NtcQWaf5h/6XJw7FKN7xu6Wfwc5HJGbjbpL9d kJ7o7VN0Xo/XpoI8mSgB6gHo6/kPCq2nw3/TwDG0Oe0b0tiH+zNeYttJl+rfBB7qqQ9f DZfc9GLHNrEHuDH6p1NnNEhtE6WSe7ZBNMm7CX07bZIMBdTSBdNrviwQJQNZxxWRvLdA oRd9SOtRYbMvaP6SxljKuwSdS5P4T98Him7afs02rt/hy7WXBU7m7M0sDshpVaKNtOfH Rs8InM3sr6aRH3U1DEOJpxMNB+sz9cPhgdHkSBjIAYtZdnh20sMFiWxw2gfIR/DEYb9K mOnQ== X-Forwarded-Encrypted: i=1; AJvYcCVqt3jGIRNG8h7OujtMIkrjJnxTd02sqIqDSXE3FGEJk6rqBBm3W9tpPoT/xP0yL4etTj4I0kaY253SpJloxM0nkLY= X-Gm-Message-State: AOJu0Yyo3IfWeF/eiB4qNl7aNX8IDgj/Jev+s0sLWT2fArTdr/VYpTeR a8vp+Ib2wMeRIMJLMQsLo4uJQlFipbH+GfsdGbxW9sKTNXrmVGmfT8imJjz0qYn4X8hQJEMyoUT z+lwN5Xpfetii8WBw7jY7HVI31nxdgx10wslfRE5yj/80s9r8 X-Received: by 2002:a17:903:1210:b0:1fb:5681:5f0 with SMTP id d9443c01a7336-1fbb6ce132bmr51939785ad.23.1720645948358; Wed, 10 Jul 2024 14:12:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFeparPAWlZOWUmpNdjWGb6HKjLI7St8Hnre9nS98aWNojEhnwQSTtD7BSAWWEvfEHQAzFkeA== X-Received: by 2002:a17:903:1210:b0:1fb:5681:5f0 with SMTP id d9443c01a7336-1fbb6ce132bmr51939575ad.23.1720645947899; Wed, 10 Jul 2024 14:12:27 -0700 (PDT) Received: from [10.35.209.243] ([208.115.86.71]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6acf38dsm38026225ad.263.2024.07.10.14.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 14:12:27 -0700 (PDT) Message-ID: Date: Wed, 10 Jul 2024 23:12:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 8/8] kvm: gmem: Allow restricted userspace mappings To: Patrick Roy , Fuad Tabba Cc: seanjc@google.com, pbonzini@redhat.com, akpm@linux-foundation.org, dwmw@amazon.co.uk, rppt@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, willy@infradead.org, graf@amazon.com, derekmn@amazon.com, kalyazin@amazon.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dmatlack@google.com, chao.p.peng@linux.intel.com, xmarcalx@amazon.co.uk, James Gowans References: <20240709132041.3625501-1-roypat@amazon.co.uk> <20240709132041.3625501-9-roypat@amazon.co.uk> <47ce1b10-e031-4ac1-b88f-9d4194533745@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C4B4740007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9pxm7b9exaz1c9fkrxkqomgx4dbwnftk X-HE-Tag: 1720645953-100231 X-HE-Meta: U2FsdGVkX18jE75sHhnB99iCc4VsviFVTN2WvH6JQo/fiERicByrNYuGqJ/uKTMiDKglU+XFA3JEKSkbzCJDkHeKCivxk8CNcSzUYgLbY0/ecmY1rhTLrk1PHJAYmN97HhvnTelVSJVrbtxmCUXoEGLMeiZqPVWEiTJWfdyfIj8uhNh6A0bjOtdzxqjfkoqssAuCRJmyKh2700+gUyo/p5zxnKIhaGPig2GBwL6vEqKQApt2qRegn3fReunIYWEc0fpuBDpduVEOaJtz/iFwpwhUG30fI8uaFj2qIbn/rNTq7r6CNAiWresJek03Nox6UQhpq3+Us2abq4m4qmUHpfIIIIZk/itqdWQfLoR0Pme5rdIYdR1Gx7qztiWHbvwlth6MoeT3g0ZaxldwDFcmhRNbZEbQxMYJUfLDb+C9GQb8mCmwyN4TerFO+Vy70jzcXI+m6TMV5d97MtTRVi9iRyvDmzbVcczjbpn6Wdbm6TxT2syK3PvfRykZm3OSzrH9xtQsw4t7YBrTGGXUGkGm9Vrr/qdM0IUpckNXytB5SikMJBmi96prcfX63Lyf3RjgbKubJVQRkahEr/KjHKhkB6nDfYtQ6+u7aEZl5OYB9HXlPMlZV4xBCeRKaazhyxj3LhILBnsGGgG+yaSU+gqLJcof5u0Gf5n6rR86yCj5avn0Xku0AS3b7E4IQsM/wyo8eJLqCw81TWkSnySO7AnpbqF/IUHkAaY5DvgUpJLBaOvG+DxjKBZKl4dU1ghxCbmw6N/d+DISnHJFls5GuzrWR2GPyjm1+yyc6glrqq+cV+hfp5vGsvFTW2p2gTf6HeTfKtlh2h+wUwxtaDhQ6pq1tRhE4rhX3FBodW4ySyxnXToFCoqnxFQrSOdjEwIwISx3SzKeOjwmkdB0YQcg/FL942LRSCp0Jck4wSng1B+mIXz5kMDSFCQPkGYeIndD/GhBQ9hyqAn7QeRCK1wRvnb 5XyED+kQ wAEzq3LsAr6sktyFMvyC/JpSIyyanRdovtJV70SCtrikM/kfgJ+0b2YgRjAyeipxWcNK0VsT0wOtk4cdJS4YV5dWL29vShUMZJzxXf00miAsk04PlLN9kNNG/mji8pAz/8rO8Tmz8FMp9eA8qg5xULzdQOjolFE7Ayk7mz/6Ejz6xGg5J33pH9yElh81iJVL+dVw07mgWRxJBZFJvHnkoGzooCg4w6cjL+5wSbzVq+lgI4rBxCgEIlVZ2qtOL1oJXRcCDFJYwm7QFXeNgNvleUOGFDGBRWlQteN9YQYzdnQgty7XGSsmVzpwCJNHw/7m3CgXcMZ64q9Fgm2uOjn7XwzcNGj0rCjSnctQ0CHoKW/SwL0rOkt9e8AFmQjo+m35B4bLQaS5K2ueIdwkw6P2Bt1y2VJNjhiMM8L94cYjqlIpRT1z98YWXhiKyvFlEtbk2LSF8Z9WQYtyfgwujP2eN52tCXYQmptPmRKpAiwnFva0Uvm1xR5zUm6cQXryKFOKIBAb4JY7VwrvqDdU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.07.24 11:51, Patrick Roy wrote: > > > On 7/9/24 22:13, David Hildenbrand wrote: >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >> >> >> >> On 09.07.24 16:48, Fuad Tabba wrote: >>> Hi Patrick, >>> >>> On Tue, Jul 9, 2024 at 2:21 PM Patrick Roy wrote: >>>> >>>> Allow mapping guest_memfd into userspace. Since AS_INACCESSIBLE is set >>>> on the underlying address_space struct, no GUP of guest_memfd will be >>>> possible. >>> >>> This patch allows mapping guest_memfd() unconditionally. Even if it's >>> not guppable, there are other reasons why you wouldn't want to allow >>> this. Maybe a config flag to gate it? e.g., >> >> >> As discussed with Jason, maybe not the direction we want to take with >> guest_memfd. >> If it's private memory, it shall not be mapped. Also not via magic >> config options. >> >> We'll likely discuss some of that in the meeting MM tomorrow I guess >> (having both shared and private memory in guest_memfd). > > Oh, nice. I'm assuming you mean this meeting: > https://lore.kernel.org/linux-mm/197a2f19-c71c-fbde-a62a-213dede1f4fd@google.com/T/? > Would it be okay if I also attend? I see it also mentions huge pages, > which is another thing we are interested in, actually :) Hi, sorry for the late reply. Yes, you could have joined .... too late. There will be a summary posted soon. So far the agreement is that we're planning on allowing shared memory as part guest_memfd, and will allow that to get mapped and pinned. Private memory is not going to get mapped and pinned. If we have to disallow pinning of shared memory on top for some use cases (i.e., no directmap), I assume that could be added. > >> Note that just from staring at this commit, I don't understand the >> motivation *why* we would want to do that. > > Fair - I admittedly didn't get into that as much as I probably should > have. In our usecase, we do not have anything that pKVM would (I think) > call "guest-private" memory. I think our memory can be better described > as guest-owned, but always shared with the VMM (e.g. userspace), but > ideally never shared with the host kernel. This model lets us do a lot > of simplifying assumptions: Things like I/O can be handled in userspace > without the guest explicitly sharing I/O buffers (which is not exactly > what we would want long-term anyway, as sharing in the guest_memfd > context means sharing with the host kernel), we can easily do VM > snapshotting without needing things like TDX's TDH.EXPORT.MEM APIs, etc. Okay, so essentially you would want to use guest_memfd to only contain shard memory and disallow any pinning like for secretmem. If so, I wonder if it wouldn't be better to simply add KVM support to consume *real* secretmem memory? IIRC so far there was only demand to probably remove the directmap of private memory in guest_memfd, not of shared memory. -- Cheers, David / dhildenb