From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664A5C00528 for ; Mon, 7 Aug 2023 15:19:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02B456B007E; Mon, 7 Aug 2023 11:19:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1E878D0003; Mon, 7 Aug 2023 11:19:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF3E8D0001; Mon, 7 Aug 2023 11:19:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CBB576B007E for ; Mon, 7 Aug 2023 11:19:18 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6DB5716062A for ; Mon, 7 Aug 2023 15:19:18 +0000 (UTC) X-FDA: 81097667196.02.F92B230 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id EEA3040019 for ; Mon, 7 Aug 2023 15:19:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=efVDqU1U; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=44BPj+J2kd5X3zqNFS5sgAyOAglnP4RGRCdaFs86xSs=; b=0ur44bh9AO4hqVEaFgZzkdUolsdgDVrQoKpt7rBmdQ2otr4HFI5KrvFsJudGnKdIiwEeXc 6aq4RNjpOozwJh4HmcHFxRtSxB/SjfLDXb2y1HdHNDq/gT6JOLAVSSXb9B3BeRnZgI8CUt kj7C2hLAzb+9b5Kk/OxNWBjm7ptRuxY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421556; a=rsa-sha256; cv=none; b=ruzVT2XQoCtKWjqRYAQ0vEQxwUDHOtZAOweRq0xEG96Z4Q8p/1jpUEUQ1/pNzVd9UWDiFP 3VAxpmcMG5MzwEtwRI1aMGZdMyNUy0Dj2S5roV+Tf3k5RBGEK5zsRVj7qwsfrGaidWJfB/ tsO4JYCezDR58yhICQ/1KBgFKEiKACE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=efVDqU1U; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691421555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=44BPj+J2kd5X3zqNFS5sgAyOAglnP4RGRCdaFs86xSs=; b=efVDqU1UIDNkB7eee7jzcwoSuETVfLr9NVxNyfE5UGBr0C4hrRF23mPz7DuJIj/QlaWpY8 FGJrxmUz6FlEi2af3LKavMz3gVZYi0GlDfKKdBUIO/LpFVNiKoOr3hKTp9NkMNbgtXXvPh xSeQccpJzxGPrbUtTEyxov7bO9DXOAI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-0RM8AI2RN42oJp-d31N_hQ-1; Mon, 07 Aug 2023 11:19:14 -0400 X-MC-Unique: 0RM8AI2RN42oJp-d31N_hQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-317a0d22311so2613555f8f.0 for ; Mon, 07 Aug 2023 08:19:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691421553; x=1692026353; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=44BPj+J2kd5X3zqNFS5sgAyOAglnP4RGRCdaFs86xSs=; b=C1YSfyVkbPW/0mJ/FHn90VInzKORd0GGBE7mI9PpLBiubFRVKHSYpk+8Lo4Xc0yAna DqhaUPcQK0l0PYrdXZOqfI1qAZSLXMhnuMDVF3HUgWHal1YmiEbp0xzuF4E6oPZB0IFl 6VuwtksU16pERWNKO+12wscn+R16eXWZcomP8zUvM4uVlqENNmssrIQZPndH3ptSe8Pf mu47ramhcqrLrox2QW/ioq5nFbl9OrMW/ODh/JHE9o0D4ukePOfUcOnS5W3TG1cInoOL lE1G3IUy0B5eMRvP8CP485IrB6mPzYwz+sUalAXBLZCoy4vgCbKfEzMAW0j7aKwBuebq 1WZw== X-Gm-Message-State: AOJu0Ywzp29YNoo9nyYIAtQu8ogrpCo1MWXkkVGQr99e1VRA6/xBo1Eu JNZLlw6o/mKbov25NNq57JjKHvLI9ulrknaHJgyj8OBnlruFQJbmKr8tSG9X5Y+DAUvtuXDZpEX aBPy5XjbBBbdCWZNizBc= X-Received: by 2002:adf:e78a:0:b0:314:336e:d4d8 with SMTP id n10-20020adfe78a000000b00314336ed4d8mr7542585wrm.8.1691421552815; Mon, 07 Aug 2023 08:19:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAYhMr/LiQB7IZCVcR86nWkRq/u1LTG2+/5EEbImNgdQE9L2G0GIJPL/NqCi4ysPuBJq0X8w== X-Received: by 2002:adf:e78a:0:b0:314:336e:d4d8 with SMTP id n10-20020adfe78a000000b00314336ed4d8mr7542577wrm.8.1691421552532; Mon, 07 Aug 2023 08:19:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:5d00:5143:1cd2:a300:ceff? (p200300cbc7405d0051431cd2a300ceff.dip0.t-ipconnect.de. [2003:cb:c740:5d00:5143:1cd2:a300:ceff]) by smtp.gmail.com with ESMTPSA id l12-20020adff48c000000b0030ada01ca78sm10775859wro.10.2023.08.07.08.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:19:12 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 17:19:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/7] mm/swap_state.c: use helper macro K() To: Peng Zhang , linux-mm@kvack.org Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-4-zhangpeng362@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230804012559.2617515-4-zhangpeng362@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EEA3040019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tuoxgfk9cp85jttn9i4a1wb6xg9ot37y X-HE-Tag: 1691421555-386640 X-HE-Meta: U2FsdGVkX199mD5oqwnf2vfdy+EC8bDFy5tnfZINcFMGHo6hiimnGtAG5aFYX4EgrLyWL41/9pHT8Tg19PjBYTTAIg9X9JgunFlDRQZlqFFAjlKhsAmJJgAnHqaV6sg8sP8snHMOLcKARxXfoPb5YRZtBzdyMLgECMsd00k3zqHE0gZL3x01uhBNk7rhygGOGpK3xTxK1x2EAbmsWI2ZOZ9YmjSCtYLth4+dIQokNcpiTUPziJnvbjx4jN3d5/LkW29i3PoFxSWUpSqeEXzyoBshfLjJF/qUd+CWT/lBQXc7TME7ASK9gP4WVT/iB4zToOBZbLMFxG+ffSP8pADq7m+J6C1lRbr2T3Gp69Rk0fo6K0DxQvrxReB2EQBJXz9HAiyla1uzpj/oq6U1gtY2RD1lAagenFWArx1FJ4CC6fBiMfhrjsIwU2E5vXP3mkJayvA8Ny80Lsd10d6bQFTRyKnxoQeXKpNnXq0uErauIAF+/A/fzZMVALpTEBYxmIjGtBXxyYuiD/Gn+K7yJiJ3+F5JRSFClpV7j40QzMuDD7KnANzbx0tNepFItkOCZ5EiSqLj+j2BcZAql+4snaHOnN4KGdBfbeBtyloMpqLZe+hZgO7NsEGwvDBIC3gE+iGfhhSzpn1DxBdl6TR5qPeNupU9cJTmMTWuIe+g8gJe99BqIlXpL1uMZNIGGHb6wPB2Ew8fTNwkxpuDrwjnGGCVo19Xha00taD6G3kBlpgQmvEPJT4kILASRQG2e8KcVCjTgmU5Ao1TxG9HVMHen6XW58WVVYyuEQzm0isJiOIUidqLN0Rs5hc02oBDvzrmYPl2Bn3aJzjvhMN8ct/Vg7gROYq6WyqKWo3IARwgswWXlkP77nutHlZGEFZ17M7/XLz/UIPHX66IxhmQ8unqKXM4uPj6UWDOwcPAaINy976NaL7VKUUcgHhOF82BdQzb6BRinmTspPHlGIp0Mo36+lv wY+E+q2I i+r2XkkO+3T8QIHTdBdWDNVOOMfAwcTRGrN1oTFxPkJgjT++HYShL5d38vyVDe/fOjWDdOPQ74wq1UUWeYf7U8dofFJjzDze66JPpWMUXj/lLD7zmFHHrH5vnd8IqI7+Qv+z80u0X/N2pDyHpZBZYNzSIfafldrsCzrY3+0f43yMi6NDaqd74Z+jTlZ4M0ljgY0DGsg6As71tc8yCuMJFEcTV3sEQVpa2lnhaQJvIPRE9BUu8hZiv7QEs+ToyLKnrTXGZ5KVR0ovNJcGK7IaOFTCWnL7utLUx95jbSCjCHogaPBNqG0F+aAKypFxpBJO9h69jSCvhP9fbAS+cot2xMszusfZO5vlG29LfMaTLubd1g6RP4dpEjSZsAyA8QM0BEMaQRjrKdIqDq4M0Uq9XkIGcuZcf2t3FoxMqVR1XJEIkdwI6ISJ0KmXUJd/qUl2SSb5w1CgcyzW0RVEgvVjlr+WaFlw5z9tUeNPJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.08.23 03:25, Peng Zhang wrote: > From: ZhangPeng > > Use helper macro K() to improve code readability. No functional > modification involved. > > Signed-off-by: ZhangPeng > --- > mm/swap_state.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index 5a690c79cc13..01f15139b7d9 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -63,9 +63,8 @@ static atomic_t swapin_readahead_hits = ATOMIC_INIT(4); > void show_swap_cache_info(void) > { > printk("%lu pages in swap cache\n", total_swapcache_pages()); > - printk("Free swap = %ldkB\n", > - get_nr_swap_pages() << (PAGE_SHIFT - 10)); > - printk("Total swap = %lukB\n", total_swap_pages << (PAGE_SHIFT - 10)); > + printk("Free swap = %ldkB\n", K(get_nr_swap_pages())); > + printk("Total swap = %lukB\n", K(total_swap_pages)); > } > > void *get_shadow_from_swap_cache(swp_entry_t entry) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb