From: Alistair Popple <apopple@nvidia.com>
To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org
Cc: Alistair Popple <apopple@nvidia.com>,
lina@asahilina.net, zhang.lyra@gmail.com,
gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com,
jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com,
will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com,
dave.hansen@linux.intel.com, ira.weiny@intel.com,
willy@infradead.org, djwong@kernel.org, tytso@mit.edu,
linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev,
linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com,
Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH v5 01/25] fuse: Fix dax truncate/punch_hole fault path
Date: Tue, 7 Jan 2025 14:42:17 +1100 [thread overview]
Message-ID: <f20cc2603bd33ee05ec4bc4cc7327cec61119796.1736221254.git-series.apopple@nvidia.com> (raw)
In-Reply-To: <cover.425da7c4e76c2749d0ad1734f972b06114e02d52.1736221254.git-series.apopple@nvidia.com>
FS DAX requires file systems to call into the DAX layout prior to
unlinking inodes to ensure there is no ongoing DMA or other remote
access to the direct mapped page. The fuse file system implements
fuse_dax_break_layouts() to do this which includes a comment
indicating that passing dmap_end == 0 leads to unmapping of the whole
file.
However this is not true - passing dmap_end == 0 will not unmap
anything before dmap_start, and further more
dax_layout_busy_page_range() will not scan any of the range to see if
there maybe ongoing DMA access to the range. Fix this by checking for
dmap_end == 0 in fuse_dax_break_layouts() and pass the entire file
range to dax_layout_busy_page_range().
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Fixes: 6ae330cad6ef ("virtiofs: serialize truncate/punch_hole and dax fault path")
Cc: Vivek Goyal <vgoyal@redhat.com>
---
I am not at all familiar with the fuse file system driver so I have no
idea if the comment is relevant or not and whether the documented
behaviour for dmap_end == 0 is ever relied upon. However this seemed
like the safest fix unless someone more familiar with fuse can confirm
that dmap_end == 0 is never used.
---
fs/fuse/dax.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
index 9abbc2f..c5d1fea 100644
--- a/fs/fuse/dax.c
+++ b/fs/fuse/dax.c
@@ -693,6 +693,10 @@ int fuse_dax_break_layouts(struct inode *inode, u64 dmap_start,
ret = __fuse_dax_break_layouts(inode, &retry, dmap_start,
dmap_end);
} while (ret == 0 && retry);
+ if (!dmap_end) {
+ dmap_start = 0;
+ dmap_end = LLONG_MAX;
+ }
return ret;
}
--
git-series 0.9.1
next prev parent reply other threads:[~2025-01-07 3:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 3:42 [PATCH v5 00/25] fs/dax: Fix ZONE_DEVICE page reference counts Alistair Popple
2025-01-07 3:42 ` Alistair Popple [this message]
2025-01-08 22:30 ` [PATCH v5 01/25] fuse: Fix dax truncate/punch_hole fault path Dan Williams
2025-01-09 4:38 ` Alistair Popple
2025-01-07 3:42 ` [PATCH v5 02/25] fs/dax: Return unmapped busy pages from dax_layout_busy_page_range() Alistair Popple
2025-01-08 22:30 ` Dan Williams
2025-01-07 3:42 ` [PATCH v5 03/25] fs/dax: Don't skip locked entries when scanning entries Alistair Popple
2025-01-08 22:50 ` Dan Williams
2025-01-09 5:21 ` Alistair Popple
2025-01-07 3:42 ` [PATCH v5 04/25] fs/dax: Refactor wait for dax idle page Alistair Popple
2025-01-07 3:42 ` [PATCH v5 05/25] fs/dax: Create a common implementation to break DAX layouts Alistair Popple
2025-01-09 0:14 ` Dan Williams
2025-01-09 6:15 ` Alistair Popple
2025-01-10 6:56 ` Dan Williams
2025-01-07 3:42 ` [PATCH v5 06/25] fs/dax: Always remove DAX page-cache entries when breaking layouts Alistair Popple
2025-01-07 3:42 ` [PATCH v5 07/25] fs/dax: Ensure all pages are idle prior to filesystem unmount Alistair Popple
2025-01-07 3:42 ` [PATCH v5 08/25] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag Alistair Popple
2025-01-07 3:42 ` [PATCH v5 09/25] mm/gup: Remove redundant check for PCI P2PDMA page Alistair Popple
2025-01-07 3:42 ` [PATCH v5 10/25] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma Alistair Popple
2025-01-07 3:42 ` [PATCH v5 11/25] mm: Allow compound zone device pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 12/25] mm/memory: Enhance insert_page_into_pte_locked() to create writable mappings Alistair Popple
2025-01-07 3:42 ` [PATCH v5 13/25] mm/memory: Add vmf_insert_page_mkwrite() Alistair Popple
2025-01-07 3:42 ` [PATCH v5 14/25] rmap: Add support for PUD sized mappings to rmap Alistair Popple
2025-01-07 11:36 ` David Hildenbrand
2025-01-07 3:42 ` [PATCH v5 15/25] huge_memory: Add vmf_insert_folio_pud() Alistair Popple
2025-01-08 3:54 ` kernel test robot
2025-01-07 3:42 ` [PATCH v5 16/25] huge_memory: Add vmf_insert_folio_pmd() Alistair Popple
2025-01-07 3:42 ` [PATCH v5 17/25] memremap: Add is_devdax_page() and is_fsdax_page() helpers Alistair Popple
2025-01-07 3:42 ` [PATCH v5 18/25] mm/gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 19/25] proc/task_mmu: Mark devdax and fsdax pages as always unpinned Alistair Popple
2025-01-07 3:42 ` [PATCH v5 20/25] mm/mlock: Skip ZONE_DEVICE PMDs during mlock Alistair Popple
2025-01-07 3:42 ` [PATCH v5 21/25] fs/dax: Properly refcount fs dax pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 22/25] device/dax: Properly refcount device dax pages when mapping Alistair Popple
2025-01-07 3:42 ` [PATCH v5 23/25] mm: Remove pXX_devmap callers Alistair Popple
2025-01-07 3:42 ` [PATCH v5 24/25] mm: Remove devmap related functions and page table bits Alistair Popple
2025-01-07 3:42 ` [PATCH v5 25/25] Revert "riscv: mm: Add support for ZONE_DEVICE" Alistair Popple
2025-01-08 6:26 ` [PATCH v5 00/25] fs/dax: Fix ZONE_DEVICE page reference counts Andrew Morton
2025-01-08 21:51 ` Dan Williams
2025-01-09 1:34 ` Alison Schofield
2025-01-10 6:03 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f20cc2603bd33ee05ec4bc4cc7327cec61119796.1736221254.git-series.apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=lina@asahilina.net \
--cc=linmiaohe@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=peterx@redhat.com \
--cc=tytso@mit.edu \
--cc=vgoyal@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox