From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C33C4CECC for ; Mon, 27 Apr 2020 17:50:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F30B2087E for ; Mon, 27 Apr 2020 17:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TZz5opkN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F30B2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A0C2C8E0005; Mon, 27 Apr 2020 13:50:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BBF28E0001; Mon, 27 Apr 2020 13:50:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D1D68E0005; Mon, 27 Apr 2020 13:50:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 73A2B8E0001 for ; Mon, 27 Apr 2020 13:50:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2B3BD180AD804 for ; Mon, 27 Apr 2020 17:50:09 +0000 (UTC) X-FDA: 76754373738.10.ghost51_75b4a5c95c33d X-HE-Tag: ghost51_75b4a5c95c33d X-Filterd-Recvd-Size: 4562 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 17:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588009808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=prqAxgFr6PVBN2ofz3Ot2pdQgnhfZPypo4uWBO/oYPs=; b=TZz5opkNJ8kcsMTO2rftbKyicKcJrWoZwbqv5qh0qePJgKyAb84CWi5vL+JAt1sUOzV3GH 041PZnUCNXzEgw8Lrcv0PiVRUVE3xrQuz/ie2W7l9oIgpHZFJAUelT1TF1+pD+kRI8MAqO AARNxxlakhMdBgYBvLI5P17t48UoU2I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-FyZPzI5YOnCLabIKugFHgQ-1; Mon, 27 Apr 2020 13:50:01 -0400 X-MC-Unique: FyZPzI5YOnCLabIKugFHgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 647F687308F; Mon, 27 Apr 2020 17:49:59 +0000 (UTC) Received: from llong.remote.csb (ovpn-112-176.rdu2.redhat.com [10.10.112.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8EC7C10013A1; Mon, 27 Apr 2020 17:49:57 +0000 (UTC) Subject: Re: [PATCH v2] mm/slub: Fix incorrect interpretation of s->offset From: Waiman Long To: Christopher Lameter Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Changbin Du , Matthew Wilcox References: <20200427140822.18619-1-longman@redhat.com> <9a12baf2-eaa8-c820-ef9d-1f29819a0c43@redhat.com> Organization: Red Hat Message-ID: Date: Mon, 27 Apr 2020 13:49:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <9a12baf2-eaa8-c820-ef9d-1f29819a0c43@redhat.com> Content-Type: multipart/alternative; boundary="------------4BBD819D1EB2E521ABB0D76E" Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------4BBD819D1EB2E521ABB0D76E Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 4/27/20 1:42 PM, Waiman Long wrote: > >>> +static inline unsigned int get_info_end(struct kmem_cache *s) >> static inline track_offset()? >> > The main reason why I don't use that is because there is a track data > structure in slub. There are functions name get_track() and > set_track(). I don't want to confuse with them. Oh, I now realize that Matt meant the offset of the track data structure. Depending on the debug option, there may not be a track data structure at that offset. Cheers, Longman --------------4BBD819D1EB2E521ABB0D76E Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit
On 4/27/20 1:42 PM, Waiman Long wrote:

+static inline unsigned int get_info_end(struct kmem_cache *s)
static inline track_offset()?

The main reason why I don't use that is because there is a track data structure in slub. There are functions name get_track() and set_track(). I don't want to confuse with them.

Oh, I now realize that Matt meant the offset of the track data structure. Depending on the debug option, there may not be a track data structure at that offset.

Cheers,
Longman

--------------4BBD819D1EB2E521ABB0D76E--