From: Waiman Long <longman@redhat.com>
To: Christopher Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Changbin Du <changbin.du@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] mm/slub: Fix incorrect interpretation of s->offset
Date: Mon, 27 Apr 2020 13:49:57 -0400 [thread overview]
Message-ID: <f1fc8a13-943d-446f-715c-16567a28e59f@redhat.com> (raw)
In-Reply-To: <9a12baf2-eaa8-c820-ef9d-1f29819a0c43@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On 4/27/20 1:42 PM, Waiman Long wrote:
>
>>> +static inline unsigned int get_info_end(struct kmem_cache *s)
>> static inline track_offset()?
>>
> The main reason why I don't use that is because there is a track data
> structure in slub. There are functions name get_track() and
> set_track(). I don't want to confuse with them.
Oh, I now realize that Matt meant the offset of the track data
structure. Depending on the debug option, there may not be a track data
structure at that offset.
Cheers,
Longman
[-- Attachment #2: Type: text/html, Size: 1083 bytes --]
prev parent reply other threads:[~2020-04-27 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:08 Waiman Long
2020-04-27 14:22 ` Matthew Wilcox
2020-04-27 16:10 ` Christopher Lameter
2020-04-27 17:42 ` Waiman Long
2020-04-27 17:49 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1fc8a13-943d-446f-715c-16567a28e59f@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=changbin.du@gmail.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox